DoctrineCommand::getEntityManager() - Code Metrics - Inspection of "Port commands for Symfony 4.2 (follows #876)" - doctrine/DoctrineBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#877)

by Kévin

created 2018-11-23 18:27 UTC

DoctrineCommand::getEntityManager() A

↳ Parent: DoctrineCommand

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	14
rs	9.7998
cc	3
nc	3
nop	2

<?php

namespace Doctrine\Bundle\DoctrineBundle\Command;

use Doctrine\Common\Persistence\ManagerRegistry;
use Doctrine\DBAL\Connection;
use Doctrine\DBAL\Sharding\PoolingShardConnection;
use Doctrine\ORM\EntityManager;
use Doctrine\ORM\Tools\EntityGenerator;
use LogicException;
use Symfony\Component\Console\Command\Command;

/**
 * Base class for Doctrine console commands to extend from.
 *
 * @internal
 */
abstract class DoctrineCommand extends Command
{
    /**
     * @var ManagerRegistry
     */
    protected $doctrine;

    public function __construct(ManagerRegistry $doctrine)
    {
        parent::__construct();

        $this->doctrine = $doctrine;
    }

    /**
     * get a doctrine entity generator
     *
     * @return EntityGenerator
     */
    protected function getEntityGenerator()
    {
        $entityGenerator = new EntityGenerator();
        $entityGenerator->setGenerateAnnotations(false);
        $entityGenerator->setGenerateStubMethods(true);
        $entityGenerator->setRegenerateEntityIfExists(false);
        $entityGenerator->setUpdateEntityIfExists(true);
        $entityGenerator->setNumSpaces(4);
        $entityGenerator->setAnnotationPrefix('ORM\\');

        return $entityGenerator;
    }

    /**
     * Get a doctrine entity manager by symfony name.
     *
     * @param string   $name
     * @param int|null $shardId
     *
     * @return EntityManager
     */
    protected function getEntityManager($name, $shardId = null)
    {
        $manager = $this->doctrine->getManager($name);

        if ($shardId) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            if (! $manager->getConnection() instanceof PoolingShardConnection) {
                throw new LogicException(sprintf("Connection of EntityManager '%s' must implement shards configuration.", $name));
            }

            $manager->getConnection()->connect($shardId);
        }

        return $manager;
    }

    /**
     * Get a doctrine dbal connection by symfony name.
     *
     * @param string $name
     *
     * @return Connection
     */
    protected function getDoctrineConnection($name)
    {
        return $this->doctrine->getConnection($name);
    }
}


1			<?php
2
3			namespace Doctrine\Bundle\DoctrineBundle\Command;
4
5			use Doctrine\Common\Persistence\ManagerRegistry;
6			use Doctrine\DBAL\Connection;
7			use Doctrine\DBAL\Sharding\PoolingShardConnection;
8			use Doctrine\ORM\EntityManager;
9			use Doctrine\ORM\Tools\EntityGenerator;
10			use LogicException;
11			use Symfony\Component\Console\Command\Command;
12
13			/**
14			* Base class for Doctrine console commands to extend from.
15			*
16			* @internal
17			*/
18			abstract class DoctrineCommand extends Command
19			{
20			/**
21			* @var ManagerRegistry
22			*/
23			protected $doctrine;
24
25			public function __construct(ManagerRegistry $doctrine)
26			{
27			parent::__construct();
28
29			$this->doctrine = $doctrine;
30			}
31
32			/**
33			* get a doctrine entity generator
34			*
35			* @return EntityGenerator
36			*/
37			protected function getEntityGenerator()
38			{
39			$entityGenerator = new EntityGenerator();
40			$entityGenerator->setGenerateAnnotations(false);
41			$entityGenerator->setGenerateStubMethods(true);
42			$entityGenerator->setRegenerateEntityIfExists(false);
43			$entityGenerator->setUpdateEntityIfExists(true);
44			$entityGenerator->setNumSpaces(4);
45			$entityGenerator->setAnnotationPrefix('ORM\\');
46
47			return $entityGenerator;
48			}
49
50			/**
51			* Get a doctrine entity manager by symfony name.
52			*
53			* @param string $name
54			* @param int\|null $shardId
55			*
56			* @return EntityManager
57			*/
58			protected function getEntityManager($name, $shardId = null)
59			{
60			$manager = $this->doctrine->getManager($name);
61
62			if ($shardId) {
			0 ignored issues – show Bug Best Practice introduced 2018-09-26 00:42 UTC by Report Bug Copy Issue Report The expression `$shardId` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be zero. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
63			if (! $manager->getConnection() instanceof PoolingShardConnection) {
64			throw new LogicException(sprintf("Connection of EntityManager '%s' must implement shards configuration.", $name));
65			}
66
67			$manager->getConnection()->connect($shardId);
68			}
69
70			return $manager;
71			}
72
73			/**
74			* Get a doctrine dbal connection by symfony name.
75			*
76			* @param string $name
77			*
78			* @return Connection
79			*/
80			protected function getDoctrineConnection($name)
81			{
82			return $this->doctrine->getConnection($name);
83			}
84			}
85

doctrine / DoctrineBundle

Pull Request — master (#877)

DoctrineCommand::getEntityManager() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like