ServiceEntityRepositoryTest::setUpBeforeClass() - Code Metrics - Inspection of "Merge release 2.1.2 into master" - doctrine/DoctrineBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1203)

unknown

created 2020-08-25 10:57 UTC

ServiceEntityRepositoryTest::setUpBeforeClass() A

↳ Parent: ServiceEntityRepositoryTest

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	0

<?php

namespace Doctrine\Bundle\DoctrineBundle\Tests\Repository;

use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
use Doctrine\ORM\EntityManagerInterface;
use Doctrine\Persistence\ManagerRegistry;
use PHPUnit\Framework\TestCase;

class ServiceEntityRepositoryTest extends TestCase
{
    public static function setUpBeforeClass() : void
    {
        if (interface_exists(EntityManagerInterface::class)) {
            return;
        }

        self::markTestSkipped('This test requires ORM');
    }

    /**
     * @expectedException \LogicException
     * @expectedExceptionMessage Could not find the entity manager for class "Doctrine\Bundle\DoctrineBundle\Tests\Repository\TestEntity". Check your Doctrine configuration to make sure it is configured to load this entity’s metadata.
     */
    public function testConstructorThrowsExceptionWhenNoManagerFound() : void
    {
        $registry = $this->getMockBuilder(ManagerRegistry::class)->getMock();
        new ServiceEntityRepository($registry, TestEntity::class);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			namespace Doctrine\Bundle\DoctrineBundle\Tests\Repository;
4
5			use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
6			use Doctrine\ORM\EntityManagerInterface;
7			use Doctrine\Persistence\ManagerRegistry;
8			use PHPUnit\Framework\TestCase;
9
10			class ServiceEntityRepositoryTest extends TestCase
11			{
12			public static function setUpBeforeClass() : void
13			{
14			if (interface_exists(EntityManagerInterface::class)) {
15			return;
16			}
17
18			self::markTestSkipped('This test requires ORM');
19			}
20
21			/**
22			* @expectedException \LogicException
23			* @expectedExceptionMessage Could not find the entity manager for class "Doctrine\Bundle\DoctrineBundle\Tests\Repository\TestEntity". Check your Doctrine configuration to make sure it is configured to load this entity’s metadata.
24			*/
25			public function testConstructorThrowsExceptionWhenNoManagerFound() : void
26			{
27			$registry = $this->getMockBuilder(ManagerRegistry::class)->getMock();
28			new ServiceEntityRepository($registry, TestEntity::class);
			0 ignored issues – show Documentation introduced 2019-12-18 14:41 UTC by Report Bug Copy Issue Report `$registry` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Doctrine\Persistence\ManagerRegistry>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
29			}
30			}
31

doctrine / DoctrineBundle

Pull Request — master (#1203)

ServiceEntityRepositoryTest::setUpBeforeClass() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like