ContainerEntityListenerResolverTest - Code Metrics - Inspection of "Add ContainerEntityListenerResolver + load listene..." - doctrine/DoctrineBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#951)

by David

created 2019-04-09 15:19 UTC

ContainerEntityListenerResolverTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	131
Duplicated Lines	46.56 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	8
lcom	1
cbo	2
dl	61
loc	131
rs	10
c	0
b	0
f	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	7	1
A	testResolveClass()	8	8	1
A	testRegisterClassAndResolve()	9	9	1
A	testRegisterServiceAndResolve()	0	21	1
A	testRegisterMissingServiceAndResolve()	0	14	1
A	testClearOne()	22	22	1
A	testClearAll()	22	22	1
A	testRegisterStringException()	0	4	1

How to fix Duplicated Code

<?php

namespace Doctrine\Bundle\DoctrineBundle\Tests\Mapping;

use Doctrine\Bundle\DoctrineBundle\Mapping\ContainerEntityListenerResolver;
use PHPUnit\Framework\TestCase;
use PHPUnit_Framework_MockObject_MockObject;
use Psr\Container\ContainerInterface;

class ContainerEntityListenerResolverTest extends TestCase
{
    /** @var ContainerEntityListenerResolver */
    private $resolver;

    /** @var ContainerInterface|PHPUnit_Framework_MockObject_MockObject */
    private $container;

    protected function setUp()
    {
        parent::setUp();

        $this->container = $this->createMock(ContainerInterface::class);
        $this->resolver  = new ContainerEntityListenerResolver($this->container);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testResolveClass()

    {
        $className = '\Doctrine\Bundle\DoctrineBundle\Tests\Mapping\EntityListener1';
        $object    = $this->resolver->resolve($className);

        $this->assertInstanceOf($className, $object);
        $this->assertSame($object, $this->resolver->resolve($className));
    }

    public function testRegisterClassAndResolve()

    {
        $className = '\Doctrine\Bundle\DoctrineBundle\Tests\Mapping\EntityListener1';
        $object    = new $className();

        $this->resolver->register($object);

        $this->assertSame($object, $this->resolver->resolve($className));
    }

    public function testRegisterServiceAndResolve()
    {
        $className = '\Doctrine\Bundle\DoctrineBundle\Tests\Mapping\EntityListener1';
        $serviceId = 'app.entity_listener';
        $object    = new $className();

        $this->resolver->registerService($className, $serviceId);
        $this->container
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->any())
            ->method('has')
            ->with($serviceId)
            ->will($this->returnValue(true));
        $this->container
            ->expects($this->any())
            ->method('get')
            ->with($serviceId)
            ->will($this->returnValue($object));

        $this->assertInstanceOf($className, $this->resolver->resolve($className));
        $this->assertSame($object, $this->resolver->resolve($className));
    }

    /**
     * @expectedException \RuntimeException
     * @expectedExceptionMessage There is no service named
     */
    public function testRegisterMissingServiceAndResolve()
    {
        $className = '\Doctrine\Bundle\DoctrineBundle\Tests\Mapping\EntityListener1';
        $serviceId = 'app.entity_listener';

        $this->resolver->registerService($className, $serviceId);
        $this->container
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->any())
            ->method('has')
            ->with($serviceId)
            ->will($this->returnValue(false));

        $this->resolver->resolve($className);
    }

    public function testClearOne()

    {
        $className1 = '\Doctrine\Bundle\DoctrineBundle\Tests\Mapping\EntityListener1';
        $className2 = '\Doctrine\Bundle\DoctrineBundle\Tests\Mapping\EntityListener2';

        $obj1 = $this->resolver->resolve($className1);
        $obj2 = $this->resolver->resolve($className2);

        $this->assertInstanceOf($className1, $obj1);
        $this->assertInstanceOf($className2, $obj2);

        $this->assertSame($obj1, $this->resolver->resolve($className1));
        $this->assertSame($obj2, $this->resolver->resolve($className2));

        $this->resolver->clear($className1);

        $this->assertInstanceOf($className1, $this->resolver->resolve($className1));
        $this->assertInstanceOf($className2, $this->resolver->resolve($className2));

        $this->assertNotSame($obj1, $this->resolver->resolve($className1));
        $this->assertSame($obj2, $this->resolver->resolve($className2));
    }

    public function testClearAll()

    {
        $className1 = '\Doctrine\Bundle\DoctrineBundle\Tests\Mapping\EntityListener1';
        $className2 = '\Doctrine\Bundle\DoctrineBundle\Tests\Mapping\EntityListener2';

        $obj1 = $this->resolver->resolve($className1);
        $obj2 = $this->resolver->resolve($className2);

        $this->assertInstanceOf($className1, $obj1);
        $this->assertInstanceOf($className2, $obj2);

        $this->assertSame($obj1, $this->resolver->resolve($className1));
        $this->assertSame($obj2, $this->resolver->resolve($className2));

        $this->resolver->clear();

        $this->assertInstanceOf($className1, $this->resolver->resolve($className1));
        $this->assertInstanceOf($className2, $this->resolver->resolve($className2));

        $this->assertNotSame($obj1, $this->resolver->resolve($className1));
        $this->assertNotSame($obj2, $this->resolver->resolve($className2));
    }

    /**
     * @expectedException \InvalidArgumentException
     * @expectedExceptionMessage An object was expected, but got "string".
     */
    public function testRegisterStringException()
    {
        $this->resolver->register('CompanyContractListener');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}

class EntityListener1
{
}

class EntityListener2
{
}


1		<?php
2
3		namespace Doctrine\Bundle\DoctrineBundle\Tests\Mapping;
4
5		use Doctrine\Bundle\DoctrineBundle\Mapping\ContainerEntityListenerResolver;
6		use PHPUnit\Framework\TestCase;
7		use PHPUnit_Framework_MockObject_MockObject;
8		use Psr\Container\ContainerInterface;
9
10		class ContainerEntityListenerResolverTest extends TestCase
11		{
12		/** @var ContainerEntityListenerResolver */
13		private $resolver;
14
15		/** @var ContainerInterface\|PHPUnit_Framework_MockObject_MockObject */
16		private $container;
17
18		protected function setUp()
19		{
20		parent::setUp();
21
22		$this->container = $this->createMock(ContainerInterface::class);
23		$this->resolver = new ContainerEntityListenerResolver($this->container);
		0 ignored issues – show Documentation introduced 2019-04-07 11:51 UTC by Report Bug Copy Issue Report `$this->container` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Psr\Container\ContainerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
24		}
25
26	View Code Duplication	public function testResolveClass()
		0 ignored issues – show Duplication introduced 2016-10-31 14:09 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
27		{
28		$className = '\Doctrine\Bundle\DoctrineBundle\Tests\Mapping\EntityListener1';
29		$object = $this->resolver->resolve($className);
30
31		$this->assertInstanceOf($className, $object);
32		$this->assertSame($object, $this->resolver->resolve($className));
33		}
34
35	View Code Duplication	public function testRegisterClassAndResolve()
		0 ignored issues – show Duplication introduced 2016-10-31 14:09 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36		{
37		$className = '\Doctrine\Bundle\DoctrineBundle\Tests\Mapping\EntityListener1';
38		$object = new $className();
39
40		$this->resolver->register($object);
41
42		$this->assertSame($object, $this->resolver->resolve($className));
43		}
44
45		public function testRegisterServiceAndResolve()
46		{
47		$className = '\Doctrine\Bundle\DoctrineBundle\Tests\Mapping\EntityListener1';
48		$serviceId = 'app.entity_listener';
49		$object = new $className();
50
51		$this->resolver->registerService($className, $serviceId);
52		$this->container
		0 ignored issues – show Bug introduced 2019-04-07 12:16 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `Psr\Container\ContainerInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
53		->expects($this->any())
54		->method('has')
55		->with($serviceId)
56		->will($this->returnValue(true));
57		$this->container
58		->expects($this->any())
59		->method('get')
60		->with($serviceId)
61		->will($this->returnValue($object));
62
63		$this->assertInstanceOf($className, $this->resolver->resolve($className));
64		$this->assertSame($object, $this->resolver->resolve($className));
65		}
66
67		/**
68		* @expectedException \RuntimeException
69		* @expectedExceptionMessage There is no service named
70		*/
71		public function testRegisterMissingServiceAndResolve()
72		{
73		$className = '\Doctrine\Bundle\DoctrineBundle\Tests\Mapping\EntityListener1';
74		$serviceId = 'app.entity_listener';
75
76		$this->resolver->registerService($className, $serviceId);
77		$this->container
		0 ignored issues – show Bug introduced 2019-04-07 12:16 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `Psr\Container\ContainerInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
78		->expects($this->any())
79		->method('has')
80		->with($serviceId)
81		->will($this->returnValue(false));
82
83		$this->resolver->resolve($className);
84		}
85
86	View Code Duplication	public function testClearOne()
		0 ignored issues – show Duplication introduced 2016-10-31 14:09 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
87		{
88		$className1 = '\Doctrine\Bundle\DoctrineBundle\Tests\Mapping\EntityListener1';
89		$className2 = '\Doctrine\Bundle\DoctrineBundle\Tests\Mapping\EntityListener2';
90
91		$obj1 = $this->resolver->resolve($className1);
92		$obj2 = $this->resolver->resolve($className2);
93
94		$this->assertInstanceOf($className1, $obj1);
95		$this->assertInstanceOf($className2, $obj2);
96
97		$this->assertSame($obj1, $this->resolver->resolve($className1));
98		$this->assertSame($obj2, $this->resolver->resolve($className2));
99
100		$this->resolver->clear($className1);
101
102		$this->assertInstanceOf($className1, $this->resolver->resolve($className1));
103		$this->assertInstanceOf($className2, $this->resolver->resolve($className2));
104
105		$this->assertNotSame($obj1, $this->resolver->resolve($className1));
106		$this->assertSame($obj2, $this->resolver->resolve($className2));
107		}
108
109	View Code Duplication	public function testClearAll()
		0 ignored issues – show Duplication introduced 2016-10-31 14:09 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
110		{
111		$className1 = '\Doctrine\Bundle\DoctrineBundle\Tests\Mapping\EntityListener1';
112		$className2 = '\Doctrine\Bundle\DoctrineBundle\Tests\Mapping\EntityListener2';
113
114		$obj1 = $this->resolver->resolve($className1);
115		$obj2 = $this->resolver->resolve($className2);
116
117		$this->assertInstanceOf($className1, $obj1);
118		$this->assertInstanceOf($className2, $obj2);
119
120		$this->assertSame($obj1, $this->resolver->resolve($className1));
121		$this->assertSame($obj2, $this->resolver->resolve($className2));
122
123		$this->resolver->clear();
124
125		$this->assertInstanceOf($className1, $this->resolver->resolve($className1));
126		$this->assertInstanceOf($className2, $this->resolver->resolve($className2));
127
128		$this->assertNotSame($obj1, $this->resolver->resolve($className1));
129		$this->assertNotSame($obj2, $this->resolver->resolve($className2));
130		}
131
132		/**
133		* @expectedException \InvalidArgumentException
134		* @expectedExceptionMessage An object was expected, but got "string".
135		*/
136		public function testRegisterStringException()
137		{
138		$this->resolver->register('CompanyContractListener');
		0 ignored issues – show Documentation introduced 2016-10-31 14:09 UTC by Report Bug Copy Issue Report `'CompanyContractListener'` is of type `string`, but the function expects a `object`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
139		}
140		}
141
142		class EntityListener1
143		{
144		}
145
146		class EntityListener2
147		{
148		}
149

doctrine / DoctrineBundle

Pull Request — master (#951)

ContainerEntityListenerResolverTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like