ContainerRepositoryFactoryTest::createEntityManager() - Code Metrics - Inspection of "Merge pull request #727 from weaverryan/service_re..." - doctrine/DoctrineBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dba66b...b8eb92 )

by Fabien

created 2017-11-05 19:38 UTC

createEntityManager() A

↳ Parent: ContainerRepositoryFactoryTest

Complexity

Conditions	2
Paths	2

Size

Total Lines	23
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	23
rs	9.0856
c	0
b	0
f	0
cc	2
eloc	15
nc	2
nop	1

<?php

namespace Doctrine\Bundle\DoctrineBundle\Tests\Repository;

use Doctrine\Bundle\DoctrineBundle\Repository\ContainerRepositoryFactory;
use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepositoryInterface;
use Doctrine\ORM\Configuration;
use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\EntityRepository;
use Doctrine\ORM\Mapping\ClassMetadata;
use PHPUnit\Framework\TestCase;
use Psr\Container\ContainerInterface;

class ContainerRepositoryFactoryTest extends TestCase
{
    public function testGetRepositoryReturnsService()

    {
        if (!interface_exists(ContainerInterface::class)) {
            $this->markTestSkipped('Symfony 3.3 is needed for this feature.');
        }

        $em = $this->createEntityManager([
            'Foo\CoolEntity' => 'my_repo',
        ]);
        $repo = new StubRepository($em, new ClassMetadata(''));
        $container = $this->createContainer([
            'my_repo' => $repo,
        ]);

        $factory = new ContainerRepositoryFactory($container);
        $this->assertSame($repo, $factory->getRepository($em, 'Foo\CoolEntity'));
    }

    public function testGetRepositoryReturnsEntityRepository()

    {
        if (!interface_exists(ContainerInterface::class)) {
            $this->markTestSkipped('Symfony 3.3 is needed for this feature.');
        }

        $container = $this->createContainer([]);
        $em = $this->createEntityManager([
            'Foo\BoringEntity' => null,
        ]);

        $factory = new ContainerRepositoryFactory($container);
        $actualRepo = $factory->getRepository($em, 'Foo\BoringEntity');
        $this->assertInstanceOf(EntityRepository::class, $actualRepo);
        // test the same instance is returned
        $this->assertSame($actualRepo, $factory->getRepository($em, 'Foo\BoringEntity'));
    }

    public function testCustomRepositoryIsReturned()

    {
        if (!interface_exists(ContainerInterface::class)) {
            $this->markTestSkipped('Symfony 3.3 is needed for this feature.');
        }

        $container = $this->createContainer([]);
        $em = $this->createEntityManager([
            'Foo\CustomNormalRepoEntity' => StubRepository::class,
        ]);

        $factory = new ContainerRepositoryFactory($container);
        $actualRepo = $factory->getRepository($em, 'Foo\CustomNormalRepoEntity');
        $this->assertInstanceOf(StubRepository::class, $actualRepo);
        // test the same instance is returned
        $this->assertSame($actualRepo, $factory->getRepository($em, 'Foo\CustomNormalRepoEntity'));
    }

    /**
     * @expectedException \RuntimeException
     * @expectedExceptionMessage The service "my_repo" must extend EntityRepository (or a base class, like ServiceEntityRepository).
     */
    public function testServiceRepositoriesMustExtendEntityRepository()

    {
        if (!interface_exists(ContainerInterface::class)) {
            $this->markTestSkipped('Symfony 3.3 is needed for this feature.');
        }

        $repo = new \stdClass();

        $container = $this->createContainer([
            'my_repo' => $repo,
        ]);

        $em = $this->createEntityManager([
            'Foo\CoolEntity' => 'my_repo',
        ]);

        $factory = new ContainerRepositoryFactory($container);
        $factory->getRepository($em, 'Foo\CoolEntity');
    }

    /**
     * @expectedException \RuntimeException
     * @expectedExceptionMessage The "Doctrine\Bundle\DoctrineBundle\Tests\Repository\StubServiceRepository" entity repository implements "Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepositoryInterface", but its service could not be found. Make sure the service exists and is tagged with "doctrine.repository_service".
     */
    public function testRepositoryMatchesServiceInterfaceButServiceNotFound()

    {
        if (!interface_exists(ContainerInterface::class)) {
            $this->markTestSkipped('Symfony 3.3 is needed for this feature.');
        }

        $container = $this->createContainer([]);

        $em = $this->createEntityManager([
            'Foo\CoolEntity' => StubServiceRepository::class,
        ]);

        $factory = new ContainerRepositoryFactory($container);
        $factory->getRepository($em, 'Foo\CoolEntity');
    }

    /**
     * @expectedException \RuntimeException
     * @expectedExceptionMessage The "Foo\CoolEntity" entity has a repositoryClass set to "not_a_real_class", but this is not a valid class. Check your class naming. If this is meant to be a service id, make sure this service exists and is tagged with "doctrine.repository_service".
     */
    public function testCustomRepositoryIsNotAValidClass()

    {
        if (interface_exists(ContainerInterface::class)) {
            $container = $this->createContainer([]);
        } else {
            // Symfony 3.2 and lower support
            $container = null;
        }

        $em = $this->createEntityManager([
            'Foo\CoolEntity' => 'not_a_real_class',
        ]);

        $factory = new ContainerRepositoryFactory($container);
        $factory->getRepository($em, 'Foo\CoolEntity');
    }

    private function createContainer(array $services)

    {
        $container = $this->getMockBuilder(ContainerInterface::class)->getMock();
        $container->expects($this->any())
            ->method('has')
            ->willReturnCallback(function ($id) use ($services) {
                return isset($services[$id]);
            });
        $container->expects($this->any())
            ->method('get')
            ->willReturnCallback(function ($id) use ($services) {
                return $services[$id];
            });

        return $container;
    }

    private function createEntityManager(array $entityRepositoryClasses)

    {
        $classMetadatas = [];
        foreach ($entityRepositoryClasses as $entityClass => $entityRepositoryClass) {
            $metadata = new ClassMetadata($entityClass);
            $metadata->customRepositoryClassName = $entityRepositoryClass;

            $classMetadatas[$entityClass] = $metadata;
        }

        $em = $this->getMockBuilder(EntityManagerInterface::class)->getMock();
        $em->expects($this->any())
            ->method('getClassMetadata')
            ->willReturnCallback(function ($class) use ($classMetadatas) {
                return $classMetadatas[$class];
            });

        $em->expects($this->any())
            ->method('getConfiguration')
            ->willReturn(new Configuration());

        return $em;
    }
}

class StubRepository extends EntityRepository

{
}

class StubServiceRepository extends EntityRepository implements ServiceEntityRepositoryInterface

{
}


1		<?php
2
3		namespace Doctrine\Bundle\DoctrineBundle\Tests\Repository;
4
5		use Doctrine\Bundle\DoctrineBundle\Repository\ContainerRepositoryFactory;
6		use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepositoryInterface;
7		use Doctrine\ORM\Configuration;
8		use Doctrine\ORM\EntityManagerInterface;
9		use Doctrine\ORM\EntityRepository;
10		use Doctrine\ORM\Mapping\ClassMetadata;
11		use PHPUnit\Framework\TestCase;
12		use Psr\Container\ContainerInterface;
13
14		class ContainerRepositoryFactoryTest extends TestCase
15		{
16	View Code Duplication	public function testGetRepositoryReturnsService()
		0 ignored issues – show Duplication introduced 2017-10-31 14:58 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
17		{
18		if (!interface_exists(ContainerInterface::class)) {
19		$this->markTestSkipped('Symfony 3.3 is needed for this feature.');
20		}
21
22		$em = $this->createEntityManager([
23		'Foo\CoolEntity' => 'my_repo',
24		]);
25		$repo = new StubRepository($em, new ClassMetadata(''));
26		$container = $this->createContainer([
27		'my_repo' => $repo,
28		]);
29
30		$factory = new ContainerRepositoryFactory($container);
31		$this->assertSame($repo, $factory->getRepository($em, 'Foo\CoolEntity'));
32		}
33
34	View Code Duplication	public function testGetRepositoryReturnsEntityRepository()
		0 ignored issues – show Duplication introduced 2017-10-31 14:36 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
35		{
36		if (!interface_exists(ContainerInterface::class)) {
37		$this->markTestSkipped('Symfony 3.3 is needed for this feature.');
38		}
39
40		$container = $this->createContainer([]);
41		$em = $this->createEntityManager([
42		'Foo\BoringEntity' => null,
43		]);
44
45		$factory = new ContainerRepositoryFactory($container);
46		$actualRepo = $factory->getRepository($em, 'Foo\BoringEntity');
47		$this->assertInstanceOf(EntityRepository::class, $actualRepo);
48		// test the same instance is returned
49		$this->assertSame($actualRepo, $factory->getRepository($em, 'Foo\BoringEntity'));
50		}
51
52	View Code Duplication	public function testCustomRepositoryIsReturned()
		0 ignored issues – show Duplication introduced 2017-10-31 14:36 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
53		{
54		if (!interface_exists(ContainerInterface::class)) {
55		$this->markTestSkipped('Symfony 3.3 is needed for this feature.');
56		}
57
58		$container = $this->createContainer([]);
59		$em = $this->createEntityManager([
60		'Foo\CustomNormalRepoEntity' => StubRepository::class,
61		]);
62
63		$factory = new ContainerRepositoryFactory($container);
64		$actualRepo = $factory->getRepository($em, 'Foo\CustomNormalRepoEntity');
65		$this->assertInstanceOf(StubRepository::class, $actualRepo);
66		// test the same instance is returned
67		$this->assertSame($actualRepo, $factory->getRepository($em, 'Foo\CustomNormalRepoEntity'));
68		}
69
70		/**
71		* @expectedException \RuntimeException
72		* @expectedExceptionMessage The service "my_repo" must extend EntityRepository (or a base class, like ServiceEntityRepository).
73		*/
74	View Code Duplication	public function testServiceRepositoriesMustExtendEntityRepository()
		0 ignored issues – show Duplication introduced 2017-10-29 01:24 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
75		{
76		if (!interface_exists(ContainerInterface::class)) {
77		$this->markTestSkipped('Symfony 3.3 is needed for this feature.');
78		}
79
80		$repo = new \stdClass();
81
82		$container = $this->createContainer([
83		'my_repo' => $repo,
84		]);
85
86		$em = $this->createEntityManager([
87		'Foo\CoolEntity' => 'my_repo',
88		]);
89
90		$factory = new ContainerRepositoryFactory($container);
91		$factory->getRepository($em, 'Foo\CoolEntity');
92		}
93
94		/**
95		* @expectedException \RuntimeException
96		* @expectedExceptionMessage The "Doctrine\Bundle\DoctrineBundle\Tests\Repository\StubServiceRepository" entity repository implements "Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepositoryInterface", but its service could not be found. Make sure the service exists and is tagged with "doctrine.repository_service".
97		*/
98	View Code Duplication	public function testRepositoryMatchesServiceInterfaceButServiceNotFound()
		0 ignored issues – show Duplication introduced 2017-10-31 14:36 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
99		{
100		if (!interface_exists(ContainerInterface::class)) {
101		$this->markTestSkipped('Symfony 3.3 is needed for this feature.');
102		}
103
104		$container = $this->createContainer([]);
105
106		$em = $this->createEntityManager([
107		'Foo\CoolEntity' => StubServiceRepository::class,
108		]);
109
110		$factory = new ContainerRepositoryFactory($container);
111		$factory->getRepository($em, 'Foo\CoolEntity');
112		}
113
114		/**
115		* @expectedException \RuntimeException
116		* @expectedExceptionMessage The "Foo\CoolEntity" entity has a repositoryClass set to "not_a_real_class", but this is not a valid class. Check your class naming. If this is meant to be a service id, make sure this service exists and is tagged with "doctrine.repository_service".
117		*/
118	View Code Duplication	public function testCustomRepositoryIsNotAValidClass()
		0 ignored issues – show Duplication introduced 2017-10-31 14:36 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
119		{
120		if (interface_exists(ContainerInterface::class)) {
121		$container = $this->createContainer([]);
122		} else {
123		// Symfony 3.2 and lower support
124		$container = null;
125		}
126
127		$em = $this->createEntityManager([
128		'Foo\CoolEntity' => 'not_a_real_class',
129		]);
130
131		$factory = new ContainerRepositoryFactory($container);
132		$factory->getRepository($em, 'Foo\CoolEntity');
133		}
134
135		private function createContainer(array $services)
		0 ignored issues – show Documentation introduced 2017-10-29 01:24 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
136		{
137		$container = $this->getMockBuilder(ContainerInterface::class)->getMock();
138		$container->expects($this->any())
139		->method('has')
140		->willReturnCallback(function ($id) use ($services) {
141		return isset($services[$id]);
142		});
143		$container->expects($this->any())
144		->method('get')
145		->willReturnCallback(function ($id) use ($services) {
146		return $services[$id];
147		});
148
149		return $container;
150		}
151
152		private function createEntityManager(array $entityRepositoryClasses)
		0 ignored issues – show Documentation introduced 2017-10-29 01:24 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
153		{
154		$classMetadatas = [];
155		foreach ($entityRepositoryClasses as $entityClass => $entityRepositoryClass) {
156		$metadata = new ClassMetadata($entityClass);
157		$metadata->customRepositoryClassName = $entityRepositoryClass;
158
159		$classMetadatas[$entityClass] = $metadata;
160		}
161
162		$em = $this->getMockBuilder(EntityManagerInterface::class)->getMock();
163		$em->expects($this->any())
164		->method('getClassMetadata')
165		->willReturnCallback(function ($class) use ($classMetadatas) {
166		return $classMetadatas[$class];
167		});
168
169		$em->expects($this->any())
170		->method('getConfiguration')
171		->willReturn(new Configuration());
172
173		return $em;
174		}
175		}
176
177		class StubRepository extends EntityRepository
		0 ignored issues – show Coding Style Compatibility introduced 2017-10-29 01:24 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history...
178		{
179		}
180
181		class StubServiceRepository extends EntityRepository implements ServiceEntityRepositoryInterface
		0 ignored issues – show Coding Style Compatibility introduced 2017-10-31 14:36 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history...
182		{
183		}
184

doctrine / DoctrineBundle

Push — master ( dba66b...b8eb92 )

createEntityManager() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like