ElementalArea

Complexity

Total Complexity

11

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	14
Bugs	6	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
B	Elements()	0	24	2
A	ItemsToRender()	0	3	1
C	getOwnerPage()	0	25	8

<?php

/**
 * @package elemental
 */
class ElementalArea extends WidgetArea

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public function Elements()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $result = $this->getComponents('Widgets');

        if ($result instanceof UnsavedRelationList) {
            // Setup a proper UnsavedRelationList so that an page using this extension can be created 
            // programmatically and have unsaved/saved BaseElement records attached to it.
            
            // NOTE(SilbinaryWolf): Able to set protected var 'dataClass' due to ViewableData using magic get/set for properties
            $result->dataClass = 'BaseElement'; // Change from 'Widget' to 'BaseElement'
            return $result;
        }

        $list = new HasManyList('BaseElement', $result->getForeignKey());
        $list->setDataModel($this->model);
        $list->sort('Sort ASC');

        $list = $list->forForeignID($this->ID);
        $list = $list->filter(array(
            'Enabled' => 1
        ));

        return $list;
    }

    /**
     * @return HasManyList
     */
    public function ItemsToRender() {
        return $this->Elements();
    }

    /**
    * Return an ArrayList of pages with the Element Page Extension
    *
    * @return ArrayList
    */
    public function getOwnerPage()
    {
        foreach (get_declared_classes() as $class) {
            if (is_subclass_of($class, 'SiteTree')) {
                $object = singleton($class);
                $classes = ClassInfo::subclassesFor('ElementPageExtension');
                $isElemental = false;

                foreach ($classes as $extension) {

The expression $classes of type null|array is not guaranteed to be traversable. How about adding an additional type check?

                    if ($object->hasExtension($extension)) {
                        $isElemental = true;
                    }
                }

                if ($isElemental) {
                    $page = $class::get()->filter('ElementAreaID', $this->ID);
                    if ($page && $page->exists()) {
                        return $page->first();
                    }
                }
            }
        }

        return false;
    }
}