ElementList

Complexity

Total Complexity

6

Size/Duplication

Total Lines	101
Duplicated Lines	10.89 %

Coupling/Cohesion

Components	1
Dependencies	12

Importance

Changes	1
Bugs	1	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getCMSFields()	11	55	4
A	WidgetControllers()	0	12	2

<?php

/**
 * A list contains nested {@link BaseElement} such as a list of related files.
 *
 * @package elemental
 */
class ElementList extends BaseElement

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    private static $db = array(

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        'ListDescription' => 'HTMLText'
    );

    private static $has_many = array(

Consider using a different property name as you override a private property of the parent class.

The property $has_many is not used and could be removed.

        'Elements' => 'BaseElement'
    );

    private static $duplicate_relations = array(

The property $duplicate_relations is not used and could be removed.

        'Elements'
    );

    private static $extensions = array(

Consider using a different property name as you override a private property of the parent class.

The property $extensions is not used and could be removed.

        'ElementPublishChildren'
    );

    private static $title = "Element List Element";

Consider using a different property name as you override a private property of the parent class.

The property $title is not used and could be removed.

    private static $description = "Orderable list of elements";

Consider using a different property name as you override a private property of the parent class.

The property $description is not used and could be removed.

    protected $enable_title_in_template = true;

    public function getCMSFields()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $elements = $this->Elements();

The method Elements does not exist on object<ElementList>? Since you implemented __call, maybe consider adding a @method annotation.

        $isInDb = $this->isInDB();
        $allowed = $this->config()->get('allowed_elements');

        $this->beforeUpdateCMSFields(function ($fields) use ($elements, $isInDb, $allowed) {
            $desc = HTMLEditorField::create('ListDescription', 'List Description');
            $desc->setRightTitle('Optional');
            $fields->addFieldToTab('Root.Main', $desc);

            if ($isInDb) {
                $adder = new GridFieldAddNewMultiClass();

                if (is_array($allowed)) {

This code seems to be duplicated across your project.

                    $list = $allowed;
                } else {
                    $classes = ClassInfo::subclassesFor('BaseElement');
                    $list = array();
                    unset($classes['BaseElement']);

                    foreach ($classes as $class) {

The expression $classes of type null|array is not guaranteed to be traversable. How about adding an additional type check?

                        $list[$class] = singleton($class)->i18n_singular_name();
                    }
                }

                asort($list);

                $adder->setClasses($list);

                $config = GridFieldConfig_RecordEditor::create(100);
                $config->addComponent(new GridFieldSortableRows('Sort'));
                $config->removeComponentsByType('GridFieldAddNewButton');
                $config->addComponent($adder);

                $config->removeComponentsByType('GridFieldDetailForm');
                $config->addComponent(new VersionedDataObjectDetailsForm());

                $widgetArea = new GridField(
                    'Elements',
                    Config::inst()->get("ElementPageExtension", 'elements_title'),
                    $elements,
                    $config
                );

                $fields->addFieldToTab('Root.Main', $widgetArea);
            } else {
                $fields->addFieldToTab('Root.Main', LiteralField::create('warn', '<p class="message notice">Once you save this object you will be able to add items</p>'));
            }

            $fields->removeByName('Root.Elements');
        });

        return parent::getCMSFields();
    }

    /**
     * Used in template instead of {@link Widgets()} to wrap each widget in its
     * controller, making it easier to access and process form logic and
     * actions stored in {@link WidgetController}.
     *
     * @return SS_List - Collection of {@link WidgetController} instances.
     */
    public function WidgetControllers() {
        $controllers = new ArrayList();

        foreach($this->Elements()->filter('Enabled', 1) as $widget) {

The method Elements does not exist on object<ElementList>? Since you implemented __call, maybe consider adding a @method annotation.

            $controller = $widget->getController();

            $controller->init();
            $controllers->push($controller);
        }

        return $controllers;
    }
}