ElementVirtualLinked_Controller::hasAction() - Code Metrics - Inspection of "Virtual updates" - dnadesign/silverstripe-elemental - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#54)

by John

created 2016-10-02 22:10 UTC

ElementVirtualLinked_Controller::hasAction() A

↳ Parent: ElementVirtualLinked_Controller

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	5

Duplication

Lines	8
Ratio	100 %

Importance

Changes

Metric	Value
dl	8
loc	8
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	1

<?php

/**
 * Virtual Linked Element.
 *
 * As elemental is based on widgets which have a natural has_one relation to an
 * object, this is a workaround for allowing the same element to be linked to
 * multiple pages.
 *
 * {@see ElementalGridFieldAddExistingAutocompleter}
 *
 * @package elemental
 */
class ElementVirtualLinked extends BaseElement {
namespace YourVendor;

class YourClass { }
    /**
     * @var string
     */
    private static $title = 'Virtual linked Block';


    /**
     * @var string
     */
    private static $singular_name = 'Virtual linked Block';


    private static $has_one = array(

        'LinkedElement' => 'BaseElement'
    );

    public function getTitle()

    {
        return $this->LinkedElement()->getTitle();

    }

    public function i18n_singular_name()
    {
        return _t(__CLASS__, $this->LinkedElement()->config()->title);

    }

    public function __construct($record = null, $isSingleton = false, $model = null) {
        parent::__construct($record, $isSingleton, $model);
        $this->LinkedElement()->setVirtualOwner($this);

    }

    public function getCMSFields() {

        $message = sprintf('<p>%s</p><p><a href="%2$s">%2$s</a></p>',
             _t('ElementVirtualLinked.DESCRIBE', 'This is a virtual copy of a block. To edit, visit'),
             $this->LinkedElement()->getEditLink()

        );

        $fields = new FieldList(
            new TabSet('Root', $main = new Tab('Main'))
        );

        $main->push(
            new LiteralField('Existing', $message)
        );

        $this->extend('updateCMSFields', $fields);

        return $fields;
    }

}

class ElementVirtualLinked_Controller extends BaseElement_Controller {
namespace YourVendor;

class YourClass { }

    protected $controllerClass;

    public function __construct($widget) {
        parent::__construct($widget);

        $controllerClass = get_class($this->LinkedElement()) . '_Controller';
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        if(class_exists($controllerClass)) {
            $this->controllerClass = $controllerClass;
        } else {
            $this->controllerClass = 'BaseElement_Controller';
        }
    }

    /**
     * Returns the current widget in scope rendered into its' holder
     *
     * @return HTML

     */
    public function WidgetHolder()
    {
        return $this->renderWith("ElementHolder_VirtualLinked");
    }

    public function __call($method, $arguments) {
        try {
           $retVal = parent::__call($method, $arguments);

        } catch (Exception $e) {
            $controller = new $this->controllerClass($this->LinkedElement());
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $retVal = call_user_func_array(array($controller, $method), $arguments);
        }
        return $retVal;
    }

    public function hasMethod($action) {

        if(parent::hasMethod($action)) {
            return true;
        }

        $controller = new $this->controllerClass($this->LinkedElement());
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        return $controller->hasMethod($action);
    }

    public function hasAction($action) {

        if(parent::hasAction($action)) {
            return true;
        }

        $controller = new $this->controllerClass($this->LinkedElement());
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        return $controller->hasAction($action);
    }

    public function checkAccessAction($action) {

        if(parent::checkAccessAction($action)) {
            return true;
        }

        $controller = new $this->controllerClass($this->LinkedElement());
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        return $controller->checkAccessAction($action);
    }
}


1		<?php
2
3		/**
4		* Virtual Linked Element.
5		*
6		* As elemental is based on widgets which have a natural has_one relation to an
7		* object, this is a workaround for allowing the same element to be linked to
8		* multiple pages.
9		*
10		* {@see ElementalGridFieldAddExistingAutocompleter}
11		*
12		* @package elemental
13		*/
14		class ElementVirtualLinked extends BaseElement {
		0 ignored issues – show Coding Style Compatibility introduced 2016-05-24 00:01 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
15		/**
16		* @var string
17		*/
18		private static $title = 'Virtual linked Block';
		0 ignored issues – show Comprehensibility introduced 2016-09-14 22:51 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-09-14 22:51 UTC by Report Bug Copy Issue Report The property `$title` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
19
20		/**
21		* @var string
22		*/
23		private static $singular_name = 'Virtual linked Block';
		0 ignored issues – show Comprehensibility introduced 2016-09-14 22:51 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-09-14 22:51 UTC by Report Bug Copy Issue Report The property `$singular_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
24
25		private static $has_one = array(
		0 ignored issues – show Comprehensibility introduced 2016-05-24 00:01 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-05-24 00:01 UTC by Report Bug Copy Issue Report The property `$has_one` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
26		'LinkedElement' => 'BaseElement'
27		);
28
29		public function getTitle()
		0 ignored issues – show Documentation introduced 2016-05-24 00:01 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
30		{
31		return $this->LinkedElement()->getTitle();
		0 ignored issues – show Bug introduced 2016-10-02 22:12 UTC by Report Bug Copy Issue Report The method `LinkedElement()` does not exist on `ElementVirtualLinked`. Did you maybe mean `getVirtualLinkedElements()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
32		}
33
34		public function i18n_singular_name()
35		{
36		return _t(__CLASS__, $this->LinkedElement()->config()->title);
		0 ignored issues – show Bug introduced 2016-10-02 22:12 UTC by Report Bug Copy Issue Report The method `LinkedElement()` does not exist on `ElementVirtualLinked`. Did you maybe mean `getVirtualLinkedElements()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
37		}
38
39		public function __construct($record = null, $isSingleton = false, $model = null) {
40		parent::__construct($record, $isSingleton, $model);
41		$this->LinkedElement()->setVirtualOwner($this);
		0 ignored issues – show Bug introduced 2016-10-02 22:12 UTC by Report Bug Copy Issue Report The method `LinkedElement()` does not exist on `ElementVirtualLinked`. Did you maybe mean `getVirtualLinkedElements()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
42		}
43
44		public function getCMSFields() {
		0 ignored issues – show Documentation introduced 2016-05-24 00:01 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
45		$message = sprintf('<p>%s</p><p><a href="%2$s">%2$s</a></p>',
46		_t('ElementVirtualLinked.DESCRIBE', 'This is a virtual copy of a block. To edit, visit'),
47		$this->LinkedElement()->getEditLink()
		0 ignored issues – show Bug introduced 2016-10-02 22:12 UTC by Report Bug Copy Issue Report The method `LinkedElement()` does not exist on `ElementVirtualLinked`. Did you maybe mean `getVirtualLinkedElements()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
48		);
49
50		$fields = new FieldList(
51		new TabSet('Root', $main = new Tab('Main'))
52		);
53
54		$main->push(
55		new LiteralField('Existing', $message)
56		);
57
58		$this->extend('updateCMSFields', $fields);
59
60		return $fields;
61		}
62
63		}
64
65		class ElementVirtualLinked_Controller extends BaseElement_Controller {
		0 ignored issues – show Coding Style Compatibility introduced 2016-10-02 22:12 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history... Coding Style Compatibility introduced 2016-10-02 22:12 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
66
67		protected $controllerClass;
68
69		public function __construct($widget) {
70		parent::__construct($widget);
71
72		$controllerClass = get_class($this->LinkedElement()) . '_Controller';
		0 ignored issues – show Documentation Bug introduced 2016-10-02 22:12 UTC by Report Bug Copy Issue Report The method `LinkedElement` does not exist on `object<ElementVirtualLinked_Controller>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
73		if(class_exists($controllerClass)) {
74		$this->controllerClass = $controllerClass;
75		} else {
76		$this->controllerClass = 'BaseElement_Controller';
77		}
78		}
79
80		/**
81		* Returns the current widget in scope rendered into its' holder
82		*
83		* @return HTML
		0 ignored issues – show Documentation introduced 2016-10-02 22:12 UTC by Report Bug Copy Issue Report Should the return type not be `HTMLText`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
84		*/
85		public function WidgetHolder()
86		{
87		return $this->renderWith("ElementHolder_VirtualLinked");
88		}
89
90		public function __call($method, $arguments) {
91		try {
92		$retVal = parent::__call($method, $arguments);
93
94		} catch (Exception $e) {
95		$controller = new $this->controllerClass($this->LinkedElement());
		0 ignored issues – show Documentation Bug introduced 2016-10-02 22:12 UTC by Report Bug Copy Issue Report The method `LinkedElement` does not exist on `object<ElementVirtualLinked_Controller>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
96		$retVal = call_user_func_array(array($controller, $method), $arguments);
97		}
98		return $retVal;
99		}
100
101	View Code Duplication	public function hasMethod($action) {
		0 ignored issues – show Documentation introduced 2016-10-02 22:12 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history... Duplication introduced 2016-10-02 22:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
102		if(parent::hasMethod($action)) {
103		return true;
104		}
105
106		$controller = new $this->controllerClass($this->LinkedElement());
		0 ignored issues – show Documentation Bug introduced 2016-10-02 22:12 UTC by Report Bug Copy Issue Report The method `LinkedElement` does not exist on `object<ElementVirtualLinked_Controller>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
107		return $controller->hasMethod($action);
108		}
109
110	View Code Duplication	public function hasAction($action) {
		0 ignored issues – show Documentation introduced 2016-10-02 22:12 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history... Duplication introduced 2016-10-02 22:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
111		if(parent::hasAction($action)) {
112		return true;
113		}
114
115		$controller = new $this->controllerClass($this->LinkedElement());
		0 ignored issues – show Documentation Bug introduced 2016-10-02 22:12 UTC by Report Bug Copy Issue Report The method `LinkedElement` does not exist on `object<ElementVirtualLinked_Controller>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
116		return $controller->hasAction($action);
117		}
118
119	View Code Duplication	public function checkAccessAction($action) {
		0 ignored issues – show Documentation introduced 2016-10-02 22:12 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history... Duplication introduced 2016-10-02 22:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
120		if(parent::checkAccessAction($action)) {
121		return true;
122		}
123
124		$controller = new $this->controllerClass($this->LinkedElement());
		0 ignored issues – show Documentation Bug introduced 2016-10-02 22:12 UTC by Report Bug Copy Issue Report The method `LinkedElement` does not exist on `object<ElementVirtualLinked_Controller>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
125		return $controller->checkAccessAction($action);
126		}
127		}
128

dnadesign / silverstripe-elemental

Pull Request — master (#54)

ElementVirtualLinked_Controller::hasAction() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like