BaseElement_Controller - Code Metrics - Inspection of "Virtual updates" - dnadesign/silverstripe-elemental - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#54)

by John

created 2016-10-02 22:10 UTC

BaseElement_Controller A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
wmc	6
lcom	0
cbo	1
dl	0
loc	40
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	WidgetHolder()	4	1
A	Link()	10	2
A	redirect()	11	3

<?php

/**
 * Each {@link BaseElement} is wrapped inside a controller in order to provide
 * form submission handling and {@link Link()} method support.
 *
 * @package elemental
 */
class BaseElement_Controller extends WidgetController
namespace YourVendor;

class YourClass { }
{
    /**
     * Returns the current widget in scope rendered into its' holder
     *
     * @return HTML

     */
    public function WidgetHolder()
    {
        return $this->renderWith("ElementHolder");
    }


    public function Link($action = null)

    {

        if($this->data()->virtualOwner) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
          $controller = new BaseElement_Controller($this->data()->virtualOwner);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
          return $controller->Link($action);
        }

        return Parent::Link($action);
    }


    /**
     * if this is a virtual request, change the hash if set.
     */
    public function redirect($url, $code=302) {

      if($this->data()->virtualOwner) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $parts = explode('#', $url);
        if(isset($parts[1])) {
          $url = $parts[0] . '#' . $this->data()->virtualOwner->ID;
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        }
      }

      return parent::redirect($url, $code);
    }
}


1			<?php
2
3			/**
4			* Each {@link BaseElement} is wrapped inside a controller in order to provide
5			* form submission handling and {@link Link()} method support.
6			*
7			* @package elemental
8			*/
9			class BaseElement_Controller extends WidgetController
			0 ignored issues – show Coding Style Compatibility introduced 2016-02-17 03:25 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
10			{
11			/**
12			* Returns the current widget in scope rendered into its' holder
13			*
14			* @return HTML
			0 ignored issues – show Documentation introduced 2016-02-17 03:25 UTC by Report Bug Copy Issue Report Should the return type not be `HTMLText`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
15			*/
16			public function WidgetHolder()
17			{
18			return $this->renderWith("ElementHolder");
19			}
20
21
22			public function Link($action = null)
			0 ignored issues – show Documentation introduced 2016-10-02 22:12 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
23			{
24
25			if($this->data()->virtualOwner) {
			0 ignored issues – show Documentation Bug introduced 2016-10-02 22:12 UTC by Report Bug Copy Issue Report The method `data` does not exist on `object<BaseElement_Controller>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
26			$controller = new BaseElement_Controller($this->data()->virtualOwner);
			0 ignored issues – show Documentation Bug introduced 2016-10-02 22:12 UTC by Report Bug Copy Issue Report The method `data` does not exist on `object<BaseElement_Controller>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
27			return $controller->Link($action);
28			}
29
30			return Parent::Link($action);
31			}
32
33
34			/**
35			* if this is a virtual request, change the hash if set.
36			*/
37			public function redirect($url, $code=302) {
38
39			if($this->data()->virtualOwner) {
			0 ignored issues – show Documentation Bug introduced 2016-10-02 22:12 UTC by Report Bug Copy Issue Report The method `data` does not exist on `object<BaseElement_Controller>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
40			$parts = explode('#', $url);
41			if(isset($parts[1])) {
42			$url = $parts[0] . '#' . $this->data()->virtualOwner->ID;
			0 ignored issues – show Documentation Bug introduced 2016-10-02 22:12 UTC by Report Bug Copy Issue Report The method `data` does not exist on `object<BaseElement_Controller>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
43			}
44			}
45
46			return parent::redirect($url, $code);
47			}
48			}
49

dnadesign / silverstripe-elemental

Pull Request — master (#54)

BaseElement_Controller A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like