View GitHub Repository silverstripe-elemental

Schedule Inspection
Subscribe
Completed
Pull Request — master (#71)
by John
02:15
created

ElementalGridFieldDeleteAction::getColumnContent()   A

↳ Parent: ElementalGridFieldDeleteAction

Complexity

Conditions 4
Paths 3

Size

Total Lines 18
Code Lines 13

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
dl 0
loc 18
rs 9.2
c 0
b 0
f 0
cc 4
eloc 13
nc 3
nop 3
1 
<?php
2 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    3
                

                                    
                                                    
                
                
                
/**

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                
 * @package elemental

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                
 */

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    6
                

                                    
                                                    
                
                
                
class ElementalGridFieldDeleteAction extends GridFieldDeleteAction {

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Coding Style
            Compatibility
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.
                                            

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
You can fix this by adding a namespace to your class:


namespace YourVendor;

class YourClass { }





When choosing a vendor namespace, try to pick something that is not too generic
to avoid conflicts with other libraries.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                                                                            
                                                                
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
    public function getColumnContent($gridField, $record, $columnName) {

            


            
                                                        
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
        if(!$record->canEdit()) return;

            


            
                                                        
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
        if($record->canDelete() && $record->VirtualClones()->count() == 0) {

            


            
                                                        
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
            $field = GridField_FormAction::create($gridField,

            


            
                                                        
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
                    'DeleteRecord'.$record->ID,

            


            
                                                        
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
                    false,

            


            
                                                        
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
                    'deleterecord',

            


            
                                                        
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
                    array('RecordID' => $record->ID)

            


            
                                                        
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                
                )

            


            
                                                        
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
                ->addExtraClass('gridfield-button-delete')

            


            
                                                        
            
                                    
            
            

                
                    19
                

                                    
                                                    
                
                
                
                ->setAttribute('title', _t('GridAction.Delete', 'Delete'))

            


            
                                                        
            
                                    
            
            

                
                    20
                

                                    
                                                    
                
                
                
                ->setAttribute('data-icon', 'cross-circle')

            


            
                                                        
            
                                    
            
            

                
                    21
                

                                    
                                                    
                
                
                
                ->setDescription(_t('GridAction.DELETE_DESCRIPTION','Delete'));

            


            
                                                        
            
                                    
            
            

                
                    22
                

                                    
                                                    
                
                
                
        }

            


            
                                                        
            
                                    
            
            

                
                    23
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    24
                

                                    
                                                    
                
                
                
        return $field->Field();

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
The variable $field does not seem to be defined for all execution paths leading up to this point.
                                                                                                

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
If you define a variable conditionally, it can happen that it is not defined
for all execution paths.


Let’s take a look at an example:


function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}





In the above example, the variable $x is defined if you pass “foo” or “bar”
as argument for $a. However, since the switch statement has no default
case statement, if you pass any other value, the variable $x would be undefined.




Available Fixes


  1. Check for existence of the variable explicitly:
    

    function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    if (isset($x)) { // Make sure it's always set.
        echo $x;
    }
}

    

    

    2. 

  2. Define a default value for the variable:
    

    function myFunction($a) {
    $x = ''; // Set a default which gets overridden for certain paths.
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    echo $x;
}

    

    

    3. 

  3. Add a value for the missing path:
    

    function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;

        // We add support for the missing case.
        default:
            $x = '';
            break;
    }

    echo $x;
}

    

    

    4. 



                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    25
                

                                    
                                                    
                
                
                
    }

            


            
                                                        
            
                                    
            
            

                
                    26
                

                                    
                                                    
                
                
                
}

            


            
                                                        
            
                                    
            
            

                
                    27