DNADesign\Elemental\Services\ReorderElements::reorder()

Complexity

Conditions	5
Paths	6

Size

Total Lines	55
Code Lines	32

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function reorder($elementToBeAfterID = 0)
    {
        $element = $this->element;
        $parentId = $element->ParentID;

The property ParentID does not exist on DNADesign\Elemental\Models\BaseElement. Since you implemented __get, consider adding a @property annotation.

        $currentPosition = (int) $element->Sort;
        $sortAfterPosition = 0;

        if ($elementToBeAfterID) {
            /** @var BaseElement $afterBlock */
            $afterElement = BaseElement::get()->byID($elementToBeAfterID);

            if (!$afterElement) {

$afterElement is of type SilverStripe\ORM\DataObject, thus it always evaluated to true.

                throw new InvalidArgumentException(sprintf(
                    '%s#%s not found',
                    BaseElement::class,
                    $elementToBeAfterID
                ));
            }

            // Must be weak comparison as sometimes integers are returned from the DB as strings
            if ($afterElement->ParentID != $parentId) {
                throw new InvalidArgumentException(
                    'Trying to sort element to be placed after an element from a different elemental area'
                );
            }

            $sortAfterPosition = (int) $afterElement->Sort;
        }

        // We are updating records with SQL queries to avoid the ORM triggering the creation of new versions
        // for each element that is affected by this reordering.
        $tableName = Convert::raw2sql(DataObject::getSchema()->tableName(BaseElement::class));

        if ($sortAfterPosition < $currentPosition) {
            $operator = '+';
            $filter = "\"$tableName\".\"Sort\" > $sortAfterPosition AND \"$tableName\".\"Sort\" < $currentPosition";
            $newBlockPosition = $sortAfterPosition + 1;
        } else {
            $operator = '-';
            $filter = "\"$tableName\".\"Sort\" <= $sortAfterPosition AND \"$tableName\".\"Sort\" > $currentPosition";
            $newBlockPosition = $sortAfterPosition;
        }

        $query = SQLUpdate::create()
            ->setTable("\"$tableName\"")
            ->assignSQL('"Sort"', "\"$tableName\".\"Sort\" $operator 1")
            ->addWhere([$filter, "\"$tableName\".\"ParentID\"" => $parentId]);

        $query->execute();

        // Now use the ORM to write a new version of the record that we are directly reordering
        $element->Sort = $newBlockPosition;
        $element->write();

        return $element;
    }