Issues in ElementVirtualLinked.php - New Issues - Inspection of "NEW Introduce ElementVirtualLinked to link widgets" - dnadesign/silverstripe-elemental - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 59c799...149ad0 )

by Will

created 2016-05-23 23:59 UTC

code/models/ElementVirtualLinked.php (3 issues)

Showing only issues like (Show All)

undocumented call capabilities.

Bug Documentation Minor

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Virtual Linked Element.
 *
 * As elemental is based on widgets which have a natural has_one relation to an
 * object, this is a workaround for allowing the same element to be linked to
 * multiple pages.
 *
 * {@see ElementalGridFieldAddExistingAutocompleter}
 *
 * @package elemental
 */
class ElementVirtualLinked extends BaseElement {

    private static $has_one = array(
        'LinkedElement' => 'BaseElement'
    );

    public function getTitle()
    {
        return $this->LinkedElement()->getTitle();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    public function i18n_singular_name()
    {
        return _t(__CLASS__, $this->LinkedElement()->config()->title);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    public function getCMSFields() {
        $message = sprintf('<p>%s</p><p><a href="%2$s">%2$s</a></p>',
             _t('ElementVirtualLinked.DESCRIBE', 'This is a virtual copy of a block. To edit, visit'),
             $this->LinkedElement()->getEditLink()
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        );

        $fields = new FieldList(
            new LiteralField('Existing', $message)
        );

        $this->extend('updateCMSFields', $fields);

        return $fields;
    }
}


1			<?php
2
3			/**
4			* Virtual Linked Element.
5			*
6			* As elemental is based on widgets which have a natural has_one relation to an
7			* object, this is a workaround for allowing the same element to be linked to
8			* multiple pages.
9			*
10			* {@see ElementalGridFieldAddExistingAutocompleter}
11			*
12			* @package elemental
13			*/
14			class ElementVirtualLinked extends BaseElement {
15
16			private static $has_one = array(
17			'LinkedElement' => 'BaseElement'
18			);
19
20			public function getTitle()
21			{
22			return $this->LinkedElement()->getTitle();
			0 ignored issues – show Documentation Bug introduced 2016-05-24 00:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `LinkedElement` does not exist on `object<ElementVirtualLinked>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
23			}
24
25			public function i18n_singular_name()
26			{
27			return _t(__CLASS__, $this->LinkedElement()->config()->title);
			0 ignored issues – show Documentation Bug introduced 2016-05-24 00:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `LinkedElement` does not exist on `object<ElementVirtualLinked>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
28			}
29
30			public function getCMSFields() {
31			$message = sprintf('<p>%s</p><p><a href="%2$s">%2$s</a></p>',
32			_t('ElementVirtualLinked.DESCRIBE', 'This is a virtual copy of a block. To edit, visit'),
33			$this->LinkedElement()->getEditLink()
			0 ignored issues – show Documentation Bug introduced 2016-05-24 00:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `LinkedElement` does not exist on `object<ElementVirtualLinked>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
34			);
35
36			$fields = new FieldList(
37			new LiteralField('Existing', $message)
38			);
39
40			$this->extend('updateCMSFields', $fields);
41
42			return $fields;
43			}
44			}
45

dnadesign / silverstripe-elemental

Push — master ( 59c799...149ad0 )

code/models/ElementVirtualLinked.php (3 issues)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like