ElementContent::getCMSFields() - Code Metrics - Inspection of "WIP: API: Add history tab. Migrate content style v..." - dnadesign/silverstripe-elemental - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#123)

by Robbie

created 2017-10-29 21:38 UTC

ElementContent::getCMSFields() A

↳ Parent: Project

Complexity

Conditions	3
Paths	4

Size

Total Lines	23
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	23
rs	9.0856
c	0
b	0
f	0
cc	3
eloc	13
nc	4
nop	0

<?php

namespace DNADesign\Elemental\Models;

use SilverStripe\Forms\HTMLEditor\HtmlEditorField;
use SilverStripe\Forms\DropdownField;
use SilverStripe\ORM\FieldType\DBField;

class ElementContent extends BaseElement
{
    private static $icon = 'dnadesign/silverstripe-elemental:images/content.svg';


    private static $db = [

        'HTML' => 'HTMLText'
    ];

    private static $table_name = 'ElementContent';


    private static $singular_name = 'content block';


    private static $plural_name = 'content blocks';


    /**
     * @return HTMLText
filter:
    dependency_paths: ["lib/*"]
     */
    public function ElementSummary()
    {
        return DBField::create_field('HTMLText', $this->HTML)->Summary(20);

    }

    public function getType()
    {
        return _t(__CLASS__ . '.BlockType', 'Content');
    }
}


1			<?php
2
3			namespace DNADesign\Elemental\Models;
4
5			use SilverStripe\Forms\HTMLEditor\HtmlEditorField;
6			use SilverStripe\Forms\DropdownField;
7			use SilverStripe\ORM\FieldType\DBField;
8
9			class ElementContent extends BaseElement
10			{
11			private static $icon = 'dnadesign/silverstripe-elemental:images/content.svg';
			0 ignored issues – show Unused Code introduced 2017-10-16 20:11 UTC by Report Bug Copy Issue Report The property `$icon` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
12
13			private static $db = [
			0 ignored issues – show Unused Code introduced 2017-10-17 01:34 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
14			'HTML' => 'HTMLText'
15			];
16
17			private static $table_name = 'ElementContent';
			0 ignored issues – show Unused Code introduced 2017-10-16 04:09 UTC by Report Bug Copy Issue Report The property `$table_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
18
19			private static $singular_name = 'content block';
			0 ignored issues – show Unused Code introduced 2017-10-16 20:11 UTC by Report Bug Copy Issue Report The property `$singular_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
20
21			private static $plural_name = 'content blocks';
			0 ignored issues – show Unused Code introduced 2017-10-17 01:34 UTC by Report Bug Copy Issue Report The property `$plural_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
22
23			/**
24			* @return HTMLText
			0 ignored issues – show Bug introduced 2017-10-19 21:32 UTC by Report Bug Copy Issue Report The type `DNADesign\Elemental\Models\HTMLText` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
25			*/
26			public function ElementSummary()
27			{
28			return DBField::create_field('HTMLText', $this->HTML)->Summary(20);
			0 ignored issues – show Bug Best Practice introduced 2017-10-16 04:09 UTC by Report Bug Copy Issue Report The property `HTML` does not exist on `DNADesign\Elemental\Models\ElementContent`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
29			}
30
31			public function getType()
32			{
33			return _t(__CLASS__ . '.BlockType', 'Content');
34			}
35			}
36

dnadesign / silverstripe-elemental

Pull Request — master (#123)

ElementContent::getCMSFields() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like