DNADesign\Elemental\GraphQL\SortBlockMutationCreator::resolve()

Complexity

Conditions	7
Paths	8

Size

Total Lines	70
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function resolve($object, array $args, $context, ResolveInfo $info)
    {
        /** @var BaseElement $block */
        $block = BaseElement::get_by_id($args['ID']);

        if (!$block) {

$block is of type DNADesign\Elemental\Models\BaseElement, thus it always evaluated to true. If $block can have other possible types, add them to src/GraphQL/SortBlockMutationCreator.php:43

            throw new \InvalidArgumentException(sprintf(
                '%s#%s not found',
                BaseElement::class,
                $args['ID']
            ));
        }

        if (!$block->canEdit($context['currentUser'])) {
            throw new \InvalidArgumentException(
                'Changing the sort order of blocks is not allowed'
            );
        }

        $parentId = $block->ParentID;

The property ParentID does not exist on DNADesign\Elemental\Models\BaseElement. Since you implemented __get, consider adding a @property annotation.

        $blockPosition = (int) $block->Sort;

        $sortAfterPosition = 0;
        $afterBlockID = $args['AfterBlockID'];
        if ($afterBlockID) {
            /** @var BaseElement $afterBlock */
            $afterBlock = BaseElement::get_by_id($afterBlockID);

            if (!$afterBlock) {

$afterBlock is of type DNADesign\Elemental\Models\BaseElement, thus it always evaluated to true. If $afterBlock can have other possible types, add them to src/GraphQL/SortBlockMutationCreator.php:66

                throw new \InvalidArgumentException(
                    'Trying to sort block after a block in a different elemental area'
                );
            }
            if ($afterBlock->ParentID !== $parentId) {
                throw new \InvalidArgumentException(sprintf(
                    '%s#%s not found',
                    BaseElement::class,
                    $parentId
                ));
            }

            $sortAfterPosition = (int) $afterBlock->Sort;
        }

        // We are updating records with SQL queries to avoid the ORM triggering the creation of new versions
        // for each element that is affected by this reordering.
        $tableName = Convert::raw2sql(DataObject::getSchema()->tableName(BaseElement::class));

        if ($sortAfterPosition < $blockPosition) {
            $operator = '+';
            $filter = "\"$tableName\".\"Sort\" > $sortAfterPosition AND \"$tableName\".\"Sort\" < $blockPosition";
            $newBlockPosition = $sortAfterPosition + 1;
        } else {
            $operator = '-';
            $filter = "\"$tableName\".\"Sort\" <= $sortAfterPosition AND \"$tableName\".\"Sort\" > $blockPosition";
            $newBlockPosition = $sortAfterPosition;
        }

        $query = SQLUpdate::create()
           ->setTable("\"$tableName\"")
           ->assignSQL('"Sort"', "\"$tableName\".\"Sort\" $operator 1")
           ->addWhere([$filter, "\"$tableName\".\"ParentID\"" => $parentId]);

        $query->execute();

        // Now use the ORM to write a new version of the record that we are directly reordering
        $block->Sort = $newBlockPosition;
        $block->write();

        return $block;
    }