DNADesign\Elemental\GraphQL\AddElementToAreaMutation::resolve()

Complexity

Conditions	7
Paths	12

Size

Total Lines	44
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	2

<?php
    public function resolve($object, array $args, $context, ResolveInfo $info)
    {
        $elementClass = $args['ClassName'];
        $elementalAreaID = $args['ElementalAreaID'];
        $afterElementID = isset($args['AfterElementID']) ? $args['AfterElementID'] : null;

        if (!is_subclass_of($elementClass, BaseElement::class)) {
            throw new InvalidArgumentException("$elementClass is not a subclass of " . BaseElement::class);
        }

        $elementalArea = ElementalArea::get()->byID($elementalAreaID);

        if (!$elementalArea) {

$elementalArea is of type SilverStripe\ORM\DataObject, thus it always evaluated to true.

            throw new InvalidArgumentException("Invalid ElementalAreaID: $elementalAreaID");
        }

        if (!$elementalArea->canEdit($context['currentUser'])) {
            throw new InvalidArgumentException("The current user has insufficient permission to edit ElementalAreas");
        }

        /** @var BaseElement $newElement */
        $newElement = Injector::inst()->create($elementClass);

        if (!$newElement->canEdit($context['currentUser'])) {
            throw new InvalidArgumentException(
                'The current user has insufficient permission to edit Elements'
            );
        }

        // Assign the parent ID directly rather than via HasManyList to prevent multiple writes.
        // See BaseElement::$has_one for the "Parent" naming.
        $newElement->ParentID = $elementalArea->ID;

The property ParentID does not exist on DNADesign\Elemental\Models\BaseElement. Since you implemented __set, consider adding a @property annotation.

        // Ensure that a sort order is assigned - see BaseElement::onBeforeWrite()
        $newElement->onBeforeWrite();

        if ($afterElementID !== null) {
            /** @var ReorderElements $reorderer */
            $reorderer = Injector::inst()->create(ReorderElements::class, $newElement);
            $reorderer->reorder($afterElementID); // also writes the element
        } else {
            $newElement->write();
        }

        return $newElement;
    }