Issues in ElementalGridFieldDeleteAction.php (master) - Issues in master - dnadesign/silverstripe-elemental-virtual - Measure and Improve Code Quality continuously with Scrutinizer

Issues (31)

src/Forms/ElementalGridFieldDeleteAction.php (1 issue)

Labels

Severity

Major 1

<?php

namespace DNADesign\ElementalVirtual\Forms;

use SilverStripe\Forms\GridField\GridFieldDeleteAction;
use SilverStripe\Forms\GridField\GridField_FormAction;

/**
 * @package elemental
 */
class ElementalGridFieldDeleteAction extends GridFieldDeleteAction
{

    public function getColumnContent($gridField, $record, $columnName)
    {
        if (!$record->canDelete()) {
            return;
        }

        if ($record->VirtualClones()->count() > 0) {
            return false;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
        }

        return parent::getColumnContent($gridField, $record, $columnName);
    }
}


1			<?php
2
3			namespace DNADesign\ElementalVirtual\Forms;
4
5			use SilverStripe\Forms\GridField\GridFieldDeleteAction;
6			use SilverStripe\Forms\GridField\GridField_FormAction;
7
8			/**
9			* @package elemental
10			*/
11			class ElementalGridFieldDeleteAction extends GridFieldDeleteAction
12			{
13
14			public function getColumnContent($gridField, $record, $columnName)
15			{
16			if (!$record->canDelete()) {
17			return;
18			}
19
20			if ($record->VirtualClones()->count() > 0) {
21			return false;
			0 ignored issues – show Bug Best Practice introduced 2017-10-18 08:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return false` returns the type `false` which is incompatible with the return type mandated by `SilverStripe\Forms\GridF...der::getColumnContent()` of `string`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
22			}
23
24			return parent::getColumnContent($gridField, $record, $columnName);
25			}
26			}
27

dnadesign / silverstripe-elemental-virtual

Issues (31)

src/Forms/ElementalGridFieldDeleteAction.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like