DNADesign\ElementalUserForms\Model\ElementForm

Complexity

Total Complexity

5

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	Link()	0	12	2
A	ElementForm()	0	20	3

<?php

namespace DNADesign\ElementalUserForms\Model;

use SilverStripe\UserForms\Control\UserDefinedFormController;
use SilverStripe\UserForms\UserForm;
use SilverStripe\Control\Controller;
use DNADesign\Elemental\Models\BaseElement;
use DNADesign\ElementalUserForms\Control\ElementFormController;

class ElementForm extends BaseElement
{
    use UserForm;

    /**
     * @var string
     */
    private static $table_name = 'ElementForm';

The property $table_name is not used and could be removed.

    /**
     * @var string
     */
    private static $title = 'Form';

The property $title is not used and could be removed.

    /**
     * @var string
     */
    private static $icon = 'dnadesign/silverstripe-elemental-userforms:images/form.svg';

The property $icon is not used and could be removed.

    /**
     * @var string
     */
    private static $controller_class = ElementFormController::class;

The property $controller_class is not used and could be removed.

    /**
     * @return UserForm
     */
    public function ElementForm()

Please use __construct() instead of a PHP4-style constructor that is named after the class.

    {
        $controller = new UserDefinedFormController($this);
        $current = Controller::curr();

        if ($current && $current->getAction() == 'finished') {
            return $controller->renderWith(UserDefinedFormController::class .'_ReceivedFormSubmission');
        }

        $form = $controller->Form();
        $form->setFormAction(
            Controller::join_links(
                $current->Link(),
                'element',
                $this->owner->ID,

The property owner does not exist on DNADesign\ElementalUserForms\Model\ElementForm. Since you implemented __get, consider adding a @property annotation.

                'Form'
            )
        );

        return $form;

The expression return $form returns the type SilverStripe\Forms\Form which is incompatible with the documented return type SilverStripe\UserForms\UserForm.

    }

    public function Link($action = null)
    {
        $current = Controller::curr();

        if ($action === 'finished') {
            return Controller::join_links(
                $current->Link(),
                'finished'
            );
        }

        return parent::Link($action);
    }
}