DNADesign\ElementalList\Model\ElementList

Complexity

Total Complexity

8

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Importance

Changes	3
Bugs	1	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getType()	0	3	1
A	getSummary()	0	7	3
A	getOwnedAreaRelationName()	0	11	4

<?php

namespace DNADesign\ElementalList\Model;

use DNADesign\Elemental\Models\BaseElement;
use DNADesign\Elemental\Models\ElementalArea;
use DNADesign\Elemental\Extensions\ElementalAreasExtension;

use SilverStripe\Core\Config\Config;
use SilverStripe\ORM\ArrayList;
use SilverStripe\ORM\FieldType\DBField;

class ElementList extends BaseElement
{
    private static $icon = 'dnadesign/silverstripe-elemental-list:images/list.svg';

The private property $icon is not used, and could be removed.

    private static $has_one = [

The private property $has_one is not used, and could be removed.

        'Elements' => ElementalArea::class
    ];

    private static $owns = [

The private property $owns is not used, and could be removed.

        'Elements'
    ];

    private static $cascade_deletes = [

The private property $cascade_deletes is not used, and could be removed.

        'Elements'
    ];

    private static $extensions = [

The private property $extensions is not used, and could be removed.

        ElementalAreasExtension::class
    ];

    private static $table_name = 'ElementList';

The private property $table_name is not used, and could be removed.

    private static $title = 'Group';

The private property $title is not used, and could be removed.

    private static $description = 'Orderable list of elements';

The private property $description is not used, and could be removed.

    public function getType()
    {
        return _t(__CLASS__ . '.BlockType', 'List');
    }

    /**
     * @return DBField
     */
    public function getSummary()
    {
        $count = $this->Elements()->Elements()->Count();

The method Elements() does not exist on DNADesign\ElementalList\Model\ElementList. Since you implemented __call, consider adding a @method annotation.

        $suffix = $count === 1 ? 'element': 'elements';
        $summary = $this->ListDescription ? DBField::create_field('HTMLText', $this->ListDescription)->Summary(10) . '<br />': '';

The property ListDescription does not exist on DNADesign\ElementalList\Model\ElementList. Since you implemented __get, consider adding a @property annotation.

        return DBField::create_field('HTMLText', $summary . ' <span class="el-meta">Contains ' . $count . ' ' . $suffix . '</span>');
    }

    /**
     * Retrieve a elemental area relation name which this element owns
     *
     * @return string
     */
    public function getOwnedAreaRelationName()
    {
        $has_one = $this->config()->get('has_one');

        foreach ($has_one as $relationName => $relationClass) {
            if ($relationClass === ElementalArea::class && $relationName !== 'Parent') {
                return $relationName;
            }
        }

        return 'Elements';
    }
}