DNADesign\ElementalList\Extension\BaseElementCMSEditLinkExtension

Complexity

Total Complexity

3

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	updateCMSEditLink()	0	35	3

<?php

namespace DNADesign\ElementalList\Extension;

use DNADesign\Elemental\Models\BaseElement;
use DNADesign\ElementalList\Model\ElementList;
use SilverStripe\CMS\Controllers\CMSPageEditController;
use SilverStripe\Control\Controller;
use SilverStripe\Core\Extension;

/**
 * Class BaseElementCMSEditLinkExtension
 *
 * BaseElement can be nested, CMSEditLink() needs to be updated to reflect that
 *
 * @property BaseElementCMSEditLinkExtension|$this $owner
 * @package DNADesign\ElementalList\Extension
 */
class BaseElementCMSEditLinkExtension extends Extension
{
    /**
     * @param string $link
     */
    public function updateCMSEditLink(&$link)
    {
        /** @var $owner BaseElement */
        $owner = $this->owner;

        $relationName = $owner->getAreaRelationName();
        $page = $owner->getPage(true);

The call to DNADesign\Elemental\Models\BaseElement::getPage() has too many arguments starting with true.

        if (!$page) {

The expression $page of type null|false is loosely compared to false; this is ambiguous if the boolean can be false. You might want to explicitly use !== null instead.

            return;
        }

        if ($page instanceof ElementList) {
            // nested bock - we need to get edit link of parent block
            $link = Controller::join_links(
                $page->CMSEditLink(),
                'ItemEditForm/field/' . $page->getOwnedAreaRelationName() . '/item/',
                $owner->ID
            );

            // remove edit link from parent CMS link
            $link = preg_replace('/\/item\/([\d]+)\/edit/', '/item/$1', $link);
        } else {
            // block is directly under a non-block object - we have reached the top of nesting chain
            $link = Controller::join_links(
                singleton(CMSPageEditController::class)->Link('EditForm'),
                $page->ID,
                'field/' . $relationName . '/item/',
                $owner->ID
            );
        }

        $link = Controller::join_links(
            $link,
            'edit'
        );
    }
}