mandos.analysis._plot_utils.PlotUtils._markers() - Code Metrics - Inspection of "feat: no clue" - dmyersturnbull/mandos - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( ec3fe3...82dd22 )

by Douglas

created 2021-08-02 23:37 UTC

mandos.analysis._plot_utils.PlotUtils._markers() A

↳ Parent: mandos.analysis._plot_utils

Complexity

Conditions

Size

Total Lines	14
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	13
nop	3
dl	0
loc	14
rs	9.75
c	0
b	0
f	0

"""


"""


class PlotUtils:

    def _markers(self, df: pd.DataFrame, col: Optional[str]) -> Optional[pd.Series]:
class Foo:
    def some_method(self, x, y):
        return x + y;
        from matplotlib.markers import MarkerStyle


        if col is None:
            return None
        known = MarkerStyle.markers.keys()
        uniques = df[col].unique()
        if all((v in known for v in uniques)):

            return df[col]
        if len(uniques) > len(known):
            logger.error(f"{len(uniques)} unique markers > {len(known)} available. Cycling.")

        cycler = cycle(known)

        dct = {k: next(cycler) for k in uniques}
        return df[col].map(dct.get)

    def _colors(df: pd.DataFrame, col: Optional[str]) -> Optional[pd.Series]:
class SomeClass:
    def some_method(self):
        # ... do something
        if col is None:
            return None
        return df[col]



1			"""
			0 ignored issues – show Documentation introduced 2021-08-02 23:39 UTC by Report Bug Copy Issue Report Empty module docstring Loading history...
2
3			"""
4
5
6			class PlotUtils:
			0 ignored issues – show introduced 2021-08-02 23:39 UTC by Report Bug Copy Issue Report Missing class docstring Loading history...
7			def _markers(self, df: pd.DataFrame, col: Optional[str]) -> Optional[pd.Series]:
			0 ignored issues – show Coding Style Naming introduced 2021-08-02 23:39 UTC by Report Bug Copy Issue Report Argument name "df" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,\|_[^\\WA-Z]*\|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern) This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Comprehensibility Best Practice introduced 2021-08-02 23:39 UTC by Report Bug Copy Issue Report Undefined variable 'pd' Loading history... Comprehensibility Best Practice introduced 2021-08-02 23:39 UTC by Report Bug Copy Issue Report Undefined variable 'Optional' Loading history... Comprehensibility Best Practice introduced 2021-08-02 23:39 UTC by Report Bug Copy Issue Report The variable `pd` does not seem to be defined. Loading history... Coding Style introduced 2021-08-02 23:39 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
8			from matplotlib.markers import MarkerStyle
			0 ignored issues – show introduced 2021-08-02 23:39 UTC by Report Bug Copy Issue Report Import outside toplevel (matplotlib.markers.MarkerStyle) Loading history... introduced 2021-08-02 23:39 UTC by Report Bug Copy Issue Report Unable to import 'matplotlib.markers' Loading history...
9
10			if col is None:
11			return None
12			known = MarkerStyle.markers.keys()
13			uniques = df[col].unique()
14			if all((v in known for v in uniques)):
			0 ignored issues – show Comprehensibility Best Practice introduced 2021-08-02 23:39 UTC by Report Bug Copy Issue Report The variable `v` does not seem to be defined. Loading history...
15			return df[col]
16			if len(uniques) > len(known):
17			logger.error(f"{len(uniques)} unique markers > {len(known)} available. Cycling.")
			0 ignored issues – show Comprehensibility Best Practice introduced 2021-08-02 23:39 UTC by Report Bug Copy Issue Report Undefined variable 'logger' Loading history... Comprehensibility Best Practice introduced 2021-08-02 23:39 UTC by Report Bug Copy Issue Report The variable `logger` does not seem to be defined. Loading history...
18			cycler = cycle(known)
			0 ignored issues – show Comprehensibility Best Practice introduced 2021-08-02 23:39 UTC by Report Bug Copy Issue Report The variable `cycle` does not seem to be defined. Loading history... Comprehensibility Best Practice introduced 2021-08-02 23:39 UTC by Report Bug Copy Issue Report Undefined variable 'cycle' Loading history...
19			dct = {k: next(cycler) for k in uniques}
20			return df[col].map(dct.get)
21
22			def _colors(df: pd.DataFrame, col: Optional[str]) -> Optional[pd.Series]:
			0 ignored issues – show Comprehensibility Best Practice introduced 2021-08-02 23:39 UTC by Report Bug Copy Issue Report The variable `pd` does not seem to be defined. Loading history... Coding Style Best Practice introduced 2021-08-02 23:39 UTC by Report Bug Copy Issue Report Methods should have `self` as first argument. It is a widespread convention and generally a good practice to name the first argument of methods `self`. class SomeClass: def some_method(self): # ... do something Loading history... Comprehensibility Best Practice introduced 2021-08-02 23:39 UTC by Report Bug Copy Issue Report Undefined variable 'pd' Loading history... Comprehensibility Best Practice introduced 2021-08-02 23:39 UTC by Report Bug Copy Issue Report Undefined variable 'Optional' Loading history... Coding Style Naming introduced 2021-08-02 23:39 UTC by Report Bug Copy Issue Report Argument name "df" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,\|_[^\\WA-Z]*\|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern) This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
23			if col is None:
24			return None
25			return df[col]
			0 ignored issues – show introduced 2021-08-02 23:39 UTC by Report Bug Copy Issue Report Value 'df' is unsubscriptable Loading history...
26

dmyersturnbull / mandos

Push — main ( ec3fe3...82dd22 )

mandos.analysis._plot_utils.PlotUtils._markers() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like