mandos.model.hmdb_api

Complexity

Total Complexity

5

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	HmdbApi.fetch()	0	2	1
A	QueryingHmdbApi.fetch()	0	2	1
A	QueryingHmdbApi._to_json()	0	10	3

import logging

Missing module docstring

import defusedxml.ElementTree as Xml

Unused defusedxml.ElementTree imported as Xml

Unable to import 'defusedxml.ElementTree'

from pocketutils.core.dot_dict import NestedDotDict

Unable to import 'pocketutils.core.dot_dict'

logger = logging.getLogger("mandos")


class HmdbApi:

Missing class docstring

    def fetch(self, hmdb_id: str) -> NestedDotDict:

Missing function or method docstring

        raise NotImplementedError()


class QueryingHmdbApi(HmdbApi):

Missing class docstring

    def fetch(self, hmdb_id: str) -> NestedDotDict:
        url = f"https://hmdb.ca/metabolites/{hmdb_id}.xml"

The variable url seems to be unused.

        # e.g. https://hmdb.ca/metabolites/HMDB0001925.xml

    def _to_json(self, xml):
        response = {}
        for child in list(xml):
            if len(list(child)) > 0:
                response[child.tag] = self._to_json(child)
            else:
                response[child.tag] = child.text or ""
            # one-liner equivalent
            # response[child.tag] = parseXmlToJson(child) if len(list(child)) > 0 else child.text or ''

This line is too long as per the coding-style (103/100).

        return response


__all__ = ["HmdbApi", "QueryingHmdbApi"]