tests.model.test_targets.TestTargets.test_parents()

Complexity

Conditions

4

Size

Total Lines	52
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

import pytest
    def test_parents(self):

Missing function or method docstring

This method could be written as a function/class method.

        dat = dict(
            target_chembl_id="CHEMBL4444",
            pref_name="dopamine transporter",
            target_type="SINGLE_PROTEIN",
        )
        monoamine = dict(
            target_chembl_id="CHEMBL1111",
            pref_name="monoamine transporter",
            target_type="SINGLE_PROTEIN",
        )
        receptor = dict(
            target_chembl_id="CHEMBL0000", pref_name="receptor", target_type="PROTEIN_COMPLEX"
        )
        relations = [
            dict(relationship="SUBSET OF", related_target_chembl_id="CHEMBL1111"),
            dict(relationship="SUBSET OF", related_target_chembl_id="CHEMBL0000"),
        ]
        get_target = {
            "DAT": dat,
            "CHEMBL4444": dat,
            "CHEMBL1111": monoamine,
            "CHEMBL0000": receptor,
        }

        def filter_targets(kwargs):

Either all return statements in a function should return an expression, or none of them should.

            x = kwargs["target_chembl_id"]

Variable name "x" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

            if x == "CHEMBL4444":

Unnecessary "elif" after "return"

                return [dat]
            elif x == "CHEMBL1111":
                return [monoamine]
            elif x == "CHEMBL0000":
                return [receptor]

        def filter_relations(kwargs):

The argument kwargs seems to be unused.

            return relations

        api = ChemblApi.mock(
            {
                "target": ChemblEntrypoint.mock(get_target, filter_targets),
                "target_relation": ChemblEntrypoint.mock({}, filter_relations),
            }
        )
        target = TargetFactory.find("CHEMBL4444", api)
        assert len(target.links({TargetRelationshipType.subset_of})) == 2
        # should sort by CHEMBL ID first, so 0000 will be first
        parent, link_type = target.links({TargetRelationshipType.subset_of})[0]

The variable link_type seems to be unused.

        assert parent.name == "receptor"
        assert parent.chembl == "CHEMBL0000"
        parent, link_type = target.links({TargetRelationshipType.subset_of})[1]
        assert parent.name == "monoamine transporter"
        assert parent.chembl == "CHEMBL1111"