dmt-software / webservices-client

src/ClientHandler.php

<?php

namespace DMT\WebservicesNl\Client;

use DMT\WebservicesNl\Client\Request\LoginRequest;
use DMT\WebservicesNl\Client\Request\LogoutRequest;
use DMT\WebservicesNl\Client\Request\RequestInterface;
use DMT\WebservicesNl\Client\Response\LoginResponse;
use DMT\WebservicesNl\Client\Response\ResponseInterface;
use GuzzleHttp\Client;

This use statement conflicts with another class in this namespace, DMT\WebservicesNl\Client\Client. Consider defining an alias.

use JMS\Serializer\SerializationContext;
use JMS\Serializer\Serializer;

/**
 * Class AbstractHandler
 *
 * @package DMT\WebservicesNl\Client
 */
class ClientHandler
{
    /**
     * @var Client
     */
    protected $httpClient;

    /**
     * @var Serializer
     */
    protected $serializer;

    /**
     * @var string
     */
    protected $serializerFormat;

    /**
     * @var string
     */
    protected $deserializerFormat;

    /**
     * DutchBusinessHandler constructor.
     *
     * @param Client $httpClient
     * @param Serializer $serializer
     * @param string $serializerFormat
     * @param string|null $deserializerFormat
     */
    public function __construct(
        Client $httpClient,
        Serializer $serializer,
        string $serializerFormat,
        string $deserializerFormat = null
    ) {
        $this->httpClient = $httpClient;
        $this->serializer = $serializer;
        $this->serializerFormat = $serializerFormat;
        $this->deserializerFormat = $deserializerFormat ?? $serializerFormat;
    }

    /**
     * @param LoginRequest|RequestInterface $request
     *
     * @return LoginResponse|ResponseInterface
     */
    public function login(LoginRequest $request): LoginResponse
    {
        return $this->process($request, LoginResponse::class);

The expression return $this->process($request, DMT\WebservicesNl\Client\Response\LoginResponse::class) returns the type null which is incompatible with the type-hinted return DMT\WebservicesNl\Client\Response\LoginResponse.

    }

    /**
     * @param LogoutRequest|RequestInterface $request
     *
     * @return null
     */
    public function logout(LogoutRequest $request)
    {
        return $this->process($request);

Are you sure the usage of $this->process($request) targeting DMT\WebservicesNl\Client\ClientHandler::process() seems to always return null.

    }

    /**
     * @param RequestInterface $request
     * @param string $responseClassName
     *
     * @return ResponseInterface
     */
    protected function process(RequestInterface $request, string $responseClassName = null): ?ResponseInterface
    {
        $context = SerializationContext::create();

        $request = $this->serializer->serialize($request, $this->serializerFormat, $context);

        $response = $this->httpClient->post('', ['body' => $request]);

        if (!$responseClassName) {
            return null;
        }

        return $this->serializer->deserialize($response->getBody(), $responseClassName, $this->deserializerFormat);
    }
}