DMT\Soap\Serializer\SoapFaultException::__construct()

Complexity

Conditions	3
Paths	4

Size

Total Lines

17

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	3

Importance

Changes

0

<?php
    public function __construct(string $code, string $reason, string $node = null, array $detail = null)
    {
        $this->code = is_array($code) ? implode('.', $code) : $code;

The condition is_array($code) is always false.

        $this->reason = $reason;
        $this->node = $node;
        $this->detail = $detail;

        if (class_exists(\SoapFault::class)) {
            $code = preg_replace(
                ['~^Receiver~', '~^Sender~', '~^DataEncodingUnknown~'],
                ['Server', 'Client', 'Client'],
                $this->code
            );
            $previous = new \SoapFault($code, $reason, $node, $detail);

The call to SoapFault::__construct() has too many arguments starting with $detail.

$reason of type string is incompatible with the type integer expected by parameter $code of SoapFault::__construct().

It seems like $node can also be of type string; however, parameter $previous of SoapFault::__construct() does only seem to accept Throwable|null, maybe add an additional type check?

        }

        parent::__construct($reason, 0, $previous ?? null);
    }