PublicatieReference::__construct() - Code Metrics - Inspection of "added lazy load insolvencies and reports propertie..." - dmt-software/insolvency-client - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( e89c90...b07112 )

by Bas

created 2022-07-15 12:25 UTC

PublicatieReference::__construct() A

↳ Parent: PublicatieReference

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
eloc	3
c	1
b	0
f	1
dl	0
loc	6
ccs	3
cts	3
cp	1
rs	10
cc	1
nc	1
nop	1
crap	1

<?php


namespace DMT\Insolvency\Model;

use DMT\Insolvency\Client;
use DMT\Insolvency\Soap\Response\GetCaseResponse;
use DMT\Insolvency\Soap\Response\GetCaseWithReportsResponse;
use JMS\Serializer\Annotation as JMS;

/**
 * Class PublicatieReference
 *
 * @JMS\XmlNamespace("http://www.rechtspraak.nl/namespaces/cir01")
 * @JMS\XmlRoot("publicatieKenmerk", namespace="http://www.rechtspraak.nl/namespaces/inspubber01")

 */

class PublicatieReference implements ConstructWithClientInterface
{
    use LazyLoadingPropertyTrait;

    /**

     * @JMS\Type("string")
     * @JMS\XmlValue()
     *
     * @var string $publicatieKenmerk
     */
    public $publicatieKenmerk;

    /**

     * @JMS\ReadOnlyProperty()
     *
     * @var Insolvente $insolvente
     */
    private $insolvente;


    public function __construct(Client $client)

    {
        $this->insolvente = function () use ($client) {

            $case = $client->getCaseWithReports($this->publicatieKenmerk);

            return $case->result->inspubWebserviceInsolvente->insolvente;
        };
    }


}


1		<?php
2
		0 ignored issues – show Coding Style introduced 2022-07-15 12:29 UTC by Report Bug Copy Issue Report Missing file doc comment Loading history...
3		namespace DMT\Insolvency\Model;
4
5		use DMT\Insolvency\Client;
6		use DMT\Insolvency\Soap\Response\GetCaseResponse;
7		use DMT\Insolvency\Soap\Response\GetCaseWithReportsResponse;
8		use JMS\Serializer\Annotation as JMS;
9
10		/**
11		* Class PublicatieReference
12		*
13		* @JMS\XmlNamespace("http://www.rechtspraak.nl/namespaces/cir01")
14		* @JMS\XmlRoot("publicatieKenmerk", namespace="http://www.rechtspraak.nl/namespaces/inspubber01")
		0 ignored issues – show Coding Style introduced 2022-07-15 12:29 UTC by Report Bug Copy Issue Report Tag value for @JMS\XmlRoot("publicatieKenmerk", tag indented incorrectly; expected 31 spaces but found 1 Loading history...
15		*/
		0 ignored issues – show Coding Style introduced 2022-07-15 12:29 UTC by Report Bug Copy Issue Report Missing @category tag in class comment Loading history... Coding Style introduced 2022-07-15 12:29 UTC by Report Bug Copy Issue Report Missing @package tag in class comment Loading history... Coding Style introduced 2022-07-15 12:29 UTC by Report Bug Copy Issue Report Missing @author tag in class comment Loading history... Coding Style introduced 2022-07-15 12:29 UTC by Report Bug Copy Issue Report Missing @license tag in class comment Loading history... Coding Style introduced 2022-07-15 12:29 UTC by Report Bug Copy Issue Report Missing @link tag in class comment Loading history...
16		class PublicatieReference implements ConstructWithClientInterface
17		{
18		use LazyLoadingPropertyTrait;
19
20		/**
		0 ignored issues – show Coding Style introduced 2022-07-15 12:29 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
21		* @JMS\Type("string")
22		* @JMS\XmlValue()
23		*
24		* @var string $publicatieKenmerk
25		*/
26		public $publicatieKenmerk;
27
28		/**
		0 ignored issues – show Coding Style introduced 2022-07-15 12:29 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
29		* @JMS\ReadOnlyProperty()
30		*
31		* @var Insolvente $insolvente
32		*/
33		private $insolvente;
		0 ignored issues – show Coding Style introduced 2022-07-15 12:29 UTC by Report Bug Copy Issue Report Private member variable "insolvente" must be prefixed with an underscore Loading history...
34
35	5	public function __construct(Client $client)
		0 ignored issues – show Coding Style introduced 2022-07-15 12:29 UTC by Report Bug Copy Issue Report Missing doc comment for function __construct() Loading history...
36		{
37		$this->insolvente = function () use ($client) {
		0 ignored issues – show Documentation Bug introduced 2022-07-15 12:29 UTC by Report Bug Copy Issue Report It seems like `function(...) { /* ... */ }` of type `callable` is incompatible with the declared type `DMT\Insolvency\Model\Insolvente` of property `$insolvente`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
38	5	$case = $client->getCaseWithReports($this->publicatieKenmerk);
39
40	5	return $case->result->inspubWebserviceInsolvente->insolvente;
41		};
42	5	}
43
44
45		}
46

dmt-software / insolvency-client

Push — master ( e89c90...b07112 )

PublicatieReference::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like