DmitryBubyakin\Shortener\Shortener

Complexity

Total Complexity

4

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getShortUrl()	0	6	1
A	getRedirectTo()	0	6	1
A	routes()	0	4	1

<?php

namespace DmitryBubyakin\Shortener;

use Hashids\Hashids;
use Illuminate\Support\Facades\Route;

class Shortener
{
    /** @var Hashids */
    protected $hash;

    /** @var string */
    protected $route;

    public function __construct(Hashids $hash, string $route)
    {
        $this->hash = $hash;
        $this->route = $route;
    }

    public function getShortUrl(string $url): string
    {
        $id = ShortUrl::firstOrCreate(compact('url'))->id;

        return url($this->route, $this->hash->encode($id));
    }

    public function getRedirectTo(string $hash): string
    {
        [$id] = $this->hash->decode($hash);

The variable $id does not exist. Did you forget to declare it?

        return ShortUrl::findOrFail($id)->url;
    }

    public function routes(): void
    {
        Route::get("{$this->route}/{hash}", '\DmitryBubyakin\Shortener\Http\Controllers\Redirect');
    }
}