TypeHelperTrait::castValueToSimpleType() - Code Metrics - Inspection of "32bit exceptions/warnings" - dkd/php-cmis-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 32bit ( d9638d...750811 )

unknown

created 2016-05-10 16:13 UTC

TypeHelperTrait::castValueToSimpleType() B

↳ Parent: TypeHelperTrait

Complexity

Conditions	5
Paths	3

Size

Total Lines	23
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	5.0113

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	23
ccs	12
cts	13
cp	0.9231
rs	8.5906
cc	5
eloc	15
nc	3
nop	3
crap	5.0113

<?php
namespace Dkd\PhpCmis\Traits;

/**
 * This file is part of php-cmis-lib.
 *
 * (c) Sascha Egerer <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

use Dkd\PhpCmis\Exception\CmisInvalidArgumentException;

/**
 * Trait with some type check related functions
 */
trait TypeHelperTrait
{
    /**
     * Check if the given value is the expected object type
     *
     * @param string $expectedType the expected object type (class name)
     * @param mixed $value The value that has to be checked
     * @param boolean $nullAllowed Is <code>null</code> allowed as value?
     * @return boolean returns <code>true</code> if the given value is instance of expected type
     * @throws CmisInvalidArgumentException Exception is thrown if the given value does not match to the expected type
     */
    protected function checkType($expectedType, $value, $nullAllowed = false)
    {
        $invalidType = null;
        $valueType = gettype($value);
        $nullAllowed = (boolean) $nullAllowed;

        if ($valueType === 'object') {
            if (!is_a($value, $expectedType)) {
                $invalidType = get_class($value);
            }
        } elseif ($expectedType !== $valueType) {
            $invalidType = $valueType;
        }

        if ($invalidType !== null && ($nullAllowed === false || ($nullAllowed === true && $value !== null))) {
            throw new CmisInvalidArgumentException(
                sprintf(
                    'Argument of type "%s" given but argument of type "%s" was expected.',
                    $invalidType,
                    $expectedType
                ),
                1413440336
            );
        }

        return true;
    }

    /**
     * Ensure that a value is an instance of the expected type. If not the value
     * is casted to the expected type and a log message is triggered.
     *
     * @param string $expectedType the expected object type (class name)
     * @param mixed $value The value that has to be checked
     * @param boolean $nullIsValidValue defines if <code>null</code> is also a valid value
     * @return mixed
     */
    protected function castValueToSimpleType($expectedType, $value, $nullIsValidValue = false)
    {
        try {
            $this->checkType($expectedType, $value, $nullIsValidValue);
        } catch (CmisInvalidArgumentException $exception) {
            if (PHP_INT_SIZE == 4 && $expectedType == "integer" && gettype($value) == "double") {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
                //32bit - handle this specially?
            } else {
                trigger_error(
                    sprintf(
                        'Given value is of type "%s" but a value of type "%s" was expected.'
                        . ' Value has been casted to the expected type.',
                        gettype($value),
                        $expectedType
                    ),
                    E_USER_NOTICE
                );
                settype($value, $expectedType);
            }
        }

        return $value;
    }
}


1		<?php
2		namespace Dkd\PhpCmis\Traits;
3
4		/**
5		* This file is part of php-cmis-lib.
6		*
7		* (c) Sascha Egerer <[email protected]>
8		*
9		* For the full copyright and license information, please view the LICENSE
10		* file that was distributed with this source code.
11		*/
12
13		use Dkd\PhpCmis\Exception\CmisInvalidArgumentException;
14
15		/**
16		* Trait with some type check related functions
17		*/
18		trait TypeHelperTrait
19		{
20		/**
21		* Check if the given value is the expected object type
22		*
23		* @param string $expectedType the expected object type (class name)
24		* @param mixed $value The value that has to be checked
25		* @param boolean $nullAllowed Is <code>null</code> allowed as value?
26		* @return boolean returns <code>true</code> if the given value is instance of expected type
27		* @throws CmisInvalidArgumentException Exception is thrown if the given value does not match to the expected type
28		*/
29	825	protected function checkType($expectedType, $value, $nullAllowed = false)
30		{
31	825	$invalidType = null;
32	825	$valueType = gettype($value);
33	825	$nullAllowed = (boolean) $nullAllowed;
34
35	825	if ($valueType === 'object') {
36	69	if (!is_a($value, $expectedType)) {
37	11	$invalidType = get_class($value);
38	11	}
39	825	} elseif ($expectedType !== $valueType) {
40	435	$invalidType = $valueType;
41	435	}
42
43	825	if ($invalidType !== null && ($nullAllowed === false \|\| ($nullAllowed === true && $value !== null))) {
44	394	throw new CmisInvalidArgumentException(
45	394	sprintf(
46	394	'Argument of type "%s" given but argument of type "%s" was expected.',
47	394	$invalidType,
48		$expectedType
49	394	),
50		1413440336
51	394	);
52		}
53
54	734	return true;
55		}
56
57		/**
58		* Ensure that a value is an instance of the expected type. If not the value
59		* is casted to the expected type and a log message is triggered.
60		*
61		* @param string $expectedType the expected object type (class name)
62		* @param mixed $value The value that has to be checked
63		* @param boolean $nullIsValidValue defines if <code>null</code> is also a valid value
64		* @return mixed
65		*/
66	613	protected function castValueToSimpleType($expectedType, $value, $nullIsValidValue = false)
67		{
68		try {
69	613	$this->checkType($expectedType, $value, $nullIsValidValue);
70	613	} catch (CmisInvalidArgumentException $exception) {
71	316	if (PHP_INT_SIZE == 4 && $expectedType == "integer" && gettype($value) == "double") {
		0 ignored issues – show Unused Code introduced 2016-05-10 16:20 UTC by Report Bug Copy Issue Report This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history... Coding Style Comprehensibility introduced 2016-05-10 16:20 UTC by Report Bug Copy Issue Report The string literal `integer` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2016-05-10 16:20 UTC by Report Bug Copy Issue Report The string literal `double` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
72		//32bit - handle this specially?
73		} else {
74	316	trigger_error(
75	316	sprintf(
76		'Given value is of type "%s" but a value of type "%s" was expected.'
77	316	. ' Value has been casted to the expected type.',
78	316	gettype($value),
79		$expectedType
80	316	),
81		E_USER_NOTICE
82	316	);
83	295	settype($value, $expectedType);
84		}
85		}
86
87	592	return $value;
88		}
89		}
90

dkd / php-cmis-client

GitHub Access Token became invalid

Push — 32bit ( d9638d...750811 )

TypeHelperTrait::castValueToSimpleType() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like