ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\SortingExpression

Complexity

Total Complexity

11

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	getForFacet()	0	12	8
A	getForJsonFacet()	0	9	3

<?php
namespace ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets;

/***************************************************************
 *  Copyright notice
 *
 *  (c) 2017- Timo Hund <timo.hund@dkd.de>
 *  All rights reserved
 *
 *  This script is part of the TYPO3 project. The TYPO3 project is
 *  free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 2 of the License, or
 *  (at your option) any later version.
 *
 *  The GNU General Public License can be found at
 *  http://www.gnu.org/copyleft/gpl.html.
 *
 *  This script is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  This copyright notice MUST APPEAR in all copies of the script!
 ***************************************************************/

/**
 * Expression for facet sorting
 *
 * @author Timo Hund <timo.hund@dkd.de>
 * @author Jens Jacobsen <jens.jacobsen@ueberbit.de>
 * @package ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets
 */
class SortingExpression
{
    /**
     * Return expression for facet sorting
     *
     * @param string $sorting
     * @return string
     */
    public function getForFacet($sorting)
    {
        $noSortingSet = $sorting !== 0 && $sorting !== FALSE && empty($sorting);

The strict comparison !== seems to always evaluate to true as the types of $sorting (string) and 0 (integer) can never be identical. Maybe you want to use a loose comparison != instead?

        $sortingIsCount = $sorting === 'count' || $sorting === 1 || $sorting === '1' || $sorting === TRUE;

The strict comparison === seems to always evaluate to false as the types of $sorting (string) and 1 (integer) can never be identical. Maybe you want to use a loose comparison == instead?

        if ($noSortingSet) {
            return '';
        } elseif ($sortingIsCount) {
            return 'count';
        } else {
            return 'index';
        }
    }

    /**
     * Return expression for facet sorting combined with direction
     *
     * @param string $sorting
     * @param string $direction
     * @return string
     */
    public function getForJsonFacet($sorting, $direction)
    {
        $expression = $this->getForFacet($sorting);
        $direction = strtolower($direction);
        if (!empty($direction) && in_array($direction, ['asc', 'desc'])) {
            $expression .= ' ' . $direction;
        }
        return $expression;
    }
}