ClassResolver::resolve() - Code Metrics - Inspection of "Code improvements" - djuricmilos/container - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5a2a79...584535 )

by Miloš

created 2020-01-31 15:51 UTC

ClassResolver::resolve() A

↳ Parent: ClassResolver

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2.0185

Importance

Changes

Metric	Value
cc	2
nc	2
nop	1
dl	0
loc	12
ccs	5
cts	6
cp	0.8333
crap	2.0185
rs	9.8666
c	0
b	0
f	0

<?php

namespace Laganica\Di\Resolver;

use Laganica\Di\Definition\DefinitionInterface;
use Laganica\Di\Exception\NotFoundException;

/**
 * Class AutowireResolver
 *
 * @package Laganica\Di\Resolver
 */
class ClassResolver extends ReflectionResolver
{
    /**
     * @inheritDoc
     */
    public function resolve(DefinitionInterface $definition)
    {
        $class = $definition->getValue();

        if (class_exists($class)) {
            $params = $this->getConstructorParams($class);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

            return new $class(...$params);
        }

        throw NotFoundException::create($class);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }
}


1		<?php
2
3		namespace Laganica\Di\Resolver;
4
5		use Laganica\Di\Definition\DefinitionInterface;
6		use Laganica\Di\Exception\NotFoundException;
7
8		/**
9		* Class AutowireResolver
10		*
11		* @package Laganica\Di\Resolver
12		*/
13		class ClassResolver extends ReflectionResolver
14		{
15		/**
16		* @inheritDoc
17		*/
18	4	public function resolve(DefinitionInterface $definition)
19		{
20	4	$class = $definition->getValue();
21
22	4	if (class_exists($class)) {
23	4	$params = $this->getConstructorParams($class);
		0 ignored issues – show Bug introduced 2020-01-31 15:52 UTC by Report Bug Copy Issue Report It seems like `$class` defined by `$definition->getValue()` on line `20` can also be of type `object<Closure>`; however, `Laganica\Di\Resolver\Ref...:getConstructorParams()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
24
25	4	return new $class(...$params);
26		}
27
28		throw NotFoundException::create($class);
		0 ignored issues – show Bug introduced 2020-01-31 15:52 UTC by Report Bug Copy Issue Report It seems like `$class` defined by `$definition->getValue()` on line `20` can also be of type `object<Closure>`; however, `Laganica\Di\Exception\NotFoundException::create()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
29		}
30		}
31

djuricmilos / container

Push — master ( 5a2a79...584535 )

ClassResolver::resolve() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like