ClassResolver::resolve() - Code Metrics - djuricmilos/container - Measure and Improve Code Quality continuously with Scrutinizer

ClassResolver::resolve() A
last analyzed 2020-09-08 22:11 UTC

↳ Parent: ClassResolver

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
nc	2
nop	1
dl	0
loc	15
ccs	8
cts	8
cp	1
crap	2
rs	9.7666
c	0
b	0
f	0

<?php

/**
 * This file is part of the Container package.
 *
 * Copyright (c) Miloš Đurić <[email protected]>
 *
 * For full copyright and license information, please refer to the LICENSE file,
 * located at the package root folder.
 */

namespace Laganica\Di\Resolver;

use Laganica\Di\Definition\ClassDefinition;
use Laganica\Di\Definition\DefinitionInterface;

/**
 * Class AutowireResolver
 *
 * @package Laganica\Di\Resolver
 */
class ClassResolver extends ReflectionResolver
{
    /**
     * @inheritDoc
     */
    public function resolve(DefinitionInterface $definition)
    {
        $this->validate($definition, ClassDefinition::class);

        $class = $definition->getClass();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $params = $this->getConstructorParams($class);

        $entry = new $class(...$params);

        if ($this->getContainer()->hasAnnotationsEnabled()) {
            $this->injectProperties($entry);
        }

        return $entry;
    }
}


1		<?php
2
3		/**
4		* This file is part of the Container package.
5		*
6		* Copyright (c) Miloš Đurić <[email protected]>
7		*
8		* For full copyright and license information, please refer to the LICENSE file,
9		* located at the package root folder.
10		*/
11
12		namespace Laganica\Di\Resolver;
13
14		use Laganica\Di\Definition\ClassDefinition;
15		use Laganica\Di\Definition\DefinitionInterface;
16
17		/**
18		* Class AutowireResolver
19		*
20		* @package Laganica\Di\Resolver
21		*/
22		class ClassResolver extends ReflectionResolver
23		{
24		/**
25		* @inheritDoc
26		*/
27	14	public function resolve(DefinitionInterface $definition)
28		{
29	14	$this->validate($definition, ClassDefinition::class);
30
31	14	$class = $definition->getClass();
		0 ignored issues – show Bug introduced 2020-01-31 23:32 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Laganica\Di\Definition\DefinitionInterface` as the method `getClass()` does only exist in the following implementations of said interface: `Laganica\Di\Definition\ClassDefinition`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
32	14	$params = $this->getConstructorParams($class);
33
34	10	$entry = new $class(...$params);
35
36	10	if ($this->getContainer()->hasAnnotationsEnabled()) {
37	1	$this->injectProperties($entry);
38		}
39
40	10	return $entry;
41		}
42		}
43

djuricmilos / container

ClassResolver::resolve() A last analyzed 2020-09-08 22:11 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

ClassResolver::resolve() A
last analyzed 2020-09-08 22:11 UTC