Issues in VTPass.php (master) - Issues in master - djunehor/laravel-vtu - Measure and Improve Code Quality continuously with Scrutinizer

Issues (11)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Concrete/VTPass.php (5 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php


namespace Djunehor\Vtu\Concrete;


use Djunehor\Vtu\Contracts\VtuServiceInterface;
use GuzzleHttp\Exception\ClientException;
use GuzzleHttp\Psr7\Request;
use Illuminate\Support\Str;

class VTPass extends Vtu
{
    private $sandboxURL='https://sandbox.vtpass.com/api/';
    private $liveAPI='https://vtpass.com/api/';
    private $baseUrl;

    public function __construct($username = null, $password = null, $live = true)
    {
        $this->username = $username ?? config('laravel-vtu.vtpass.username');
        $this->password = $password ?? config('laravel-vtu.vtpass.password');
        $this->baseUrl = $live ? $this->liveAPI : $this->sandboxURL;

        $this->client = $this->getInstance();

    }

    /**
     * acceptable network: mtn, airtel, etisalat, glo
     * @param $amount
     * @param $mobileNumber
     * @param $mobileNetwork
     * @param null $callBackUrl
     * @return bool
     */
    public function buyAirtime($amount, $mobileNumber, $mobileNetwork, $callBackUrl = null): bool
    {
        $headers = [
            "Authorization" => "Basic ".$this->username.$this->password
        ];
        $this->request = new Request('POST', $this->baseUrl."pay", $headers);

        try {
            $response = $this->client->send($this->request, [
                'form_params' => [
                    'request_id' => $requestId = Str::random(32),
                    'serviceID' => $mobileNetwork,
                    'amount' => $amount,
                    'phone' => $mobileNumber,
                ],
            ]);

            $response = json_decode($response->getBody()->getContents(), true);
            $this->response = $response['response_description'];
            $this->orderId = $requestId;
class MyClass { }

$x = new MyClass();
$x->foo = true;

            return $response['code'] == '000' ? true : false;
        } catch (ClientException $e) {
            $this->httpError = $e;

            return false;
        } catch (\Exception $e) {
            $this->httpError = $e;

            return false;
        }
    }

    /**
     * @inheritDoc
     */
    public function buyData($mobileNumber, $mobileNetwork, $dataPlan, $callBackUrl): bool
    {
        // TODO: Implement buyData() method.
    }


    public function queryOrder($orderId): bool

    {
        $headers = [
            "Authorization" => "Basic ".$this->username.$this->password
        ];
        $this->request = new Request('POST', $this->baseUrl."pay", $headers);

        try {
            $response = $this->client->send($this->request, [
                'form_params' => [
                    'request_id' => $requestId = Str::random(32),
                ],
            ]);

            $response = json_decode($response->getBody()->getContents(), true);
            $this->response = $response['content'];

            return $response['code'] == '001' ? true : false;
        } catch (ClientException $e) {
            $this->httpError = $e;

            return false;
        } catch (\Exception $e) {
            $this->httpError = $e;

            return false;
        }
    }

    public function variationCodes($serviceId): bool

    {
        $headers = [
            "Authorization" => "Basic ".$this->username.$this->password
        ];
        $this->request = new Request('GET', $this->baseUrl."service-variations", $headers);

        try {
            $response = $this->client->send($this->request, [
                'query_params' => [
                    'serviceID' => $serviceId,
                ],
            ]);

            $response = json_decode($response->getBody()->getContents(), true);
            $this->response = $response['content'];

            return $response['content'] ? true : false;
        } catch (ClientException $e) {
            $this->httpError = $e;

            return false;
        } catch (\Exception $e) {
            $this->httpError = $e;

            return false;
        }
    }

    public function verifySmartCard($smartCardNumber, $serviceId): bool

    {
        $headers = [
            "Authorization" => "Basic ".$this->username.$this->password
        ];
        $this->request = new Request('GET', $this->baseUrl."merchant-verify", $headers);

        try {
            $response = $this->client->send($this->request, [
                'query_params' => [
                    'billersCode' => $smartCardNumber,
                    'serviceID' => $serviceId,
                ],
            ]);

            $response = json_decode($response->getBody()->getContents(), true);
            $this->response = $response['content'];

            return $response['code'] == '000' ? true : false;
        } catch (ClientException $e) {
            $this->httpError = $e;

            return false;
        } catch (\Exception $e) {
            $this->httpError = $e;

            return false;
        }
    }

    public function payUtility($smartCardNumber, $cableTv, $package, $callbackUrl = null, $phone = null): bool
    {
        $headers = [
            "Authorization" => "Basic ".$this->username.$this->password
        ];
        $this->request = new Request('GET', $this->baseUrl."pay", $headers);

        try {
            $response = $this->client->send($this->request, [
                'query_params' => [
                    'billersCode' => $smartCardNumber,
                    'serviceID' => $cableTv,
                    'variation_code' => $package,
                    'phone' => $phone,
                ],
            ]);

            $response = json_decode($response->getBody()->getContents(), true);
            $this->response = $response['content'];

            return $response['code'] == '000' ? true : false;
        } catch (ClientException $e) {
            $this->httpError = $e;

            return false;
        } catch (\Exception $e) {
            $this->httpError = $e;

            return false;
        }
    }
}

1			<?php
2
3
4			namespace Djunehor\Vtu\Concrete;
5
6
7			use Djunehor\Vtu\Contracts\VtuServiceInterface;
8			use GuzzleHttp\Exception\ClientException;
9			use GuzzleHttp\Psr7\Request;
10			use Illuminate\Support\Str;
11
12			class VTPass extends Vtu
13			{
14			private $sandboxURL='https://sandbox.vtpass.com/api/';
15			private $liveAPI='https://vtpass.com/api/';
16			private $baseUrl;
17
18	1		public function __construct($username = null, $password = null, $live = true)
19			{
20	1		$this->username = $username ?? config('laravel-vtu.vtpass.username');
21	1		$this->password = $password ?? config('laravel-vtu.vtpass.password');
22	1		$this->baseUrl = $live ? $this->liveAPI : $this->sandboxURL;
23
24	1		$this->client = $this->getInstance();
25
26	1		}
27
28			/**
29			* acceptable network: mtn, airtel, etisalat, glo
30			* @param $amount
31			* @param $mobileNumber
32			* @param $mobileNetwork
33			* @param null $callBackUrl
34			* @return bool
35			*/
36	1		public function buyAirtime($amount, $mobileNumber, $mobileNetwork, $callBackUrl = null): bool
37			{
38			$headers = [
39	1		"Authorization" => "Basic ".$this->username.$this->password
40			];
41	1		$this->request = new Request('POST', $this->baseUrl."pay", $headers);
42
43			try {
44	1		$response = $this->client->send($this->request, [
45			'form_params' => [
46	1		'request_id' => $requestId = Str::random(32),
47	1		'serviceID' => $mobileNetwork,
48	1		'amount' => $amount,
49	1		'phone' => $mobileNumber,
50			],
51			]);
52
53			$response = json_decode($response->getBody()->getContents(), true);
54			$this->response = $response['response_description'];
55			$this->orderId = $requestId;
			0 ignored issues – show Bug introduced 2020-01-13 16:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `orderId` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
56
57			return $response['code'] == '000' ? true : false;
58	1		} catch (ClientException $e) {
59	1		$this->httpError = $e;
60
61	1		return false;
62			} catch (\Exception $e) {
63			$this->httpError = $e;
64
65			return false;
66			}
67			}
68
69			/**
70			* @inheritDoc
71			*/
72			public function buyData($mobileNumber, $mobileNetwork, $dataPlan, $callBackUrl): bool
73			{
74			// TODO: Implement buyData() method.
75			}
76
77
78		View Code Duplication	public function queryOrder($orderId): bool
			0 ignored issues – show Unused Code introduced 2020-01-13 16:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$orderId` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2020-01-13 16:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
79			{
80			$headers = [
81			"Authorization" => "Basic ".$this->username.$this->password
82			];
83			$this->request = new Request('POST', $this->baseUrl."pay", $headers);
84
85			try {
86			$response = $this->client->send($this->request, [
87			'form_params' => [
88			'request_id' => $requestId = Str::random(32),
89			],
90			]);
91
92			$response = json_decode($response->getBody()->getContents(), true);
93			$this->response = $response['content'];
94
95			return $response['code'] == '001' ? true : false;
96			} catch (ClientException $e) {
97			$this->httpError = $e;
98
99			return false;
100			} catch (\Exception $e) {
101			$this->httpError = $e;
102
103			return false;
104			}
105			}
106
107		View Code Duplication	public function variationCodes($serviceId): bool
			0 ignored issues – show Duplication introduced 2020-01-13 16:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
108			{
109			$headers = [
110			"Authorization" => "Basic ".$this->username.$this->password
111			];
112			$this->request = new Request('GET', $this->baseUrl."service-variations", $headers);
113
114			try {
115			$response = $this->client->send($this->request, [
116			'query_params' => [
117			'serviceID' => $serviceId,
118			],
119			]);
120
121			$response = json_decode($response->getBody()->getContents(), true);
122			$this->response = $response['content'];
123
124			return $response['content'] ? true : false;
125			} catch (ClientException $e) {
126			$this->httpError = $e;
127
128			return false;
129			} catch (\Exception $e) {
130			$this->httpError = $e;
131
132			return false;
133			}
134			}
135
136		View Code Duplication	public function verifySmartCard($smartCardNumber, $serviceId): bool
			0 ignored issues – show Duplication introduced 2020-01-13 16:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
137			{
138			$headers = [
139			"Authorization" => "Basic ".$this->username.$this->password
140			];
141			$this->request = new Request('GET', $this->baseUrl."merchant-verify", $headers);
142
143			try {
144			$response = $this->client->send($this->request, [
145			'query_params' => [
146			'billersCode' => $smartCardNumber,
147			'serviceID' => $serviceId,
148			],
149			]);
150
151			$response = json_decode($response->getBody()->getContents(), true);
152			$this->response = $response['content'];
153
154			return $response['code'] == '000' ? true : false;
155			} catch (ClientException $e) {
156			$this->httpError = $e;
157
158			return false;
159			} catch (\Exception $e) {
160			$this->httpError = $e;
161
162			return false;
163			}
164			}
165
166			public function payUtility($smartCardNumber, $cableTv, $package, $callbackUrl = null, $phone = null): bool
167			{
168			$headers = [
169			"Authorization" => "Basic ".$this->username.$this->password
170			];
171			$this->request = new Request('GET', $this->baseUrl."pay", $headers);
172
173			try {
174			$response = $this->client->send($this->request, [
175			'query_params' => [
176			'billersCode' => $smartCardNumber,
177			'serviceID' => $cableTv,
178			'variation_code' => $package,
179			'phone' => $phone,
180			],
181			]);
182
183			$response = json_decode($response->getBody()->getContents(), true);
184			$this->response = $response['content'];
185
186			return $response['code'] == '000' ? true : false;
187			} catch (ClientException $e) {
188			$this->httpError = $e;
189
190			return false;
191			} catch (\Exception $e) {
192			$this->httpError = $e;
193
194			return false;
195			}
196			}
197			}

djunehor / laravel-vtu

Issues (11)

Security Analysis no request data

src/Concrete/VTPass.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like