Djunehor\Vtu\Concrete\CowrieSys

Complexity

Total Complexity

11

Size/Duplication

Total Lines	101
Duplicated Lines	73.27 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

43.64%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	sign()	0	3	1
A	buyAirtime()	37	37	4
A	buyData()	37	37	4
A	payUtility()	0	4	1

<?php

namespace Djunehor\Vtu\Concrete;


use GuzzleHttp\Exception\ClientException;
use GuzzleHttp\Psr7\Request;

class CowrieSys extends Vtu
{
    private $baseUrl ='https://api.cowriesys.com';

    public function __construct($clientId = null, $clientKey = null)
    {
        $this->username = $clientId ?? config('laravel-vtu.cowriesys.client_id');
        $this->password = $clientKey ?? config('laravel-vtu.cowriesys.client_key');

        $this->client = $this->getInstance();

    }

    function sign($message) {

It is generally recommended to explicitly declare the visibility for methods.

        return base64_encode(hash_hmac('sha256', $message, base64_decode($this->password), true));
    }

    public function buyAirtime($amount, $mobileNumber, $mobileNetwork, $callbackUrl = null) : bool {

This method seems to be duplicated in your project.

        $nonce = uniqid();
        $queryString = '?net='.$mobileNetwork.'&msisdn='.$mobileNumber.'&amount='.$amount.'&xref='.$nonce;
        $signature = $this->sign($nonce.$queryString);
        $headers = [
            'ClientId: '.$this->username,
            'Signature: '.$signature,
            'Nonce: '.$nonce
        ];
        $api = '/airtime/Credit';
        $this->request = new Request('GET', $this->baseUrl.$api, $headers);


        try {
            $response = $this->client->send($this->request, [
                'query' => [
                    'net' => $mobileNetwork,
                    'msisdn' => $mobileNumber,
                    'amount' => $amount,
                    'xref' => $nonce,
                ],
            ]);

            $response = json_decode($response->getBody()->getContents(), true);
            $this->response = $response;

            return $response ? true : false;
        } catch (ClientException $e) {
            $this->httpError = $e;

            return false;
        } catch (\Exception $e) {
            $this->httpError = $e;

            return false;
        }
    }

    public function buyData($amount, $mobileNumber, $mobileNetwork, $callbackUrl = null) : bool {

This method seems to be duplicated in your project.

        $nonce = uniqid();
        $queryString = '?net='.$mobileNetwork.'&msisdn='.$mobileNumber.'&amount='.$amount.'&xref='.$nonce;
        $signature = $this->sign($nonce.$queryString);
        $headers = [
            'ClientId: '.$this->username,
            'Signature: '.$signature,
            'Nonce: '.$nonce
        ];
        $api = '/data/Credit';
        $this->request = new Request('GET', $this->baseUrl.$api, $headers);


        try {
            $response = $this->client->send($this->request, [
                'query' => [
                    'net' => $mobileNetwork,
                    'msisdn' => $mobileNumber,
                    'amount' => $amount,
                    'xref' => $nonce,
                ],
            ]);

            $response = json_decode($response->getBody()->getContents(), true);
            $this->response = $response;

            return $response ? true : false;
        } catch (ClientException $e) {
            $this->httpError = $e;

            return false;
        } catch (\Exception $e) {
            $this->httpError = $e;

            return false;
        }
    }

    /**
     * @inheritDoc
     */
    public function payUtility($smartCardNumber, $cableTv, $package, $callBackUrl): bool
    {
        return false;
    }
}