SmsLive247::send() - Code Metrics - Inspection of "Infobip driver" - djunehor/laravel-sms - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#4)

unknown

created 2021-02-26 09:23 UTC

SmsLive247::send() B

↳ Parent: SmsLive247

Complexity

Conditions	7
Paths	36

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	63
c	0
b	0
f	0
rs	7.8739
cc	7
nc	36
nop	1

How to fix Long Method

<?php
/**
 * Created by PhpStorm.
 * User: Djunehor
 * Date: 5/25/2019
 * Time: 5:51 PM.
 */

namespace Djunehor\Sms\App\Drivers;

use GuzzleHttp\Exception\ClientException;
use GuzzleHttp\Psr7\Request;

class SmsLive247 extends Sms
{
    private $baseUrl = 'http://www.smslive247.com/http/';
    private $messageType = false;

    /**
     * Class Constructor.
     *
     * @param null $message
     */
    public function __construct($message = null)
    {
        $this->username = config('laravel-sms.smslive247.token');

        if ($message) {
            $this->text($message);
        }

        $this->client = self::getInstance();
        $this->request = new Request('GET', $this->baseUrl.'index.aspx');
    }

    public function type(bool $type): self
    {
        $this->messageType = $type;

        return $this;
    }

    /**
     * @param null $text
     * @return bool
     */
    public function send($text = null): bool
    {
        if ($text) {
            $this->setText($text);
        }

        // get sessionID

        try {
            $response = $this->client->send($this->request, [
                'query' => [
                    'cmd' => 'login',
                    'owner_email' => config('laravel-sms.smslive247.owner_email'),
                    'subacct' => config('laravel-sms.smslive247.subacct_username'),
                    'subacctpwd' => config('laravel-sms.smslive247.subacct_password'),
                ],
            ]);

            $response = json_decode($response->getBody()->getContents(), true);

            $split = explode(':', $response);

            if ($split[0] == 'OK' && isset($split[1])) {
                $sessionId = trim($split[1]);
            } else {
                $this->response = last($split);

                return false;
            }
        } catch (\Exception $exception) {
            $this->httpError = $exception;

            return false;
        }
        try {
            $response = $this->client->send($this->request, [
                'query' => [
                    'cmd' => 'sendmsg',
                    'sessionid' => $sessionId,
                    'sendto' => implode(',', $this->recipients),
                    'sender' => $this->sender ?? config('laravel-sms.sender'),
                    'message' => $this->text,
                    'msgtype' => (int) $this->messageType,
                ],
            ]);

            $response = json_decode($response->getBody()->getContents(), true);
            $split = explode(':', $response);
            $this->response = last($split);

            return $split[0] == 'OK';
        } catch (ClientException $e) {
            logger()->error('HTTP Exception in '.__CLASS__.': '.__METHOD__.'=>'.$e->getMessage());
            $this->httpError = $e;

            return false;
        } catch (\Exception $e) {
            logger()->error('SMS Exception in '.__CLASS__.': '.__METHOD__.'=>'.$e->getMessage());
            $this->httpError = $e;

            return false;
        }
    }
}


1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: Djunehor
5			* Date: 5/25/2019
6			* Time: 5:51 PM.
7			*/
8
9			namespace Djunehor\Sms\App\Drivers;
10
11			use GuzzleHttp\Exception\ClientException;
12			use GuzzleHttp\Psr7\Request;
13
14			class SmsLive247 extends Sms
15			{
16			private $baseUrl = 'http://www.smslive247.com/http/';
17			private $messageType = false;
18
19			/**
20			* Class Constructor.
21			*
22			* @param null $message
23			*/
24			public function __construct($message = null)
25			{
26			$this->username = config('laravel-sms.smslive247.token');
27
28			if ($message) {
29			$this->text($message);
30			}
31
32			$this->client = self::getInstance();
33			$this->request = new Request('GET', $this->baseUrl.'index.aspx');
34			}
35
36			public function type(bool $type): self
37			{
38			$this->messageType = $type;
39
40			return $this;
41			}
42
43			/**
44			* @param null $text
45			* @return bool
46			*/
47			public function send($text = null): bool
48			{
49			if ($text) {
50			$this->setText($text);
51			}
52
53			// get sessionID
54
55			try {
56			$response = $this->client->send($this->request, [
57			'query' => [
58			'cmd' => 'login',
59			'owner_email' => config('laravel-sms.smslive247.owner_email'),
60			'subacct' => config('laravel-sms.smslive247.subacct_username'),
61			'subacctpwd' => config('laravel-sms.smslive247.subacct_password'),
62			],
63			]);
64
65			$response = json_decode($response->getBody()->getContents(), true);
66
67			$split = explode(':', $response);
68
69			if ($split[0] == 'OK' && isset($split[1])) {
70			$sessionId = trim($split[1]);
71			} else {
72			$this->response = last($split);
73
74			return false;
75			}
76			} catch (\Exception $exception) {
77			$this->httpError = $exception;
78
79			return false;
80			}
81			try {
82			$response = $this->client->send($this->request, [
83			'query' => [
84			'cmd' => 'sendmsg',
85			'sessionid' => $sessionId,
86			'sendto' => implode(',', $this->recipients),
87			'sender' => $this->sender ?? config('laravel-sms.sender'),
88			'message' => $this->text,
89			'msgtype' => (int) $this->messageType,
90			],
91			]);
92
93			$response = json_decode($response->getBody()->getContents(), true);
94			$split = explode(':', $response);
95			$this->response = last($split);
96
97			return $split[0] == 'OK';
98			} catch (ClientException $e) {
99			logger()->error('HTTP Exception in '.__CLASS__.': '.__METHOD__.'=>'.$e->getMessage());
100			$this->httpError = $e;
101
102			return false;
103			} catch (\Exception $e) {
104			logger()->error('SMS Exception in '.__CLASS__.': '.__METHOD__.'=>'.$e->getMessage());
105			$this->httpError = $e;
106
107			return false;
108			}
109			}
110			}
111

djunehor / laravel-sms

Pull Request — master (#4)

SmsLive247::send() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like