HashHmacTest::testCompareHash() - Code Metrics - Inspection of "updated namespace and CI config." - djsmithme/Authenticate - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 7e5dab...fc366b )

by Dan

created 2017-03-13 16:54 UTC

HashHmacTest::testCompareHash() A

↳ Parent: HashHmacTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	5
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	0

<?php

namespace Tests\Authenticate;

use Ds\Authenticate\HashHmac;

class HashHmacTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var HashHmac
     */
    public $auth;
    
    public $reflector;

    public $algo;

    public $data;

    /**
     * @var HashHmac
     */
    public $hmac;

    protected function setUp()
    {

        $this->auth = new HashHmac('privateKey');
        $this->reflector = new \ReflectionClass(HashHmac::class);

        $this->algo = 'sha512';
        $this->data = ['foo' => 'bar'];
        $this->privateKey = 'privateKey';
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $this->hmac = new HashHmac($this->privateKey,$this->algo);

    }

    public function testHash()
    {
        $actual = $this->hmac->create($this->algo, $this->data, $this->privateKey);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $expected = hash_hmac($this->algo, json_encode($this->data) , $this->privateKey);
        $result = $this->hmac->verify($actual, $expected);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertEquals(true, $result);
    }

    public function testCompareHash()
    {
        $encodedHash = $this->hmac->getEncodedHash($this->data);

        $this->assertEquals(true, $this->auth->compareHash($encodedHash,$this->data));

    }

    public function testCompareHashInvalidAlgo()
    {
        $this->setExpectedException('Exception');

        $hash = 'shafoo2=647a6cbf9b30cb8cc3fd5147a8fd30a19775fe3290e3dd0e729ae2f1e8a485f833469df616374fa923fcc3533545a11e6deba25a63bcd1ec81c316c090890ddc=10f3e8ed9c5c8b33cadda267882fa6449f5af465bc1dc420=1457010889';
        $encoded = base64_encode($hash);
        $this->auth->compareHash($encoded, $this->data);

    }

    public function testCompareHashNonMatch()
    {

        $this->setExpectedException('Exception');

        $encodedHash = $this->hmac->getEncodedHash($this->data);

        $differentPayload = ['foos' => 'bat'];
        $this->auth->compareHash($encodedHash, $differentPayload);

    }

    public function testVerify()
    {
        $hash1 = hash_hmac($this->algo, json_encode($this->data), 'key');
        $hash2 = hash_hmac($this->algo, json_encode($this->data), 'key');

        $expected = true;
        $actual = $this->hmac->verify($hash1, $hash2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->assertEquals($expected, $actual);
    }

    public function testVerifyHashWrongKey()

    {

        $this->setExpectedException('Exception');

        $hash1 = hash_hmac($this->algo, json_encode($this->data), 'key');
        $hash2 = hash_hmac($this->algo, json_encode($this->data), 'key2');
        $this->hmac->verify($hash1, $hash2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testVerifyHashNotString()
    {
        $this->setExpectedException('Exception');

        $hash1 = 23809.123;
        $hash2 = 23809.123;
        $this->hmac->verify($hash1, $hash2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testVerifyHashWrongData()

    {
        $this->setExpectedException('Exception');

        $data = md5('someOtherStuff');
        $hash1 = hash_hmac($this->algo, json_encode($this->data), 'key');
        $hash2 = hash_hmac($this->algo, $data, 'key');
        $this->hmac->verify($hash1, $hash2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testGetPrivateKey()
    {
        $expected = 'privateKey';
        $actual = $this->auth->getPrivateKey();
        $this->assertEquals($expected, $actual);
    }

    public function testSetPrivateKey()
    {
        $expected = 'newKey';
        $newKey = $this->auth->setPrivateKey($expected);

        $this->assertEquals($expected, $newKey->getPrivateKey());
    }

    public function testGetAlgorithm()
    {
        $expected = 'sha512';
        $actual = $this->auth->getAlgorithm();
        $this->assertEquals($expected, $actual);
    }

    public function testVerifyAlgorithm()
    {
        $method = $this->reflector->getMethod('verifyAlgorithm');
        $method->setAccessible(true);
        $actual = $method->invokeArgs($this->auth, ['sha256']);
        $this->assertEquals($actual, 'sha256');
    }

    public function testVerifyAlgorithmException()
    {
        $this->setExpectedException('Exception');


        $method = $this->reflector->getMethod('verifyAlgorithm');
        $method->setAccessible(true);
        $method->invokeArgs($this->auth, ['sha111']);
    }

}


1		<?php
2
3		namespace Tests\Authenticate;
4
5		use Ds\Authenticate\HashHmac;
6
7		class HashHmacTest extends \PHPUnit_Framework_TestCase
8		{
9		/**
10		* @var HashHmac
11		*/
12		public $auth;
13
14		public $reflector;
15
16		public $algo;
17
18		public $data;
19
20		/**
21		* @var HashHmac
22		*/
23		public $hmac;
24
25		protected function setUp()
26		{
27
28		$this->auth = new HashHmac('privateKey');
29		$this->reflector = new \ReflectionClass(HashHmac::class);
30
31		$this->algo = 'sha512';
32		$this->data = ['foo' => 'bar'];
33		$this->privateKey = 'privateKey';
		0 ignored issues – show Bug introduced 2016-04-25 13:20 UTC by Report Bug Copy Issue Report The property `privateKey` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
34
35		$this->hmac = new HashHmac($this->privateKey,$this->algo);
36
37		}
38
39		public function testHash()
40		{
41		$actual = $this->hmac->create($this->algo, $this->data, $this->privateKey);
		0 ignored issues – show Documentation introduced 2017-03-13 17:01 UTC by Report Bug Copy Issue Report `$this->algo` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Unused Code introduced 2017-03-13 17:01 UTC by Report Bug Copy Issue Report The call to `HashHmac::create()` has too many arguments starting with `$this->data`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
42		$expected = hash_hmac($this->algo, json_encode($this->data) , $this->privateKey);
43		$result = $this->hmac->verify($actual, $expected);
		0 ignored issues – show Documentation introduced 2017-03-13 17:01 UTC by Report Bug Copy Issue Report `$expected` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
44		$this->assertEquals(true, $result);
45		}
46
47		public function testCompareHash()
48		{
49		$encodedHash = $this->hmac->getEncodedHash($this->data);
		0 ignored issues – show Bug introduced 2017-03-13 17:01 UTC by Report Bug Copy Issue Report The method `getEncodedHash()` does not seem to exist on `object<Ds\Authenticate\HashHmac>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
50		$this->assertEquals(true, $this->auth->compareHash($encodedHash,$this->data));
		0 ignored issues – show Bug introduced 2017-03-13 17:01 UTC by Report Bug Copy Issue Report The method `compareHash()` does not seem to exist on `object<Ds\Authenticate\HashHmac>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
51		}
52
53		public function testCompareHashInvalidAlgo()
54		{
55		$this->setExpectedException('Exception');
		0 ignored issues – show Deprecated Code introduced 2016-04-21 14:34 UTC by Report Bug Copy Issue Report The method `PHPUnit_Framework_TestCase::setExpectedException()` has been deprecated with message: Method deprecated since Release 5.2.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
56		$hash = 'shafoo2=647a6cbf9b30cb8cc3fd5147a8fd30a19775fe3290e3dd0e729ae2f1e8a485f833469df616374fa923fcc3533545a11e6deba25a63bcd1ec81c316c090890ddc=10f3e8ed9c5c8b33cadda267882fa6449f5af465bc1dc420=1457010889';
57		$encoded = base64_encode($hash);
58		$this->auth->compareHash($encoded, $this->data);
		0 ignored issues – show Bug introduced 2017-03-13 17:01 UTC by Report Bug Copy Issue Report The method `compareHash()` does not seem to exist on `object<Ds\Authenticate\HashHmac>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
59		}
60
61		public function testCompareHashNonMatch()
62		{
63
64		$this->setExpectedException('Exception');
		0 ignored issues – show Deprecated Code introduced 2016-04-21 14:34 UTC by Report Bug Copy Issue Report The method `PHPUnit_Framework_TestCase::setExpectedException()` has been deprecated with message: Method deprecated since Release 5.2.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
65		$encodedHash = $this->hmac->getEncodedHash($this->data);
		0 ignored issues – show Bug introduced 2017-03-13 17:01 UTC by Report Bug Copy Issue Report The method `getEncodedHash()` does not seem to exist on `object<Ds\Authenticate\HashHmac>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
66		$differentPayload = ['foos' => 'bat'];
67		$this->auth->compareHash($encodedHash, $differentPayload);
		0 ignored issues – show Bug introduced 2017-03-13 17:01 UTC by Report Bug Copy Issue Report The method `compareHash()` does not seem to exist on `object<Ds\Authenticate\HashHmac>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
68		}
69
70		public function testVerify()
71		{
72		$hash1 = hash_hmac($this->algo, json_encode($this->data), 'key');
73		$hash2 = hash_hmac($this->algo, json_encode($this->data), 'key');
74
75		$expected = true;
76		$actual = $this->hmac->verify($hash1, $hash2);
		0 ignored issues – show Documentation introduced 2017-03-13 17:01 UTC by Report Bug Copy Issue Report `$hash2` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
77
78		$this->assertEquals($expected, $actual);
79		}
80
81	View Code Duplication	public function testVerifyHashWrongKey()
		0 ignored issues – show Duplication introduced 2016-04-21 14:34 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
82		{
83
84		$this->setExpectedException('Exception');
		0 ignored issues – show Deprecated Code introduced 2016-04-25 13:20 UTC by Report Bug Copy Issue Report The method `PHPUnit_Framework_TestCase::setExpectedException()` has been deprecated with message: Method deprecated since Release 5.2.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
85		$hash1 = hash_hmac($this->algo, json_encode($this->data), 'key');
86		$hash2 = hash_hmac($this->algo, json_encode($this->data), 'key2');
87		$this->hmac->verify($hash1, $hash2);
		0 ignored issues – show Documentation introduced 2017-03-13 17:01 UTC by Report Bug Copy Issue Report `$hash2` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
88		}
89
90		public function testVerifyHashNotString()
91		{
92		$this->setExpectedException('Exception');
		0 ignored issues – show Deprecated Code introduced 2016-04-21 14:34 UTC by Report Bug Copy Issue Report The method `PHPUnit_Framework_TestCase::setExpectedException()` has been deprecated with message: Method deprecated since Release 5.2.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
93		$hash1 = 23809.123;
94		$hash2 = 23809.123;
95		$this->hmac->verify($hash1, $hash2);
		0 ignored issues – show Documentation introduced 2017-03-13 17:01 UTC by Report Bug Copy Issue Report `$hash2` is of type `double`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
96		}
97
98	View Code Duplication	public function testVerifyHashWrongData()
		0 ignored issues – show Duplication introduced 2016-04-25 13:34 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
99		{
100		$this->setExpectedException('Exception');
		0 ignored issues – show Deprecated Code introduced 2016-04-25 13:20 UTC by Report Bug Copy Issue Report The method `PHPUnit_Framework_TestCase::setExpectedException()` has been deprecated with message: Method deprecated since Release 5.2.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
101		$data = md5('someOtherStuff');
102		$hash1 = hash_hmac($this->algo, json_encode($this->data), 'key');
103		$hash2 = hash_hmac($this->algo, $data, 'key');
104		$this->hmac->verify($hash1, $hash2);
		0 ignored issues – show Documentation introduced 2017-03-13 17:01 UTC by Report Bug Copy Issue Report `$hash2` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
105		}
106
107		public function testGetPrivateKey()
108		{
109		$expected = 'privateKey';
110		$actual = $this->auth->getPrivateKey();
111		$this->assertEquals($expected, $actual);
112		}
113
114		public function testSetPrivateKey()
115		{
116		$expected = 'newKey';
117		$newKey = $this->auth->setPrivateKey($expected);
		0 ignored issues – show Bug introduced 2017-03-13 17:01 UTC by Report Bug Copy Issue Report The method `setPrivateKey()` does not seem to exist on `object<Ds\Authenticate\HashHmac>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
118		$this->assertEquals($expected, $newKey->getPrivateKey());
119		}
120
121		public function testGetAlgorithm()
122		{
123		$expected = 'sha512';
124		$actual = $this->auth->getAlgorithm();
125		$this->assertEquals($expected, $actual);
126		}
127
128		public function testVerifyAlgorithm()
129		{
130		$method = $this->reflector->getMethod('verifyAlgorithm');
131		$method->setAccessible(true);
132		$actual = $method->invokeArgs($this->auth, ['sha256']);
133		$this->assertEquals($actual, 'sha256');
134		}
135
136		public function testVerifyAlgorithmException()
137		{
138		$this->setExpectedException('Exception');
		0 ignored issues – show Deprecated Code introduced 2016-04-21 14:34 UTC by Report Bug Copy Issue Report The method `PHPUnit_Framework_TestCase::setExpectedException()` has been deprecated with message: Method deprecated since Release 5.2.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
139
140		$method = $this->reflector->getMethod('verifyAlgorithm');
141		$method->setAccessible(true);
142		$method->invokeArgs($this->auth, ['sha111']);
143		}
144
145		}
146

djsmithme / Authenticate

Push — master ( 7e5dab...fc366b )

HashHmacTest::testCompareHash() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like