EditorAjaxRepository::getLatestLibraryVersions() - Code Metrics - Inspection of "Update EditorAjaxRepository.php" - djoudi/Laravel-H5P - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 99fe23...c01d37 )

by Abdelouahab

created 2019-07-22 13:01 UTC

EditorAjaxRepository::getLatestLibraryVersions() A

↳ Parent: EditorAjaxRepository

Complexity

Conditions	2
Paths	2

Size

Total Lines	23
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
cc	2
eloc	16
c	1
b	1
f	0
nc	2
nop	0
dl	0
loc	23
rs	9.7333

<?php

/*
 *
 * @Project
 * @Copyright      Djoudi
 * @Created        2018-02-13
 * @Filename       EditorAjaxRepogitory.php
 * @Description
 *
 */

namespace Djoudi\LaravelH5p\Repositories;

use DB;
use Djoudi\LaravelH5p\Eloquents\H5pLibrariesHubCache;
use H5PEditorAjaxInterface;
use Illuminate\Support\Facades\Auth;

class EditorAjaxRepository implements H5PEditorAjaxInterface
{

    public function getAuthorsRecentlyUsedLibraries()
    {
        // Get latest version of local libraries
        $major_versions_sql = 'SELECT hl.name,
                MAX(hl.major_version) AS majorVersion
           FROM h5p_libraries hl
          WHERE hl.runnable = 1
       GROUP BY hl.name';

        $minor_versions_sql = "SELECT hl2.name,
                 hl2.majorVersion,
                 MAX(hl2.minorVersion) AS minorVersion
            FROM ({$major_versions_sql}) hl1
            JOIN h5p_libraries hl2
              ON hl1.name = hl2.name
             AND hl1.majorVersion = hl2.majorVersion
        GROUP BY hl2.name, hl2.majorVersion";

        return DB::select("SELECT hl4.id,
                hl4.name AS machine_name,
                hl4.major_version,
                hl4.minor_version,
                hl4.patch_version,
                hl4.restricted,
                hl4.has_icon
           FROM ({$minor_versions_sql}) hl3
           JOIN h5p_libraries hl4
             ON hl3.name = hl4.name
            AND hl3.major_version = hl4.major_version
            AND hl3.minor_version = hl4.minor_version
       GROUP BY hl4.name, hl4.major_version, hl4.minor_version");
    }

    public function getContentTypeCache($machineName = null)
    {
        $where = H5pLibrariesHubCache::select();
        if ($machineName) {
            return $where->where('machine_name', $machineName)->pluck('id', 'is_recommended');
        } else {
            return $where->where('machine_name', $machineName)->get();
        }
    }

    public function getLatestLibraryVersions()
    {
        $recently_used = [];
        $result = DB::table('h5p_events')
            ->select([
                'library_name',
                'max(created_at) AS max_created_at',
            ])
            ->where('type', 'content')
            ->where('sub_type', 'create')
            ->where('user_id', Auth::id())
            ->groupBy('library_name')
            ->orderBy('max_created_at', 'DESC')
            ->get();

        foreach ($result as $row) {
            $recently_used[] = $row->library_name;
        }

        dd($recently_used);
        exit;


        return $recently_used;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }

    public function validateEditorToken($token)
    {
        // return (Helpers::nonce($token) == 'h5p_editor_ajax');
        return true;
    }

    public function getTranslations($libraries, $language_code){}
}


1			<?php
2
3			/*
4			*
5			* @Project
6			* @Copyright Djoudi
7			* @Created 2018-02-13
8			* @Filename EditorAjaxRepogitory.php
9			* @Description
10			*
11			*/
12
13			namespace Djoudi\LaravelH5p\Repositories;
14
15			use DB;
16			use Djoudi\LaravelH5p\Eloquents\H5pLibrariesHubCache;
17			use H5PEditorAjaxInterface;
18			use Illuminate\Support\Facades\Auth;
19
20			class EditorAjaxRepository implements H5PEditorAjaxInterface
21			{
22
23			public function getAuthorsRecentlyUsedLibraries()
24			{
25			// Get latest version of local libraries
26			$major_versions_sql = 'SELECT hl.name,
27			MAX(hl.major_version) AS majorVersion
28			FROM h5p_libraries hl
29			WHERE hl.runnable = 1
30			GROUP BY hl.name';
31
32			$minor_versions_sql = "SELECT hl2.name,
33			hl2.majorVersion,
34			MAX(hl2.minorVersion) AS minorVersion
35			FROM ({$major_versions_sql}) hl1
36			JOIN h5p_libraries hl2
37			ON hl1.name = hl2.name
38			AND hl1.majorVersion = hl2.majorVersion
39			GROUP BY hl2.name, hl2.majorVersion";
40
41			return DB::select("SELECT hl4.id,
42			hl4.name AS machine_name,
43			hl4.major_version,
44			hl4.minor_version,
45			hl4.patch_version,
46			hl4.restricted,
47			hl4.has_icon
48			FROM ({$minor_versions_sql}) hl3
49			JOIN h5p_libraries hl4
50			ON hl3.name = hl4.name
51			AND hl3.major_version = hl4.major_version
52			AND hl3.minor_version = hl4.minor_version
53			GROUP BY hl4.name, hl4.major_version, hl4.minor_version");
54			}
55
56			public function getContentTypeCache($machineName = null)
57			{
58			$where = H5pLibrariesHubCache::select();
59			if ($machineName) {
60			return $where->where('machine_name', $machineName)->pluck('id', 'is_recommended');
61			} else {
62			return $where->where('machine_name', $machineName)->get();
63			}
64			}
65
66			public function getLatestLibraryVersions()
67			{
68			$recently_used = [];
69			$result = DB::table('h5p_events')
70			->select([
71			'library_name',
72			'max(created_at) AS max_created_at',
73			])
74			->where('type', 'content')
75			->where('sub_type', 'create')
76			->where('user_id', Auth::id())
77			->groupBy('library_name')
78			->orderBy('max_created_at', 'DESC')
79			->get();
80
81			foreach ($result as $row) {
82			$recently_used[] = $row->library_name;
83			}
84
85			dd($recently_used);
86			exit;
			0 ignored issues – show Best Practice introduced 2019-03-05 19:39 UTC by Report Bug Copy Issue Report Using `exit` here is not recommended. In general, usage of exit should be done with care and only when running in a scripting context like a CLI script. Loading history...
87
88			return $recently_used;
			0 ignored issues – show Unused Code introduced 2019-03-05 19:39 UTC by Report Bug Copy Issue Report `return $recently_used` is not reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
89			}
90
91			public function validateEditorToken($token)
92			{
93			// return (Helpers::nonce($token) == 'h5p_editor_ajax');
94			return true;
95			}
96
97			public function getTranslations($libraries, $language_code){}
98			}
99

djoudi / Laravel-H5P

Push — master ( 99fe23...c01d37 )

EditorAjaxRepository::getLatestLibraryVersions() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like