Djoudi\LaravelH5p\Http\Controllers\H5pController

Complexity

Total Complexity

39

Size/Duplication

Total Lines	334
Duplicated Lines	0 %

Importance

Changes	4
Bugs	1	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
B	handle_upload()	0	45	9
A	destroy()	0	7	2
B	update()	0	84	9
A	show()	0	16	1
A	edit()	0	26	3
A	get_disabled_content_features()	0	9	1
A	index()	0	21	5
A	create()	0	20	1
B	store()	0	85	8

<?php

namespace Djoudi\LaravelH5p\Http\Controllers;

use App\Http\Controllers\Controller;

The type App\Http\Controllers\Controller was not found. Maybe you did not declare it correctly or list all dependencies?

use Djoudi\LaravelH5p\Eloquents\H5pContent;
use Djoudi\LaravelH5p\Events\H5pEvent;
use H5pCore;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\App;
use Illuminate\Support\Facades\Auth;

class H5pController extends Controller
{
    public function index(Request $request)
    {
        $where = H5pContent::orderBy('h5p_contents.id', 'desc');

        if ($request->query('sf') && $request->query('s')) {
            if ($request->query('sf') == 'title') {
                $where->where('h5p_contents.title', $request->query('s'));
            }
            if ($request->query('sf') == 'creator') {
                $where->leftJoin('users', 'users.id', 'h5p_contents.user_id')->where('users.name', 'like', '%'.$request->query('s').'%');

Are you sure $request->query('s') of type array|null|string can be used in concatenation?

            }
        }

        $search_fields = [
            'title'   => trans('laravel-h5p.content.title'),
            'creator' => trans('laravel-h5p.content.creator'),
        ];
        $entrys = $where->paginate(10);
        $entrys->appends(['sf' => $request->query('sf'), 's' => $request->query('s')]);

        return view('h5p.content.index', compact('entrys', 'request', 'search_fields'));
    }

    public function create(Request $request)
    {
        $h5p = App::make('LaravelH5p');
        $core = $h5p::$core;

        // Prepare form
        $library = 0;
        $parameters = '{}';

        $display_options = $core->getDisplayOptionsForEdit(null);

        // view Get the file and settings to print from
        $settings = $h5p::get_editor();

        // create event dispatch
        event(new H5pEvent('content', 'new'));

        $user = Auth::user();

        return view('h5p.content.create', compact('settings', 'user', 'library', 'parameters', 'display_options'));
    }

    public function store(Request $request)
    {
        $h5p = App::make('LaravelH5p');
        $core = $h5p::$core;
        $editor = $h5p::$h5peditor;

        $this->validate($request, [
            'title'  => 'required|max:250',
            'action' => 'required',
        ], [], [
            'title'  => trans('laravel-h5p.content.title'),
            'action' => trans('laravel-h5p.content.action'),
        ]);

        $oldLibrary = null;
        $oldParams = null;
        $event_type = 'create';
        $content = [
            'disable'    => H5PCore::DISABLE_NONE,
            'user_id'    => Auth::id(),
            'title'      => $request->get('title'),
            'embed_type' => 'div',
            'filtered'   => '',
            'slug'       => config('laravel-h5p.slug'),
        ];

        $content['filtered'] = '';

        try {
            if ($request->get('action') === 'create') {
                $content['library'] = $core->libraryFromString($request->get('library'));
                if (!$content['library']) {
                    throw new H5PException('Invalid library.');

The type Djoudi\LaravelH5p\Http\Controllers\H5PException was not found. Maybe you did not declare it correctly or list all dependencies?

                }

                // Check if library exists.
                $content['library']['libraryId'] = $core->h5pF->getLibraryId($content['library']['machineName'], $content['library']['majorVersion'], $content['library']['minorVersion']);
                if (!$content['library']['libraryId']) {
                    throw new H5PException('No such library');
                }
                //old
                // $content['params'] = $request->get('parameters');
                // $params = json_decode($content['params']);

                //new
                $params = json_decode($request->get('parameters'));
                $content['params'] = json_encode($params->params);
                if ($params === null) {
                    throw new H5PException('Invalid parameters');
                }

                // Set disabled features
                $this->get_disabled_content_features($core, $content);

                // Save new content
                $content['id'] = $core->saveContent($content);

                // Move images and find all content dependencies
                $editor->processParameters($content['id'], $content['library'], $params, $oldLibrary, $oldParams);

                event(new H5pEvent('content', $event_type, $content['id'], $content['title'], $content['library']['machineName'], $content['library']['majorVersion'], $content['library']['minorVersion']));

The call to Djoudi\LaravelH5p\Events\H5pEvent::__construct() has too many arguments starting with $content['library']['minorVersion'].

                $return_id = $content['id'];
            } elseif ($request->get('action') === 'upload') {
                $content['uploaded'] = true;

                $this->get_disabled_content_features($core, $content);

                // Handle file upload
                $return_id = $this->handle_upload($content);
            }

            if ($return_id) {

The variable $return_id does not seem to be defined for all execution paths leading up to this point.

                return redirect()
                    ->route('h5p.edit', $return_id)
                    ->with('success', trans('laravel-h5p.content.created'));
            } else {
                return redirect()
                    ->route('h5p.create')
                    ->with('fail', trans('laravel-h5p.content.can_not_created'));
            }
        } catch (H5PException $ex) {
            return redirect()
                ->route('h5p.create')
                ->with('fail', trans('laravel-h5p.content.can_not_created'));
        }
    }

    public function edit(Request $request, $id)
    {
        $h5p = App::make('LaravelH5p');
        $core = $h5p::$core;
        $editor = $h5p::$h5peditor;

The assignment to $editor is dead and can be removed.

        $settings = $h5p::get_core();
        $content = $h5p->get_content($id);
        $embed = $h5p->get_embed($content, $settings);
        $embed_code = $embed['embed'];

The assignment to $embed_code is dead and can be removed.

        $settings = $embed['settings'];

The assignment to $settings is dead and can be removed.

        // Prepare form
        $library = $content['library'] ? H5PCore::libraryToString($content['library']) : 0;
        $parameters = $content['params'] ? $content['params'] : '{}';
        $display_options = $core->getDisplayOptionsForEdit($content['disable']);

        // view Get the file and settings to print from
        $settings = $h5p::get_editor($content);

        // create event dispatch
        event(new H5pEvent('content', 'edit', $content['id'], $content['title'], $content['library']['name'], $content['library']['majorVersion'].'.'.$content['library']['minorVersion']));

        $user = Auth::user();

        return view('h5p.content.edit', compact('settings', 'user', 'id', 'content', 'library', 'parameters', 'display_options'));
    }

    public function update(Request $request, $id)
    {
        $h5p = App::make('LaravelH5p');
        $core = $h5p::$core;
        $editor = $h5p::$h5peditor;

        $this->validate($request, [
            'title'  => 'required|max:250',
            'action' => 'required',
        ], [], [
            'title'  => trans('laravel-h5p.content.title'),
            'action' => trans('laravel-h5p.content.action'),
        ]);

        $event_type = 'update';
        $content = $h5p::get_content($id);
        $content['embed_type'] = 'div';
        $content['user_id'] = Auth::id();
        $content['disable'] = $request->get('disable') ? $request->get('disable') : false;
        $content['title'] = $request->get('title');
        $content['filtered'] = '';

        $oldLibrary = $content['library'];
        $oldParams = json_decode($content['params']);

        try {
            if ($request->get('action') === 'create') {
                $content['library'] = $core->libraryFromString($request->get('library'));
                if (!$content['library']) {
                    throw new H5PException('Invalid library.');
                }

                // Check if library exists.
                $content['library']['libraryId'] = $core->h5pF->getLibraryId($content['library']['machineName'], $content['library']['majorVersion'], $content['library']['minorVersion']);
                if (!$content['library']['libraryId']) {
                    throw new H5PException('No such library');
                }

                //                $content['parameters'] = $request->get('parameters');
                //old
                //$content['params'] = $request->get('parameters');
                //$params = json_decode($content['params']);

                //new
                $params = json_decode($request->get('parameters'));
                $content['params'] = json_encode($params->params);
                if ($params === null) {
                    throw new H5PException('Invalid parameters');
                }

                // Set disabled features
                $this->get_disabled_content_features($core, $content);

                // Save new content
                $core->saveContent($content);

                // Move images and find all content dependencies
                $editor->processParameters($content['id'], $content['library'], $params, $oldLibrary, $oldParams);

                event(new H5pEvent('content', $event_type, $content['id'], $content['title'], $content['library']['machineName'], $content['library']['majorVersion'], $content['library']['minorVersion']));

The call to Djoudi\LaravelH5p\Events\H5pEvent::__construct() has too many arguments starting with $content['library']['minorVersion'].

                $return_id = $content['id'];
            } elseif ($request->get('action') === 'upload') {
                $content['uploaded'] = true;

                $this->get_disabled_content_features($core, $content);

                // Handle file upload
                $return_id = $this->handle_upload($content);
            }

            if ($return_id) {

The variable $return_id does not seem to be defined for all execution paths leading up to this point.

                return redirect()
                    ->route('h5p.edit', $return_id)
                    ->with('success', trans('laravel-h5p.content.updated'));
            } else {
                return redirect()
                    ->back()
                    ->with('fail', trans('laravel-h5p.content.can_not_updated'));
            }
        } catch (H5PException $ex) {
            return redirect()
                ->back()
                ->with('fail', trans('laravel-h5p.content.can_not_updated'));
        }
    }

    public function show(Request $request, $id)
    {
        $h5p = App::make('LaravelH5p');
        $core = $h5p::$core;

The assignment to $core is dead and can be removed.

        $settings = $h5p::get_editor();
        $content = $h5p->get_content($id);
        $embed = $h5p->get_embed($content, $settings);
        $embed_code = $embed['embed'];
        $settings = $embed['settings'];
        $title = $content['title'];

        // create event dispatch
        event(new H5pEvent('content', null, $content['id'], $content['title'], $content['library']['name'], $content['library']['majorVersion'], $content['library']['minorVersion']));

The call to Djoudi\LaravelH5p\Events\H5pEvent::__construct() has too many arguments starting with $content['library']['minorVersion'].

        //     return view('h5p.content.edit', compact("settings", 'user', 'id', 'content', 'library', 'parameters', 'display_options'));
        return view('h5p.content.show', compact('settings', 'user', 'embed_code', 'title'));
    }

    public function destroy(Request $request, $id)
    {
        try {
            $content = H5pContent::findOrFail($id);
            $content->delete();
        } catch (Exception $ex) {

The type Djoudi\LaravelH5p\Http\Controllers\Exception was not found. Did you mean Exception? If so, make sure to prefix the type with \.

            return trans('laravel-h5p.content.can_not_delete');
        }
    }

    private function get_disabled_content_features($core, &$content)
    {
        $set = [
            H5PCore::DISPLAY_OPTION_FRAME     => filter_input(INPUT_POST, 'frame', FILTER_VALIDATE_BOOLEAN),
            H5PCore::DISPLAY_OPTION_DOWNLOAD  => filter_input(INPUT_POST, 'download', FILTER_VALIDATE_BOOLEAN),
            H5PCore::DISPLAY_OPTION_EMBED     => filter_input(INPUT_POST, 'embed', FILTER_VALIDATE_BOOLEAN),
            H5PCore::DISPLAY_OPTION_COPYRIGHT => filter_input(INPUT_POST, 'copyright', FILTER_VALIDATE_BOOLEAN),
        ];
        $content['disable'] = $core->getStorableDisplayOptions($set, $content['disable']);
    }

    private function handle_upload($content = null, $only_upgrade = null, $disable_h5p_security = false)
    {
        $h5p = App::make('LaravelH5p');
        $core = $h5p::$core;
        $validator = $h5p::$validator;
        $interface = $h5p::$interface;
        $storage = $h5p::$storage;

        if ($disable_h5p_security) {
            // Make it possible to disable file extension check
            $core->disableFileCheck = (filter_input(INPUT_POST, 'h5p_disable_file_check', FILTER_VALIDATE_BOOLEAN) ? true : false);
        }

        // Move so core can validate the file extension.
        rename($_FILES['h5p_file']['tmp_name'], $interface->getUploadedH5pPath());

        $skipContent = ($content === null);

        if ($validator->isValidPackage($skipContent, $only_upgrade) && ($skipContent || $content['title'] !== null)) {
            if (function_exists('check_upload_size')) {
                // Check file sizes before continuing!
                $tmpDir = $interface->getUploadedH5pFolderPath();
                $error = self::check_upload_sizes($tmpDir);
                if ($error !== null) {
                    // Didn't meet space requirements, cleanup tmp dir.
                    $interface->setErrorMessage($error);
                    H5PCore::deleteFileTree($tmpDir);

                    return false;
                }
            }
            // No file size check errors
            if (isset($content['id'])) {
                $interface->deleteLibraryUsage($content['id']);
            }

            $storage->savePackage($content, null, $skipContent);

            // Clear cached value for dirsize.
            return $storage->contentId;
        }
        // The uploaded file was not a valid H5P package
        @unlink($interface->getUploadedH5pPath());

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

        return false;
    }
}