PathMiddleware::process() - Code Metrics - Inspection of "Performance Update" - divineniiquaye/flight-routing - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#16)

by Divine Niiquaye

created 2021-06-24 12:36 UTC

PathMiddleware::process() C

↳ Parent: PathMiddleware

Complexity

Conditions	13
Paths	48

Size

Total Lines	38
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	13

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	13
eloc	19
nc	48
nop	2
dl	0
loc	38
ccs	12
cts	12
cp	1
crap	13
rs	6.6166
c	2
b	0
f	0

How to fix Complexity

<?php

declare(strict_types=1);

/*
 * This file is part of Flight Routing.
 *
 * PHP version 7.1 and above required
 *
 * @author    Divine Niiquaye Ibok <[email protected]>
 * @copyright 2019 Biurad Group (https://biurad.com/)
 * @license   https://opensource.org/licenses/BSD-3-Clause License
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Flight\Routing\Middlewares;

use Flight\Routing\Route;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface;

/**
 * Resolves request uri path, route path, and response status.
 *
 * The response status code is 302 if the permanent parameter is false (default),
 * and 301 if the redirection is permanent on redirection.
 *
 * @author Divine Niiquaye Ibok <[email protected]>
 */
class PathMiddleware implements MiddlewareInterface
{
    /** @var bool */
    private $permanent;

    /** @var bool */
    private $keepRequestMethod;

    /**
     * @param bool $permanent         Whether the redirection is permanent
     * @param bool $keepRequestMethod Whether redirect action should keep HTTP request method
     */
    public function __construct(bool $permanent = false, bool $keepRequestMethod = false)
    {
        $this->permanent = $permanent;
        $this->keepRequestMethod = $keepRequestMethod;
    }

    /**
     * {@inheritdoc}
     */
    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        // Supported prefix for uri paths ...
        $prefixRegex = '#(?|\\' . \implode('|\\', Route::URL_PREFIX_SLASHES) . ')+$#';

        $requestUri = $request->getUri();
        $response = $handler->handle($request);
        $requestPath = \preg_replace($prefixRegex, $requestUri->getPath()[-1], $requestUri->getPath());

        // Determine the response code should keep HTTP request method ...
        $statusCode = $this->keepRequestMethod ? ($this->permanent ? 308 : 307) : ($this->permanent ? 301 : 302);

        if ($requestUri->getPath() !== $requestPath) {
            return $response->withHeader('Location', (string) $requestUri->withPath($requestPath))->withStatus($statusCode);
        }

        $route = $request->getAttribute(Route::class);

        if ($route instanceof Route) {
            $routeEndTail = Route::URL_PREFIX_SLASHES[$route->get('path')[-1]] ?? null;
            $requestEndTail = Route::URL_PREFIX_SLASHES[$requestPath[-1]] ?? null;

            if ($routeEndTail === $requestEndTail) {
                return $response;
            }

            // Resolve request tail end to avoid conflicts and infinite redirection looping ...
            if (null === $routeEndTail && null !== $requestEndTail || (isset($routeEndTail, $requestEndTail) && $routeEndTail !== $requestEndTail)) {

                $requestPath = \substr($requestPath, 0, -1);
            } elseif (null !== $routeEndTail && null === $requestEndTail) {
                $requestPath .= $routeEndTail;
            }

            // Allow Redirection if exists and avoid static request.
            return $response->withAddedHeader('Location', (string) $requestUri->withPath($requestPath))->withStatus($statusCode);
        }

        return $response;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		/*
6		* This file is part of Flight Routing.
7		*
8		* PHP version 7.1 and above required
9		*
10		* @author Divine Niiquaye Ibok <[email protected]>
11		* @copyright 2019 Biurad Group (https://biurad.com/)
12		* @license https://opensource.org/licenses/BSD-3-Clause License
13		*
14		* For the full copyright and license information, please view the LICENSE
15		* file that was distributed with this source code.
16		*/
17
18		namespace Flight\Routing\Middlewares;
19
20		use Flight\Routing\Route;
21		use Psr\Http\Message\ResponseInterface;
22		use Psr\Http\Message\ServerRequestInterface;
23		use Psr\Http\Server\MiddlewareInterface;
24		use Psr\Http\Server\RequestHandlerInterface;
25
26		/**
27		* Resolves request uri path, route path, and response status.
28		*
29		* The response status code is 302 if the permanent parameter is false (default),
30		* and 301 if the redirection is permanent on redirection.
31		*
32		* @author Divine Niiquaye Ibok <[email protected]>
33		*/
34	3	class PathMiddleware implements MiddlewareInterface
35		{
36	3	/** @var bool */
37	3	private $permanent;
38
39		/** @var bool */
40		private $keepRequestMethod;
41
42	3	/**
43		* @param bool $permanent Whether the redirection is permanent
44	3	* @param bool $keepRequestMethod Whether redirect action should keep HTTP request method
45	3	*/
46		public function __construct(bool $permanent = false, bool $keepRequestMethod = false)
47	3	{
48	3	$this->permanent = $permanent;
49		$this->keepRequestMethod = $keepRequestMethod;
50		}
51	3
52	2	/**
53	2	* {@inheritdoc}
54		*/
55		public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
56		{
57	1	// Supported prefix for uri paths ...
58		$prefixRegex = '#(?\|\\' . \implode('\|\\', Route::URL_PREFIX_SLASHES) . ')+$#';
59
60		$requestUri = $request->getUri();
61		$response = $handler->handle($request);
62		$requestPath = \preg_replace($prefixRegex, $requestUri->getPath()[-1], $requestUri->getPath());
63
64		// Determine the response code should keep HTTP request method ...
65		$statusCode = $this->keepRequestMethod ? ($this->permanent ? 308 : 307) : ($this->permanent ? 301 : 302);
66
67		if ($requestUri->getPath() !== $requestPath) {
68		return $response->withHeader('Location', (string) $requestUri->withPath($requestPath))->withStatus($statusCode);
69	3	}
70
71		$route = $request->getAttribute(Route::class);
72	3
73	3	if ($route instanceof Route) {
74		$routeEndTail = Route::URL_PREFIX_SLASHES[$route->get('path')[-1]] ?? null;
75	3	$requestEndTail = Route::URL_PREFIX_SLASHES[$requestPath[-1]] ?? null;
76	3
77	3	if ($routeEndTail === $requestEndTail) {
78		return $response;
79		}
80	3
81	1	// Resolve request tail end to avoid conflicts and infinite redirection looping ...
82		if (null === $routeEndTail && null !== $requestEndTail \|\| (isset($routeEndTail, $requestEndTail) && $routeEndTail !== $requestEndTail)) {
		0 ignored issues – show introduced 2021-06-12 08:08 UTC by Report Bug Copy Issue Report Consider adding parentheses for clarity. Current Interpretation: `(null === $routeEndTail ...ail !== $requestEndTail`, Probably Intended Meaning: `null === $routeEndTail &...il !== $requestEndTail)` Loading history...
83		$requestPath = \substr($requestPath, 0, -1);
84	2	} elseif (null !== $routeEndTail && null === $requestEndTail) {
85	1	$requestPath .= $routeEndTail;
86		}
87
88	1	// Allow Redirection if exists and avoid static request.
89		return $response->withAddedHeader('Location', (string) $requestUri->withPath($requestPath))->withStatus($statusCode);
90		}
91
92		return $response;
93		}
94		}
95

divineniiquaye / flight-routing

Pull Request — master (#16)

PathMiddleware::process() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like