Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
15 | class Boards extends Endpoint { |
||
16 | |||
17 | /** |
||
18 | * Find the provided board |
||
19 | * |
||
20 | * @access public |
||
21 | * @param string $board_id |
||
22 | * @param array $data |
||
23 | * @throws Exceptions/PinterestExceptions |
||
24 | * @return Board |
||
25 | */ |
||
26 | 2 | public function get($board_id, array $data = []) |
|
31 | |||
32 | /** |
||
33 | * Create a new board |
||
34 | * |
||
35 | * @access public |
||
36 | * @param array $data |
||
37 | * @throws Exceptions/PinterestExceptions |
||
38 | * @return Board |
||
39 | */ |
||
40 | 1 | public function create(array $data) |
|
45 | |||
46 | /** |
||
47 | * Edit a board |
||
48 | * |
||
49 | * @access public |
||
50 | * @param string $board_id |
||
51 | * @param array $data |
||
52 | * @param string $fields |
||
53 | * @throws Exceptions/PinterestExceptions |
||
54 | * @return Board |
||
55 | */ |
||
56 | 1 | View Code Duplication | public function edit($board_id, array $data, $fields = null) |
63 | |||
64 | /** |
||
65 | * Delete a board |
||
66 | * |
||
67 | * @access public |
||
68 | * @param string $board_id |
||
69 | * @throws Exceptions/PinterestExceptions |
||
70 | * @return boolean |
||
71 | */ |
||
72 | 1 | public function delete($board_id) |
|
77 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.