ClientRemote - Code Metrics - Inspection of "fix test file" - directus/directus-sdk-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — d64 ( df9164...be7046 )

by Welling

created 2016-11-20 08:31 UTC

ClientRemote A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	268
Duplicated Lines	7.46 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

42.39%

Importance

Changes

Metric	Value
dl	20
loc	268
ccs	39
cts	92
cp	0.4239
rs	10
c	0
b	0
f	0
wmc	29
lcom	1
cbo	3

25 Methods

Rating	Name	Duplication	Size	Complexity
A	getTables()	0	4	1
A	getTable()	0	6	1
A	getColumns()	0	6	1
A	getColumn()	0	6	1
A	getEntries()	0	6	1
A	getEntry()	0	6	1
A	getUsers()	0	4	1
A	getUser()	0	4	1
A	getGroups()	0	4	1
A	getGroup()	0	6	1
A	getGroupPrivileges()	0	6	1
A	getFiles()	0	4	1
A	getFile()	0	6	1
A	getSettings()	0	4	1
A	getSettingsByCollection()	0	6	1
A	getMessages()	0	6	1
A	createEntry()	0	6	1
A	updateEntry()	0	6	1
A	deleteEntry()	0	6	1
A	createUser()	10	10	2
A	updateUser()	10	10	2
A	deleteUser()	0	4	1
B	createFile()	0	32	3
A	updateFile()	0	4	1
A	deleteFile()	0	4	1

How to fix Duplicated Code

<?php

/**
 * Directus – <http://getdirectus.com>
 *
 * @link      The canonical repository – <https://github.com/directus/directus>
 * @copyright Copyright 2006-2016 RANGER Studio, LLC – <http://rangerstudio.com>
 * @license   GNU General Public License (v3) – <http://www.gnu.org/copyleft/gpl.html>
 */

namespace Directus\SDK;
use Directus\Util\ArrayUtils;
use Directus\Util\StringUtils;

/**
 * Client Remote
 *
 * @author Welling Guzmán <[email protected]>
 */
class ClientRemote extends BaseClientRemote
{
    /**
     * @inheritdoc
     */
    public function getTables(array $params = [])
    {
        return $this->performRequest('GET', static::TABLE_LIST_ENDPOINT);

    }

    /**
     * @inheritdoc
     */
    public function getTable($tableName)
    {
        $path = $this->buildPath(static::TABLE_INFORMATION_ENDPOINT, $tableName);

        return $this->performRequest('GET', $path);

    }

    /**
     * @inheritdoc
     */
    public function getColumns($tableName, array $params = [])
    {
        $path = $this->buildPath(static::COLUMN_LIST_ENDPOINT, $tableName);

        return $this->performRequest('GET', $path);

    }

    /**
     * @inheritdoc
     */
    public function getColumn($tableName, $columnName)
    {
        $path = $this->buildPath(static::COLUMN_INFORMATION_ENDPOINT, [$tableName, $columnName]);

        return $this->performRequest('GET', $path);

    }

    /**
     * @inheritdoc
     */
    public function getEntries($tableName, array $options = [])
    {
        $path = $this->buildPath(static::TABLE_ENTRIES_ENDPOINT, $tableName);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return $this->performRequest('GET', $path, ['query' => $options]);

    }

    /**
     * @inheritdoc
     */
    public function getEntry($tableName, $id, array $options = [])
    {
        $path = $this->buildPath(static::TABLE_ENTRY_ENDPOINT, [$tableName, $id]);

        return $this->performRequest('GET', $path, ['query' => $options]);

    }

    /**
     * @inheritdoc
     */
    public function getUsers(array $params = [])
    {
        return $this->getEntries('directus_users', $params);
    }

    /**
     * @inheritdoc
     */
    public function getUser($id, array $params = [])
    {
        return $this->getEntry($id, 'directus_users', $params);
    }

    /**
     * @inheritdoc
     */
    public function getGroups()
    {
        return $this->performRequest('GET', static::GROUP_LIST_ENDPOINT);

    }

    /**
     * @inheritdoc
     */
    public function getGroup($groupID)
    {
        $path = $this->buildPath(static::GROUP_INFORMATION_ENDPOINT, $groupID);

        return $this->performRequest('GET', $path);

    }

    /**
     * @inheritdoc
     */
    public function getGroupPrivileges($groupID)
    {
        $path = $this->buildPath(static::GROUP_PRIVILEGES_ENDPOINT, $groupID);

        return $this->performRequest('GET', $path);

    }

    /**
     * @inheritdoc
     */
    public function getFiles()
    {
        return $this->performRequest('GET', static::FILE_LIST_ENDPOINT);

    }

    /**
     * @inheritdoc
     */
    public function getFile($fileID)
    {
        $path = $this->buildPath(static::FILE_INFORMATION_ENDPOINT, $fileID);

        return $this->performRequest('GET', $path);

    }

    /**
     * @inheritdoc
     */
    public function getSettings()
    {
        return $this->performRequest('GET', static::SETTING_LIST_ENDPOINT);
    }

    /**
     * @inheritdoc
     */
    public function getSettingsByCollection($collectionName)
    {
        $path = $this->buildPath(static::SETTING_COLLECTION_ENDPOINT, $collectionName);

        return $this->performRequest('GET', $path);

    }

    /**
     * @inheritdoc
     */
    public function getMessages($userId)
    {
        $path = $this->buildPath(static::MESSAGES_USER_ENDPOINT, $userId);

        return $this->performRequest('GET', $path);

    }

    /**
     * @inheritdoc
     */
    public function createEntry($tableName, array $data)
    {
        $path = $this->buildPath(static::TABLE_ENTRY_CREATE_ENDPOINT, $tableName);

        return $this->performRequest('POST', $path, ['body' => $data]);

    }

    /**
     * @inheritdoc
     */
    public function updateEntry($tableName, $id, array $data)
    {
        $path = $this->buildPath(static::TABLE_ENTRY_UPDATE_ENDPOINT, [$tableName, $id]);

        return $this->performRequest('PUT', $path, ['body' => $data]);
    }

    /**
     * @inheritdoc
     */
    public function deleteEntry($tableName, $id)
    {
        $path = $this->buildPath(static::TABLE_ENTRY_DELETE_ENDPOINT, [$tableName, $id]);

        return $this->performRequest('DELETE', $path);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @inheritdoc
     */
    public function createUser(array $data)

    {
        // @TODO: Add hooks
        if (ArrayUtils::has($data, 'password')) {
            // @NOTE: Use Directus password hash
            $data['password'] = password_hash($data['password'], PASSWORD_DEFAULT, ['cost' => 12]);
        }

        return $this->createEntry('directus_users', $data);
    }

    /**
     * @inheritdoc
     */
    public function updateUser($id, array $data)

    {
        // @TODO: Add hooks
        if (ArrayUtils::has($data, 'password')) {
            // @NOTE: Use Directus password hash
            $data['password'] = password_hash($data['password'], PASSWORD_DEFAULT, ['cost' => 12]);
        }

        return $this->updateEntry('directus_users', $id, $data);
    }

    /**
     * @inheritdoc
     */
    public function deleteUser($ids)
    {
        return $this->deleteEntry('directus_users', $ids);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @inheritdoc
     */
    public function createFile(array $data)
    {
        $attributes = [];
        // @TODO: omit columns such id or user.
        // $data = ArrayUtils::omit($data, []);
        if (ArrayUtils::has($data, 'file')) {
            $path = $data['file'];
            $ext = pathinfo($path, PATHINFO_EXTENSION);
            $mimeType = mime_content_type($path);
            $attributes['name'] = pathinfo($path, PATHINFO_FILENAME) . '.' . $ext;
            $attributes['type'] = $mimeType;
            $content = file_get_contents($path);
            $base64 = 'data:' . $mimeType . ';base64,' . base64_encode($content);
            $attributes['data'] = $base64;
            unset($data['file']);
        } else if (ArrayUtils::has($data, 'data')) {
            $finfo = new \finfo(FILEINFO_MIME);
            list($mimeType, $charset) = explode('; charset=', $finfo->buffer($data['data']));
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
            $base64 = 'data:' . $mimeType . ';base64,' . base64_encode($data['data']);
            list($type, $subtype) = explode('/', $mimeType);
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
            $attributes['data'] = $base64;
            $attributes['type'] = $mimeType;
            $attributes['name'] = StringUtils::randomString() . '.' . $subtype;
            unset($data['data']);
        } else {
            throw new \Exception('Missing "file" or "data" attribute.');
        }

        $data = array_merge($data, $attributes);

        return $this->performRequest('POST', static::FILE_CREATE_ENDPOINT, ['body' => $data]);

    }

    /**
     * @inheritdoc
     */
    public function updateFile($id, array $data)
    {
        return $this->updateEntry('directus_files', $id, $data);
    }

    /**
     * @inheritdoc
     */
    public function deleteFile($id)
    {
        return $this->deleteEntry('directus_files', $id);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


1		<?php
2
3		/**
4		* Directus – <http://getdirectus.com>
5		*
6		* @link The canonical repository – <https://github.com/directus/directus>
7		* @copyright Copyright 2006-2016 RANGER Studio, LLC – <http://rangerstudio.com>
8		* @license GNU General Public License (v3) – <http://www.gnu.org/copyleft/gpl.html>
9		*/
10
11		namespace Directus\SDK;
12		use Directus\Util\ArrayUtils;
13		use Directus\Util\StringUtils;
14
15		/**
16		* Client Remote
17		*
18		* @author Welling Guzmán <[email protected]>
19		*/
20		class ClientRemote extends BaseClientRemote
21		{
22		/**
23		* @inheritdoc
24		*/
25	2	public function getTables(array $params = [])
26		{
27	2	return $this->performRequest('GET', static::TABLE_LIST_ENDPOINT);
		1 ignored issue – show Bug Compatibility introduced 2016-11-16 18:40 UTC by Report Bug Copy Issue Report The expression `$this->performRequest('G...::TABLE_LIST_ENDPOINT);` of type `Directus\SDK\Response\En...ctus\SDK\Response\Entry` adds the type `Directus\SDK\Response\Entry` to the return on line 27 which is incompatible with the return type declared by the interface `Directus\SDK\RequestsInterface::getTables` of type `Directus\SDK\Response\EntryCollection`. Loading history...
28		}
29
30		/**
31		* @inheritdoc
32		*/
33	4	public function getTable($tableName)
34		{
35	4	$path = $this->buildPath(static::TABLE_INFORMATION_ENDPOINT, $tableName);
36
37	4	return $this->performRequest('GET', $path);
		1 ignored issue – show Bug Compatibility introduced 2016-11-20 07:42 UTC by Report Bug Copy Issue Report The expression `$this->performRequest('GET', $path);` of type `Directus\SDK\Response\En...ctus\SDK\Response\Entry` adds the type `Directus\SDK\Response\EntryCollection` to the return on line 37 which is incompatible with the return type declared by the interface `Directus\SDK\RequestsInterface::getTable` of type `Directus\SDK\Response\Entry`. Loading history...
38		}

directus / directus-sdk-php

Push — d64 ( df9164...be7046 )

ClientRemote A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

25 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like