Directus\SDK\Response\EntryCollection

Complexity

Total Complexity

18

Size/Duplication

Total Lines	157
Duplicated Lines	6.37 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

75%

Importance

Changes	2
Bugs	0	Features	2

13 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	13	2
A	pickMetadata()	5	11	3
A	pickRows()	5	11	3
A	getRawData()	0	4	1
A	getData()	0	4	1
A	getMetaData()	0	4	1
A	getIterator()	0	4	1
A	offsetExists()	0	4	1
A	offsetGet()	0	4	1
A	offsetSet()	0	4	1
A	offsetUnset()	0	4	1
A	count()	0	4	1
A	jsonSerialize()	0	7	1

<?php

/**
 * Directus – <http://getdirectus.com>
 *
 * @link      The canonical repository – <https://github.com/directus/directus>
 * @copyright Copyright 2006-2016 RANGER Studio, LLC – <http://rangerstudio.com>
 * @license   GNU General Public License (v3) – <http://www.gnu.org/copyleft/gpl.html>
 */

namespace Directus\SDK\Response;

use Directus\Util\ArrayUtils;

/**
 * Entry Collection
 *
 * @author Welling Guzmán <welling@rngr.org>
 */
class EntryCollection implements ResponseInterface, \IteratorAggregate, \ArrayAccess, \Countable
{
    /**
     * @var array
     */
    protected $items = [];

    /**
     * @var array
     */
    protected $rawData = [];

    /**
     * @var array
     */
    protected $metadata = [];

    /**
     * EntryCollection constructor.
     *
     * @param $data
     */
    public function __construct($data)
    {
        $this->rawData = $data;
        $this->metadata = $this->pickMetadata($data);

It seems like $this->pickMetadata($data) can be null. However, the property $metadata is declared as array. Maybe change the type of the property to array|null or add a type check?

        $rows = $this->pickRows($data);
        $items = [];
        foreach($rows as $row) {
            $items[] = new Entry($row);
        }

        $this->items = $items;
    }

    /**
     * Pick the metadata out of the raw data
     *
     * @param $data
     *
     * @return array|null
     */
    protected function pickMetadata($data)
    {
        $metadata = null;
        if (ArrayUtils::has($data, 'rows')) {

This code seems to be duplicated across your project.

            $metadata = ArrayUtils::omit($data, 'rows');
        } else if (ArrayUtils::has($data, 'metadata')) {
            $metadata = ArrayUtils::get($data, 'metadata');
        }

        return $metadata;
    }

    /**
     * Pick the "rows" (items) out of the raw data
     *
     * @param $data
     *
     * @return array
     */
    protected function pickRows($data)
    {
        $rows = [];
        if (ArrayUtils::has($data, 'rows')) {

This code seems to be duplicated across your project.

            $rows = ArrayUtils::get($data, 'rows', []);
        } else if (ArrayUtils::has($data, 'data')) {
            $rows = ArrayUtils::get($data, 'data', []);
        }

        return $rows;
    }

    /**
     * Get the response raw data
     *
     * @return array
     */
    public function getRawData()
    {
        return $this->rawData;
    }

    /**
     * Get the response entries
     *
     * @return array
     */
    public function getData()
    {
        return $this->items;
    }

    /**
     * Get the response metadata
     *
     * @return array
     */
    public function getMetaData()
    {
        return $this->metadata;
    }

    /**
     * Create a new iterator based on this collection
     *
     * @return \ArrayIterator
     */
    public function getIterator()
    {
        return new \ArrayIterator($this->items);
    }

    public function offsetExists($offset)
    {
        return array_key_exists($offset, $this->items);
    }

    public function offsetGet($offset)
    {
        return $this->items[$offset];
    }

    public function offsetSet($offset, $value)
    {
        throw new \BadMethodCallException('EntryCollection is read only');
    }

    public function offsetUnset($offset)
    {
        throw new \BadMethodCallException('EntryCollection is read only');
    }

    /**
     * Gets the number of entries in this collection
     *
     * @return int
     */
    public function count()
    {
        return count($this->items);
    }

    /**
     * Gets an object representation of this collection
     *
     * @return object
     */
    public function jsonSerialize()
    {
        return (object) [
            'metadata' => $this->metadata,
            'data' => $this->items
        ];
    }
}