ClientRemote::getEntry() - Code Metrics - Inspection of "update SDK with WIP Directus Database component" - directus/directus-sdk-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 495e06...161604 )

by Welling

created 2016-10-17 02:26 UTC

ClientRemote::getEntry() A

↳ Parent: ClientRemote

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	3

<?php

namespace Directus\SDK;

class ClientRemote extends BaseClientRemote implements RequestsInterface
{
    protected $baseEndpoint = 'http://localhost/api';
    protected $hostedBaseEndpointFormat = 'https://%s.directus.io/api';

    public function fetchTables()
    {
        return $this->performRequest('GET', static::TABLE_LIST_ENDPOINT);
    }

    public function fetchTableInfo($tableName)
    {
        return $this->performRequest('GET', static::TABLE_INFORMATION_ENDPOINT, $tableName);
    }

    public function fetchColumns($tableName)
    {
        return $this->performRequest('GET', static::COLUMN_LIST_ENDPOINT, $tableName);
    }

    public function fetchColumnInfo($tableName, $columnName)
    {
        return $this->performRequest('GET', static::COLUMN_INFORMATION_ENDPOINT, [$tableName, $columnName]);
    }

    public function getEntries($tableName, array $options = [])
    {
        return $this->performRequest('GET', static::TABLE_ENTRIES_ENDPOINT, $tableName);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function getEntry($id, $tableName, array $options = [])
    {
        return $this->performRequest('GET', static::TABLE_ENTRY_ENDPOINT, [$tableName, $id]);
    }

    public function fetchGroups()
    {
        return $this->performRequest('GET', static::GROUP_LIST_ENDPOINT);
    }

    public function fetchGroupInfo($groupID)
    {
        return $this->performRequest('GET', static::GROUP_INFORMATION_ENDPOINT, $groupID);
    }

    public function fetchGroupPrivileges($groupID)
    {
        return $this->performRequest('GET', static::GROUP_PRIVILEGES_ENDPOINT, $groupID);
    }

    public function fetchFiles()
    {
        return $this->performRequest('GET', static::FILE_LIST_ENDPOINT);
    }

    public function fetchFileInfo($fileID)
    {
        return $this->performRequest('GET', static::FILE_INFORMATION_ENDPOINT, $fileID);
    }

    public function fetchSettings()
    {
        return $this->performRequest('GET', static::SETTING_LIST_ENDPOINT);
    }

    public function fetchSettingCollection($collectionName)
    {
        return $this->performRequest('GET', static::SETTING_COLLECTION_ENDPOINT, $collectionName);
    }
}


1			<?php
2
3			namespace Directus\SDK;
4
5			class ClientRemote extends BaseClientRemote implements RequestsInterface
6			{
7			protected $baseEndpoint = 'http://localhost/api';
8			protected $hostedBaseEndpointFormat = 'https://%s.directus.io/api';
9
10			public function fetchTables()
11			{
12			return $this->performRequest('GET', static::TABLE_LIST_ENDPOINT);
13			}
14
15			public function fetchTableInfo($tableName)
16			{
17			return $this->performRequest('GET', static::TABLE_INFORMATION_ENDPOINT, $tableName);
18			}
19
20			public function fetchColumns($tableName)
21			{
22			return $this->performRequest('GET', static::COLUMN_LIST_ENDPOINT, $tableName);
23			}
24
25			public function fetchColumnInfo($tableName, $columnName)
26			{
27			return $this->performRequest('GET', static::COLUMN_INFORMATION_ENDPOINT, [$tableName, $columnName]);
28			}
29
30			public function getEntries($tableName, array $options = [])
31			{
32			return $this->performRequest('GET', static::TABLE_ENTRIES_ENDPOINT, $tableName);
			0 ignored issues – show Documentation introduced 2016-10-17 02:28 UTC by Report Bug Copy Issue Report `$tableName` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
33			}
34
35			public function getEntry($id, $tableName, array $options = [])
36			{
37			return $this->performRequest('GET', static::TABLE_ENTRY_ENDPOINT, [$tableName, $id]);
38			}
39
40			public function fetchGroups()
41			{
42			return $this->performRequest('GET', static::GROUP_LIST_ENDPOINT);
43			}
44
45			public function fetchGroupInfo($groupID)
46			{
47			return $this->performRequest('GET', static::GROUP_INFORMATION_ENDPOINT, $groupID);
48			}
49
50			public function fetchGroupPrivileges($groupID)
51			{
52			return $this->performRequest('GET', static::GROUP_PRIVILEGES_ENDPOINT, $groupID);
53			}
54
55			public function fetchFiles()
56			{
57			return $this->performRequest('GET', static::FILE_LIST_ENDPOINT);
58			}
59
60			public function fetchFileInfo($fileID)
61			{
62			return $this->performRequest('GET', static::FILE_INFORMATION_ENDPOINT, $fileID);
63			}
64
65			public function fetchSettings()
66			{
67			return $this->performRequest('GET', static::SETTING_LIST_ENDPOINT);
68			}
69
70			public function fetchSettingCollection($collectionName)
71			{
72			return $this->performRequest('GET', static::SETTING_COLLECTION_ENDPOINT, $collectionName);
73			}
74			}
75

directus / directus-sdk-php

Push — master ( 495e06...161604 )

ClientRemote::getEntry() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like