dionsnoeijen / sexy-field

src/Command/DeleteFieldCommand.php

<?php

/*
 * This file is part of the SexyField package.
 *
 * (c) Dion Snoeijen <hallo@dionsnoeijen.nl>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare (strict_types = 1);

namespace Tardigrades\Command;

use Symfony\Component\Console\Helper\QuestionHelper;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\ConfirmationQuestion;
use Symfony\Component\Console\Question\Question;
use Tardigrades\Entity\Field;
use Tardigrades\SectionField\SectionFieldInterface\FieldManager;

The type Tardigrades\SectionField\SectionFieldInterface\FieldManager was not found. Maybe you did not declare it correctly or list all dependencies?

use Tardigrades\SectionField\Service\FieldManagerInterface;
use Tardigrades\SectionField\Service\FieldNotFoundException;
use Tardigrades\SectionField\ValueObject\Id;

class DeleteFieldCommand extends FieldCommand
{
    /** @var QuestionHelper */
    private $questionHelper;

    /** @var FieldManagerInterface */
    private $fieldManager;

    public function __construct(
        FieldManagerInterface $fieldManager
    ) {
        $this->fieldManager = $fieldManager;

        parent::__construct('sf:delete-field');
    }

    protected function configure(): void
    {
        $this
            ->setDescription('Delete field.')
            ->setHelp('Shows a list of installed fields, choose the field you would like to delete.');
    }

    protected function execute(InputInterface $input, OutputInterface $output): void
    {
        $this->questionHelper = $this->getHelper('question');

        try {
            $this->showInstalledFields($input, $output);
        } catch (FieldNotFoundException $exception) {
            $output->writeln("Field not found.");
        }
    }

    private function showInstalledFields(InputInterface $input, OutputInterface $output): void
    {
        $fields = $this->fieldManager->readAll();

        $this->renderTable($output, $fields, 'All installed Fields');
        $this->deleteWhatRecord($input, $output);
    }

    private function deleteWhatRecord(InputInterface $input, OutputInterface $output): void
    {
        $field = $this->getField($input, $output);

        $output->writeln('<info>Record with id #' . $field->getId() . ' will be deleted</info>');

        $sure = new ConfirmationQuestion('<comment>Are you sure?</comment> (y/n) ', false);

        if (!$this->questionHelper->ask($input, $output, $sure)) {
            $output->writeln('<comment>Cancelled, nothing deleted.</comment>');
            return;
        }
        $this->fieldManager->delete($field);

It seems like $field can also be of type null; however, parameter $entity of Tardigrades\SectionField\Service\FieldManagerInterface::delete() does only seem to accept Tardigrades\Entity\FieldInterface, maybe add an additional type check?

        $output->writeln('<info>Removed!</info>');
    }

    private function getField(InputInterface $input, OutputInterface $output): ?Field
    {
        $question = new Question('<question>What record do you want to delete?</question> (#id): ');
        $question->setValidator(function ($id) {
            try {
                return $this->fieldManager->read(Id::fromInt((int) $id));
            } catch (FieldNotFoundException $exception) {
                return null;
            }
        });

        $field = $this->questionHelper->ask($input, $output, $question);
        if (!$field) {
            throw new FieldNotFoundException();
        }
        return $field;

The expression return $field could return the type string|true which is incompatible with the type-hinted return Tardigrades\Entity\Field|null. Consider adding an additional type-check to rule them out.

    }
}