dionsnoeijen / sexy-field

src/Command/DeleteApplicationCommand.php

<?php

/*
 * This file is part of the SexyField package.
 *
 * (c) Dion Snoeijen <hallo@dionsnoeijen.nl>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare (strict_types = 1);

namespace Tardigrades\Command;

use Symfony\Component\Console\Helper\QuestionHelper;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\ConfirmationQuestion;
use Symfony\Component\Console\Question\Question;
use Tardigrades\Entity\ApplicationInterface;
use Tardigrades\SectionField\Service\ApplicationManagerInterface;
use Tardigrades\SectionField\Service\ApplicationNotFoundException;
use Tardigrades\SectionField\ValueObject\Id;

class DeleteApplicationCommand extends ApplicationCommand
{
    /** @var ApplicationManagerInterface */
    private $applicationManager;

    /** @var QuestionHelper */
    private $questionHelper;

    public function __construct(
        ApplicationManagerInterface $applicationManager
    ) {
        $this->applicationManager = $applicationManager;

        parent::__construct('sf:delete-application');
    }

    protected function configure()
    {
        $this
            ->setDescription('Delete application')
            ->setHelp('Shows a list of installed applications, choose the application you would like to delete.');
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $this->questionHelper = $this->getHelper('question');

        try {
            $this->showInstalledApplications($input, $output);
        } catch (ApplicationNotFoundException $exception) {
            $output->writeln("Application not found.");
        }
    }

    private function showInstalledApplications(InputInterface $input, OutputInterface $output): void
    {
        $appliactions = $this->applicationManager->readAll();

        $this->renderTable($output, $appliactions, 'All installed Applications');
        $this->deleteWhatRecord($input, $output);
    }

    private function getApplicationRecord(InputInterface $input, OutputInterface $output): ?ApplicationInterface
    {
        $question = new Question('<question>What record do you want to delete?</question> (#id): ');
        $question->setValidator(function ($id) {
            try {
                return $this->applicationManager->read(Id::fromInt((int) $id));
            } catch (ApplicationNotFoundException $exception) {
                return null;
            }
        });

        $applicationRecord = $this->questionHelper->ask($input, $output, $question);
        if (!$applicationRecord) {
            throw new ApplicationNotFoundException();
        }
        return $applicationRecord;

The expression return $applicationRecord could return the type string|true which is incompatible with the type-hinted return Tardigrades\Entity\ApplicationInterface|null. Consider adding an additional type-check to rule them out.

    }

    private function deleteWhatRecord(InputInterface $input, OutputInterface $output): void
    {
        $application = $this->getApplicationRecord($input, $output);

        $output->writeln('<info>Record with id #' . $application->getId() . ' will be deleted</info>');

        $sure = new ConfirmationQuestion('<comment>Are you sure?</comment> (y/n) ', false);

        if (!$this->questionHelper->ask($input, $output, $sure)) {
            $output->writeln('<comment>Cancelled, nothing deleted.</comment>');
            return;
        }
        $this->applicationManager->delete($application);

It seems like $application can also be of type null; however, parameter $entity of Tardigrades\SectionField\Service\ApplicationManagerInterface::delete() does only seem to accept Tardigrades\Entity\ApplicationInterface, maybe add an additional type check?

        $output->writeln('<info>Removed!</info>');
    }
}