dimtrovich / validation

src/Rules/RequiredIfAccepted.php

<?php

/**
 * This file is part of Dimtrovich/Validation.
 *
 * (c) 2023 Dimitri Sitchet Tomkeu <devcode.dst@gmail.com>
 *
 * For the full copyright and license information, please view
 * the LICENSE file that was distributed with this source code.
 */

namespace Dimtrovich\Validation\Rules;

use Dimtrovich\Validation\Rule;

class RequiredIfAccepted extends AbstractRule
{
    /**
     * @var bool
     */
    protected $implicit = true;

    /**
     * @var array
     */
    protected $fillableParams = ['field'];

    /**
     * {@inheritDoc}
     */
    public function check($value): bool
    {
        $this->requireParameters($this->fillableParams);

        $anotherAttribute = $this->parameter('field');
        $anotherValue     = $this->getAttribute()->getValue($anotherAttribute);

        $this->setParameterTextValues((array) $anotherAttribute, 'other_attribute');

        if (Rule::accepted()->check($anotherValue)) {
            $requiredValidator = $this->getRuleValidator('required');

            $requiredValidator->setValidation($this->validation);

It seems like $this->validation can also be of type null; however, parameter $validation of Rakit\Validation\Rule::setValidation() does only seem to accept Rakit\Validation\Validation, maybe add an additional type check?

            $requiredValidator->setAttribute($this->attribute);

It seems like $this->attribute can also be of type null; however, parameter $attribute of Rakit\Validation\Rule::setAttribute() does only seem to accept Rakit\Validation\Attribute, maybe add an additional type check?

            return $requiredValidator->check($value);
        }

        return true;
    }
}