dimtrovich / validation

src/Rules/PresentWithAll.php

<?php

/**
 * This file is part of Dimtrovich/Validation.
 *
 * (c) 2023 Dimitri Sitchet Tomkeu <devcode.dst@gmail.com>
 *
 * For the full copyright and license information, please view
 * the LICENSE file that was distributed with this source code.
 */

namespace Dimtrovich\Validation\Rules;

use Rakit\Validation\Rule;

class PresentWithAll extends AbstractRule
{
    /**
     * @var bool
     */
    protected $implicit = true;

    /**
     * {@inheritDoc}
     */
    public function fillParameters(array $params): Rule
    {
        $this->params['fields'] = $params;

        return $this;
    }

    /**
     * {@inheritDoc}
     */
    public function check($value): bool
    {
        $this->requireParameters(['fields']);

        $fields = $this->parameter('fields');

        $this->setParameterTextValues($fields, 'values');

        foreach ($fields as $field) {
            if (! $this->validation->hasValue($field)) {

The method hasValue() does not exist on null.

                return true;
            }
        }

        $presentValidator = $this->getRuleValidator('present');

        $presentValidator->setValidation($this->validation);

It seems like $this->validation can also be of type null; however, parameter $validation of Rakit\Validation\Rule::setValidation() does only seem to accept Rakit\Validation\Validation, maybe add an additional type check?

        $presentValidator->setAttribute($this->attribute);

It seems like $this->attribute can also be of type null; however, parameter $attribute of Rakit\Validation\Rule::setAttribute() does only seem to accept Rakit\Validation\Attribute, maybe add an additional type check?

        return $presentValidator->check($value);
    }
}