dimtrovich / validation

src/Rules/Mimes.php

<?php

/**
 * This file is part of Dimtrovich/Validation.
 *
 * (c) 2023 Dimitri Sitchet Tomkeu <devcode.dst@gmail.com>
 *
 * For the full copyright and license information, please view
 * the LICENSE file that was distributed with this source code.
 */

namespace Dimtrovich\Validation\Rules;

use Dimtrovich\Validation\Traits\FileTrait;
use Rakit\Validation\Rule;
use Rakit\Validation\Rules\Mimes as RulesMimes;

class Mimes extends AbstractRule
{
    use FileTrait;

    protected array $parameters = [];

    /**
     * {@inheritDoc}
     */
    public function fillParameters(array $params): Rule
    {
        return $this->fillAllowedValuesParameters($params);
    }

    /**
     * {@inheritDoc}
     */
    public function check($value): bool
    {
        $this->requireParameters(['allowed_values']);
        $this->setAllowedValues($this->parameters = $this->parameter('allowed_values'));

        if (! $this->isValidFileInstance($value)) {
            $rule = new RulesMimes();
            $rule->setAttribute($this->getAttribute());

It seems like $this->getAttribute() can also be of type null; however, parameter $attribute of Rakit\Validation\Rule::setAttribute() does only seem to accept Rakit\Validation\Attribute, maybe add an additional type check?

            $rule->setValidation($this->validation);

It seems like $this->validation can also be of type null; however, parameter $validation of Rakit\Validation\Rule::setValidation() does only seem to accept Rakit\Validation\Validation, maybe add an additional type check?

            $rule->setKey($this->getKey());
            $rule->setParameters($this->getParameters());
            $rule->setMessage($this->getMessage());
            $rule->allowTypes($this->parameters);

            return $rule->check($value);
        }

        if ($this->shouldBlockPhpUpload($value, $this->parameters)) {
            return false;
        }

        return $value->getPath() !== '' && in_array($value->guessExtension(), $this->parameters, true);
    }
}