Dimtrovich\Validation\Rules\PresentIf::check()

Complexity

Conditions	3
Paths	2

Size

Total Lines	21
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function check($value): bool
    {
        $this->requireParameters(['field', 'values']);

        $anotherAttribute = $this->parameter('field');
        $definedValues    = $this->parameter('values');
        $anotherValue     = $this->getAttribute()->getValue($anotherAttribute);

        $this->setParameterTextValues((array) $anotherAttribute, 'other_attribute');
        $this->setParameterTextValues((array) $definedValues, 'other_value');

        if (in_array($anotherValue, $definedValues, is_bool($anotherValue) || null === $definedValues)) {
            $presentValidator = $this->getRuleValidator('present');

            $presentValidator->setValidation($this->validation);

It seems like $this->validation can also be of type null; however, parameter $validation of Rakit\Validation\Rule::setValidation() does only seem to accept Rakit\Validation\Validation, maybe add an additional type check?

            $presentValidator->setAttribute($this->attribute);

It seems like $this->attribute can also be of type null; however, parameter $attribute of Rakit\Validation\Rule::setAttribute() does only seem to accept Rakit\Validation\Attribute, maybe add an additional type check?

            return $presentValidator->check($value);
        }

        return true;
    }