Dimtrovich\Validation\Rules\Prohibits::check()

Complexity

Conditions	4
Paths	3

Size

Total Lines	21
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function check($value): bool
    {
        $this->requireParameters(['fields']);

        $parameters = $this->parameter('fields');

        $this->setParameterTextValues($parameters, 'other');

        $requiredValidator = $this->getRuleValidator('required');
        $requiredValidator->setAttribute($this->attribute);

It seems like $this->attribute can also be of type null; however, parameter $attribute of Rakit\Validation\Rule::setAttribute() does only seem to accept Rakit\Validation\Attribute, maybe add an additional type check?

        if ($requiredValidator->check($value)) {
            foreach ($parameters as $parameter) {
                $requiredValidator->setAttribute(new Attribute($this->validation, $parameter));

It seems like $this->validation can also be of type null; however, parameter $validation of Rakit\Validation\Attribute::__construct() does only seem to accept Rakit\Validation\Validation, maybe add an additional type check?

                if ($requiredValidator->check($this->validation->getValue($parameter))) {

The method getValue() does not exist on null.

                    return false;
                }
            }
        }

        return true;
    }