Dimtrovich\Validation\Rules\Phone::check()

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function check($value): bool
    {
        if (! empty($code = $this->parameter('code'))) {
            try {
                $passes = (new CountryPhoneCallback($value, $code))->callPhoneValidator();
            } catch (BadMethodCallException) {
                $code   = $this->getAttribute()->getValue($code);
                $passes = (new CountryPhoneCallback($value, $code))->callPhoneValidator();

It seems like $code can also be of type null; however, parameter $code of Dimtrovich\Validation\Utils\CountryPhoneCallback::__construct() does only seem to accept string, maybe add an additional type check?

            }

            return Helpers::collect($passes)->some(fn ($passe) => $passe);
        }

        return preg_match('/^[\+]?[(]?[0-9]{3}[)]?[-\s\.]?[0-9]{3}[-\s\.]?[0-9]{4,6}$/', $value);

The expression return preg_match('/^[\+]?[(]?[0-9]{3}[)]?[-\s\.]?[0-9]{3}[-\s\.]?[0-9]{4,6}$/', $value) returns the type integer which is incompatible with the type-hinted return boolean.

    }