dimtrovich / php-db-dumper

src/Compressor/NoneCompressor.php

<?php

/**
 * This file is part of dimtrovich/db-dumper".
 *
 * (c) 2024 Dimitri Sitchet Tomkeu <devcode.dst@gmail.com>
 *
 * For the full copyright and license information, please view
 * the LICENSE file that was distributed with this source code.
 */

namespace Dimtrovich\DbDumper\Compressor;

use Dimtrovich\DbDumper\Exceptions\Exception;

class NoneCompressor extends Factory
{
    /**
     * @var false|resource
     */
    private $handler;

    /**
     * {@inheritDoc}
     */
    public function open(string $filename, string $mode = 'wb'): bool
    {
        $this->handler = fopen($filename, $mode);
        if (false === $this->handler) {
            throw Exception::fileNotWritable($filename);
        }

        return true;
    }

    /**
     * {@inheritDoc}
     */
    public function write(string $data): int
    {
        $bytesWritten = fwrite($this->handler, $data);

It seems like $this->handler can also be of type boolean; however, parameter $stream of fwrite() does only seem to accept resource, maybe add an additional type check?

        if (false === $bytesWritten) {
            throw Exception::failledToWrite();
        }

        return $bytesWritten;
    }

    /**
     * {@inheritDoc}
     */
    public function read(): string
    {
        $content = '';

        while (! feof($this->handler)) {

It seems like $this->handler can also be of type boolean; however, parameter $stream of feof() does only seem to accept resource, maybe add an additional type check?

            // Read buffer-size bytes
            $content .= fread($this->handler, 4096); // read 4kb at a time

It seems like $this->handler can also be of type boolean; however, parameter $stream of fread() does only seem to accept resource, maybe add an additional type check?

        }

        return $content;
    }

    /**
     * {@inheritDoc}
     */
    public function close(): bool
    {
        return fclose($this->handler);

It seems like $this->handler can also be of type boolean; however, parameter $stream of fclose() does only seem to accept resource, maybe add an additional type check?

    }
}