Issues in 2013_11_28_152610_create_tables.php - All Issues - Inspection of "replace count by isDirty (#459)" - dimsav/laravel-translatable - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 7a9f3f...238fba )

by Dimitrios

created 2018-05-13 19:54 UTC

migrations/2013_11_28_152610_create_tables.php (6 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

use Illuminate\Database\Schema\Blueprint;
use Illuminate\Database\Migrations\Migration;

class CreateTables extends Migration
namespace YourVendor;

class YourClass { }
{
    /**
     * Run the migrations.
     */
    public function up()
    {
        Schema::create('countries', function (Blueprint $table) {
            $table->increments('id');
            $table->string('code');
            $table->timestamps();
            $table->softDeletes();
        });

        Schema::create('country_translations', function (Blueprint $table) {

            $table->increments('id');
            $table->integer('country_id')->unsigned();
            $table->string('name');
            $table->string('locale')->index();

            $table->unique(['country_id', 'locale']);
            $table->foreign('country_id')->references('id')->on('countries')->onDelete('cascade');
        });

        Schema::create('cities', function (Blueprint $table) {
            $table->increments('id');
            $table->integer('country_id')->unsigned();
            $table->timestamps();

            $table->foreign('country_id')->references('id')->on('countries');
        });

        Schema::create('city_translations', function (Blueprint $table) {

            $table->increments('id');
            $table->integer('city_id')->unsigned();
            $table->string('name');
            $table->string('locale')->index();

            $table->unique(['city_id', 'locale']);
            $table->foreign('city_id')->references('id')->on('cities')->onDelete('cascade');
        });

        Schema::create('companies', function (Blueprint $table) {
            $table->increments('id');
            $table->string('name')->nullable();
            $table->timestamps();
        });

        Schema::create('continents', function (Blueprint $table) {
            $table->increments('id');
            $table->timestamps();
        });

        Schema::create('foods', function (Blueprint $table) {
            $table->increments('id');
            $table->timestamps();
        });

        Schema::create('food_translations', function (Blueprint $table) {

            $table->increments('id');
            $table->integer('food_id')->unsigned();
            $table->string('name');
            $table->string('locale')->index();

            $table->unique(['food_id', 'locale']);
            $table->foreign('food_id')->references('id')->on('foods')->onDelete('cascade');
        });

        Schema::create('continent_translations', function (Blueprint $table) {
            $table->increments('id');
            $table->integer('continent_id')->unsigned();
            $table->string('name');
            $table->string('locale')->index();
            $table->timestamps();
        });

        Schema::create('vegetables', function (Blueprint $table) {
            $table->increments('identity');
            $table->timestamps();
        });

        Schema::create('vegetable_translations', function (Blueprint $table) {

            $table->increments('id');
            $table->integer('vegetable_identity')->unsigned();
            $table->string('name');
            $table->string('locale')->index();

            $table->unique(['vegetable_identity', 'locale']);
            $table->foreign('vegetable_identity')->references('identity')->on('vegetables')->onDelete('cascade');
        });

        Schema::create('people', function (Blueprint $table) {
            $table->increments('id');
            $table->timestamps();
        });

        Schema::create('person_translations', function (Blueprint $table) {

            $table->increments('id');
            $table->integer('person_id')->unsigned();
            $table->string('name');
            $table->string('locale')->index();

            $table->unique(['person_id', 'locale']);
            $table->foreign('person_id')->references('id')->on('people')->onDelete('cascade');
        });
    }

    /**
     * Reverse the migrations.
     */
    public function down()
    {
        Schema::dropIfExists('city_translations');
        Schema::dropIfExists('cities');

        Schema::dropIfExists('country_translations');
        Schema::dropIfExists('countries');

        Schema::dropIfExists('companies');

        Schema::dropIfExists('continent_translations');
        Schema::dropIfExists('continents');
        Schema::dropIfExists('food_translations');
        Schema::dropIfExists('foods');
        Schema::dropIfExists('vegetable_translations');
        Schema::dropIfExists('vegetables');
        Schema::dropIfExists('person_translations');
        Schema::dropIfExists('people');
    }
}


1		<?php
2
3		use Illuminate\Database\Schema\Blueprint;
4		use Illuminate\Database\Migrations\Migration;
5
6		class CreateTables extends Migration
		0 ignored issues – show Coding Style Compatibility introduced 2016-08-10 12:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7		{
8		/**
9		* Run the migrations.
10		*/
11		public function up()
12		{
13		Schema::create('countries', function (Blueprint $table) {
14		$table->increments('id');
15		$table->string('code');
16		$table->timestamps();
17		$table->softDeletes();
18		});
19
20	View Code Duplication	Schema::create('country_translations', function (Blueprint $table) {
		0 ignored issues – show Duplication introduced 2016-08-10 12:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
21		$table->increments('id');
22		$table->integer('country_id')->unsigned();
23		$table->string('name');
24		$table->string('locale')->index();
25
26		$table->unique(['country_id', 'locale']);
27		$table->foreign('country_id')->references('id')->on('countries')->onDelete('cascade');
28		});
29
30		Schema::create('cities', function (Blueprint $table) {
31		$table->increments('id');
32		$table->integer('country_id')->unsigned();
33		$table->timestamps();
34
35		$table->foreign('country_id')->references('id')->on('countries');
36		});
37
38	View Code Duplication	Schema::create('city_translations', function (Blueprint $table) {
		0 ignored issues – show Duplication introduced 2016-08-10 12:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
39		$table->increments('id');
40		$table->integer('city_id')->unsigned();
41		$table->string('name');
42		$table->string('locale')->index();
43
44		$table->unique(['city_id', 'locale']);
45		$table->foreign('city_id')->references('id')->on('cities')->onDelete('cascade');
46		});
47
48		Schema::create('companies', function (Blueprint $table) {
49		$table->increments('id');
50		$table->string('name')->nullable();
51		$table->timestamps();
52		});
53
54		Schema::create('continents', function (Blueprint $table) {
55		$table->increments('id');
56		$table->timestamps();
57		});
58
59		Schema::create('foods', function (Blueprint $table) {
60		$table->increments('id');
61		$table->timestamps();
62		});
63
64	View Code Duplication	Schema::create('food_translations', function (Blueprint $table) {
		0 ignored issues – show Duplication introduced 2016-08-10 12:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
65		$table->increments('id');
66		$table->integer('food_id')->unsigned();
67		$table->string('name');
68		$table->string('locale')->index();
69
70		$table->unique(['food_id', 'locale']);
71		$table->foreign('food_id')->references('id')->on('foods')->onDelete('cascade');
72		});
73
74		Schema::create('continent_translations', function (Blueprint $table) {
75		$table->increments('id');
76		$table->integer('continent_id')->unsigned();
77		$table->string('name');
78		$table->string('locale')->index();
79		$table->timestamps();
80		});
81
82		Schema::create('vegetables', function (Blueprint $table) {
83		$table->increments('identity');
84		$table->timestamps();
85		});
86
87	View Code Duplication	Schema::create('vegetable_translations', function (Blueprint $table) {
		0 ignored issues – show Duplication introduced 2016-08-10 12:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
88		$table->increments('id');
89		$table->integer('vegetable_identity')->unsigned();
90		$table->string('name');
91		$table->string('locale')->index();
92
93		$table->unique(['vegetable_identity', 'locale']);
94		$table->foreign('vegetable_identity')->references('identity')->on('vegetables')->onDelete('cascade');
95		});
96
97		Schema::create('people', function (Blueprint $table) {
98		$table->increments('id');
99		$table->timestamps();
100		});
101
102	View Code Duplication	Schema::create('person_translations', function (Blueprint $table) {
		0 ignored issues – show Duplication introduced 2016-08-17 08:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
103		$table->increments('id');
104		$table->integer('person_id')->unsigned();
105		$table->string('name');
106		$table->string('locale')->index();
107
108		$table->unique(['person_id', 'locale']);
109		$table->foreign('person_id')->references('id')->on('people')->onDelete('cascade');
110		});
111		}
112
113		/**
114		* Reverse the migrations.
115		*/
116		public function down()
117		{
118		Schema::dropIfExists('city_translations');
119		Schema::dropIfExists('cities');
120
121		Schema::dropIfExists('country_translations');
122		Schema::dropIfExists('countries');
123
124		Schema::dropIfExists('companies');
125
126		Schema::dropIfExists('continent_translations');
127		Schema::dropIfExists('continents');
128		Schema::dropIfExists('food_translations');
129		Schema::dropIfExists('foods');
130		Schema::dropIfExists('vegetable_translations');
131		Schema::dropIfExists('vegetables');
132		Schema::dropIfExists('person_translations');
133		Schema::dropIfExists('people');
134		}
135		}
136

dimsav / laravel-translatable

Push — master ( 7a9f3f...238fba )

migrations/2013_11_28_152610_create_tables.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like